publish to 5.0.0 and fix issues #280 #282 #284 #286 #288

- fix: avoid calling OverlayEntry.markNeedsBuild after dispose (#282)
- fix: guard toast RenderBox access to prevent "RenderBox was not laid out" (#280)
- fix: correct dialog onBack interception logic (#284)
- fix: harden showAttach/bindWidget lifecycle and geometry checks (#288)
- test: add regression test for bindPage close on route replace (#286)
- chore: update CHANGELOG for 5.0.0 with issue links

BREAKING CHANGE: adjust dialog onBack interception behavior to match expected handling in #284.
Fixes #280
Fixes #282
Fixes #284
Fixes #286
Fixes #288

Author: xdd666t

CHANGELOG.md

@@ -1,3 +1,9 @@
+# [5.0.0]
+* Breaking change: Align `onBack` interception behavior for dialog/attach. When `onBack` returns `true`, the back event is always intercepted. Fix [#284](https://github.com/fluttercandies/flutter_smart_dialog/issues/284)
+* Fix [#282](https://github.com/fluttercandies/flutter_smart_dialog/issues/282): avoid calling `OverlayEntry.markNeedsBuild` after the entry is disposed during rapid toast updates
+* Fix [#280](https://github.com/fluttercandies/flutter_smart_dialog/issues/280): harden toast layout measurement to avoid `Bad state: RenderBox was not laid out` during page transitions
+* Fix [#288](https://github.com/fluttercandies/flutter_smart_dialog/issues/288): harden `showAttach` + `bindWidget` lifecycle/geometry checks to avoid inactive-element renderObject errors and invalid transform matrix assertions
+
 # [4.9.8+x]
 * SmartDialog.config.checkExist() adjust to SmartDialog.checkExist()
 * Fix [#209](https://github.com/fluttercandies/flutter_smart_dialog/issues/209)
@@ -275,4 +281,4 @@
 # [0.0.x]
 
 * dealing with the problem of package name
-* init
+* init

lib/src/helper/monitor_widget_helper.dart

@@ -30,19 +30,17 @@ class MonitorWidgetHelper {
       prohibitMonitor = true;
       var removeList = <DialogInfo>[];
       for (var item in monitorDialogQueue) {
-        try {
-          var context = item.bindWidget;
-          if (context == null) {
-            throw Error();
-          }
-          _calculate(context, item);
-        } catch (e) {
+        final context = item.bindWidget;
+        if (!_isContextMounted(context)) {
           removeList.add(item);
           SmartLog.d(
             "The element(hashcode: ${item.bindWidget.hashCode}) is recycled and"
             " the 'bindWidget' dialog dismiss automatically",
           );
+          continue;
         }
+
+        _calculate(context!, item);
       }
       for (var i = removeList.length; i > 0; i--) {
         DialogProxy.instance.dismiss(
@@ -55,9 +53,10 @@ class MonitorWidgetHelper {
   }
 
   void _calculate(BuildContext context, DialogInfo item) {
-    var renderObject = context.findRenderObject() as RenderBox?;
+    var renderObject = _safeRenderBox(context);
     if (renderObject == null) {
-      throw Error();
+      item.dialog.hide();
+      return;
     }
 
     if (RouteRecord.curRoute == item.route) {
@@ -69,28 +68,46 @@ class MonitorWidgetHelper {
         _handleDialog(renderObject, item);
       }
     }
-    // var viewport = RenderAbstractViewport.of(renderObject);
-    // var revealedOffset = viewport?.getOffsetToReveal(renderObject, 0.0);
-    // if (revealedOffset != null) {
-    //   // NonPage Scene
-    //   handleDialog();
-    // } else {
-    //   // Page Scene
-    //   if (!item.bindPage) {
-    //     handleDialog();
-    //   }
-    // }
   }
 
-  _handleDialog(RenderBox renderObject, DialogInfo item) {
-    var selfOffset = renderObject.localToGlobal(Offset.zero);
-    if (selfOffset.dx < 0 ||
-        selfOffset.dy < 0 ||
-        selfOffset.dx.isNaN ||
-        selfOffset.dy.isNaN) {
+  void _handleDialog(RenderBox renderObject, DialogInfo item) {
+    try {
+      var selfOffset = renderObject.localToGlobal(Offset.zero);
+      if (selfOffset.dx < 0 ||
+          selfOffset.dy < 0 ||
+          selfOffset.dx.isNaN ||
+          selfOffset.dy.isNaN ||
+          selfOffset.dx.isInfinite ||
+          selfOffset.dy.isInfinite) {
+        item.dialog.hide();
+      } else {
+        item.dialog.appear();
+      }
+    } catch (_) {
       item.dialog.hide();
-    } else {
-      item.dialog.appear();
     }
   }
+
+  bool _isContextMounted(BuildContext? context) {
+    if (context == null) {
+      return false;
+    }
+    if (context is Element) {
+      return context.mounted;
+    }
+    return true;
+  }
+
+  RenderBox? _safeRenderBox(BuildContext context) {
+    try {
+      var renderObject = context.findRenderObject();
+      if (renderObject is RenderBox &&
+          renderObject.attached &&
+          renderObject.hasSize) {
+        return renderObject;
+      }
+    } catch (_) {}
+
+    return null;
+  }
 }

lib/src/helper/pop_monitor/monitor_pop_route.dart

@@ -69,8 +69,10 @@ class MonitorPopRoute with WidgetsBindingObserver {
     // handle contain system dialog and common condition
     if (MonitorPopRoute.handleSmartDialog()) {
       var lastDialog = DialogProxy.instance.dialogQueue.last;
-      if (lastDialog.backType == SmartBackType.normal &&
-          await lastDialog.onBack?.call() != true) {
+      if (await lastDialog.onBack?.call() == true) {
+        return true;
+      }
+      if (lastDialog.backType == SmartBackType.normal) {
         DialogProxy.instance.dismiss(
           status: SmartStatus.dialog,
           closeType: CloseType.back,

lib/src/widget/helper/attach_widget.dart

@@ -34,10 +34,10 @@ class AttachWidget extends StatefulWidget {
     this.aboveBuilder,
   }) : super(key: key);
 
-  /// 目标widget
+  /// target widget
   final BuildContext? targetContext;
 
-  /// 自定义坐标点
+  /// custom target point
   final TargetBuilder? targetBuilder;
 
   final BeforeBuilder beforeBuilder;
@@ -58,11 +58,11 @@ class _AttachWidgetState extends State<AttachWidget>
     with WidgetsBindingObserver {
   late double _postFrameOpacity;
 
-  //offset size
-  late Offset targetOffset;
-  late Size targetSize;
+  // offset & size
+  Offset targetOffset = Offset.zero;
+  Size targetSize = Size.zero;
 
-  //target info
+  // target info
   RectInfo? _targetRect;
   BuildContext? _childContext;
   late Widget _originChild;
@@ -97,8 +97,11 @@ class _AttachWidgetState extends State<AttachWidget>
   @override
   void didChangeMetrics() {
     super.didChangeMetrics();
-    // The latency threshold is approximately 8 milliseconds
+    // The latency threshold is approximately 8 milliseconds.
     Future.delayed(const Duration(milliseconds: 30), () {
+      if (!mounted) {
+        return;
+      }
       _resetState();
     });
   }
@@ -115,53 +118,74 @@ class _AttachWidgetState extends State<AttachWidget>
     List<Widget> above =
         widget.aboveBuilder?.call(targetOffset, targetSize) ?? [];
     return Stack(children: [
-      //blow
       for (var belowWidget in below) belowWidget,
-
-      //target
       Positioned(
         left: _targetRect?.left,
         right: _targetRect?.right,
         top: _targetRect?.top,
         bottom: _targetRect?.bottom,
         child: widget.builder(child, _adjustParam),
       ),
-
-      //above
       for (var aboveWidget in above) aboveWidget,
     ]);
   }
 
   void _resetState() {
+    if (!mounted) {
+      return;
+    }
+
     _originChild = widget.originChild;
     _postFrameOpacity = 0;
+    _targetRect = null;
 
-    final renderBox = widget.targetContext?.findRenderObject() as RenderBox?;
-    if (renderBox != null) {
-      targetOffset = renderBox.localToGlobal(Offset.zero);
-      targetSize = renderBox.size;
-    }
+    final hasTargetInfo = _tryUpdateTargetInfo();
     if (widget.targetBuilder != null) {
-      targetOffset = widget.targetContext != null
-          ? widget.targetBuilder!(
-              targetOffset,
-              Size(targetSize.width, targetSize.height),
-            )
-          : widget.targetBuilder!(Offset.zero, Size.zero);
-      targetSize = widget.targetContext != null ? targetSize : Size.zero;
+      final customOffset = widget.targetBuilder!(
+        targetOffset,
+        Size(targetSize.width, targetSize.height),
+      );
+      if (_isValidOffset(customOffset)) {
+        targetOffset = customOffset;
+      }
+
+      // targetBuilder can work without targetContext.
+      if (widget.targetContext == null && !hasTargetInfo) {
+        final fallbackOffset = widget.targetBuilder!(Offset.zero, Size.zero);
+        targetOffset =
+            _isValidOffset(fallbackOffset) ? fallbackOffset : Offset.zero;
+        targetSize = Size.zero;
+      }
+    }
+
+    // targetContext exists but currently unavailable (inactive/not laid out).
+    if (!hasTargetInfo &&
+        widget.targetContext != null &&
+        widget.targetBuilder == null) {
+      return;
     }
 
     ViewUtils.addSafeUse(() {
-      if (mounted) _handleLocation();
+      if (mounted) {
+        _handleLocation();
+      }
     });
   }
 
-  /// 处理: 方向及其位置
   void _handleLocation() {
-    final selfSize = (_childContext!.findRenderObject() as RenderBox).size;
+    final selfRenderBox = _safeRenderBox(_childContext);
+    if (selfRenderBox == null ||
+        !_isValidOffset(targetOffset) ||
+        !_isValidSize(targetSize)) {
+      return;
+    }
+
+    final selfSize = selfRenderBox.size;
     final screen = MediaQuery.of(context).size;
+    if (!_isValidSize(selfSize) || !_isValidSize(screen)) {
+      return;
+    }
 
-    //动画方向及其位置
     final alignment = _alignment;
 
     if (alignment == Alignment.topLeft) {
@@ -244,12 +268,13 @@ class _AttachWidgetState extends State<AttachWidget>
       return;
     }
 
-    //第一帧后恢复透明度,同时重置位置信息
     _postFrameOpacity = 1;
+    if (!mounted) {
+      return;
+    }
     setState(() {});
   }
 
-  /// 计算attach alignment类型的偏移量
   double _calculateDx(Alignment alignment, Size selfSize) {
     double offset = 0;
     var type = SmartDialog.config.attach.attachAlignmentType;
@@ -284,11 +309,18 @@ class _AttachWidgetState extends State<AttachWidget>
     bool fixedHorizontal = false,
     bool fixedVertical = false,
   }) {
-    final childSize = (_childContext!.findRenderObject() as RenderBox).size;
+    final childRenderBox = _safeRenderBox(_childContext);
     final screen = MediaQuery.of(context).size;
     var rectInfo = RectInfo(left: left, right: right, top: top, bottom: bottom);
+    if (childRenderBox == null || !_isValidSize(screen)) {
+      return rectInfo;
+    }
+
+    final childSize = childRenderBox.size;
+    if (!_isValidSize(childSize)) {
+      return rectInfo;
+    }
 
-    //处理左右边界问题
     if (!fixedHorizontal && left != null) {
       if (left < 0) {
         rectInfo.left = 0;
@@ -302,7 +334,6 @@ class _AttachWidgetState extends State<AttachWidget>
       }
     }
 
-    //处理上下边界问题
     if (!fixedVertical && top != null) {
       if (top < 0) {
         rectInfo.top = 0;
@@ -318,6 +349,50 @@ class _AttachWidgetState extends State<AttachWidget>
 
     return rectInfo;
   }
+
+  bool _tryUpdateTargetInfo() {
+    final renderBox = _safeRenderBox(widget.targetContext);
+    if (renderBox == null) {
+      return false;
+    }
+
+    try {
+      final offset = renderBox.localToGlobal(Offset.zero);
+      final size = renderBox.size;
+      if (!_isValidOffset(offset) || !_isValidSize(size)) {
+        return false;
+      }
+      targetOffset = offset;
+      targetSize = size;
+      return true;
+    } catch (_) {
+      return false;
+    }
+  }
+
+  RenderBox? _safeRenderBox(BuildContext? context) {
+    if (context == null) {
+      return null;
+    }
+
+    try {
+      final renderObject = context.findRenderObject();
+      if (renderObject is RenderBox &&
+          renderObject.attached &&
+          renderObject.hasSize) {
+        return renderObject;
+      }
+    } catch (_) {}
+    return null;
+  }
+
+  bool _isValidOffset(Offset offset) {
+    return offset.dx.isFinite && offset.dy.isFinite;
+  }
+
+  bool _isValidSize(Size size) {
+    return size.width.isFinite && size.height.isFinite;
+  }
 }
 
 class AdaptBuilder extends StatelessWidget {

lib/src/widget/helper/smart_overlay_entry.dart

@@ -8,16 +8,24 @@ class SmartOverlayEntry extends OverlayEntry {
     bool maintainState = false,
   }) : super(builder: builder, opaque: opaque, maintainState: maintainState);
 
+  bool _disposedByOwner = false;
+
   @override
   void markNeedsBuild() {
-    ViewUtils.addSafeUse(() => super.markNeedsBuild());
+    ViewUtils.addSafeUse(() {
+      if (_disposedByOwner || !mounted) {
+        return;
+      }
+      super.markNeedsBuild();
+    });
   }
 
   @override
   void remove() {
-    if (!mounted) {
+    if (_disposedByOwner || !mounted) {
       return;
     }
+    _disposedByOwner = true;
     super.remove();
     super.dispose();
   }