Skip to content

Remove dart:http as a dependency #89

Open
@evaisse

Description

@evaisse

Hello,

I need to update the dart:http package on my app, and I struggle to match the app_review http version dependency.

Don't you think it would be more reasonable to extract the http client from inside the app_review package and let user provide it on boot ? By giving an example in the documentation that would be a bit more tedious to implement but easier to maintain.

https://github.com/fluttercommunity/app_review/blob/master/lib/app_review.dart#L224

We could just add a Future Function() provider to the appreview constructor ?

And it's a breaking change for sure.

Thanks !

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions