Update kustomize dependency to v5.7.0 across Flux repositories

[cappyzawa]

Overview

This document tracks the progress of updating kustomize dependency from v5.6.0 to v5.7.0 across all Flux repositories to resolve the issue described in fluxcd/kustomize-controller#1306.

Background

• Issue: Multiple $patch: delete strategic merge patches in a single patch file cause kustomize-controller to panic
• Root cause: Upstream kustomize bug (patches cause an error with $patch:delete in files with multiple patches kubernetes-sigs/kustomize#5552)
• Solution: Upgrade to kustomize v5.7.0 which includes the fix (PR #5859)

Repositories requiring updates

Based on https://github.com/search?q=org%3Afluxcd%20Pin%20kustomize%20to%20v5.6.0&type=code:

• fluxcd/kustomize-controller: Update kustomize to v5.7.0 and add regression test for multiple patch delete kustomize-controller#1470
• fluxcd/helm-controller: Update kustomize to v5.7.0 helm-controller#1247
• fluxcd/pkg: kustomize: Update kustomize to v5.7.0 pkg#958
• fluxcd/image-automation-controller: Update kustomize to v5.7.0 image-automation-controller#936
• fluxcd/terraform-provider-flux: Update kustomize to v5.7.0 terraform-provider-flux#768

Goals

• All repositories updated to kustomize v5.7.0
• All tests pass in affected repositories
• Regression test in Add test for multiple patch delete in strategic merge patches kustomize-controller#1466 passes
  • The regression test was included in Update kustomize to v5.7.0 and add regression test for multiple patch delete kustomize-controller#1470.
• Issue Kustomization reconciliation fails on multiple $patch: delete uses in a single strategic merge patch kustomize-controller#1306 can be closed

Related issues

• Kustomization reconciliation fails on multiple $patch: delete uses in a single strategic merge patch kustomize-controller#1306 - Original issue report
• Add test for multiple patch delete in strategic merge patches kustomize-controller#1466 - PR with regression test
• patches cause an error with $patch:delete in files with multiple patches kubernetes-sigs/kustomize#5552 - Upstream kustomize issue
• fix: Don't panic on multiple $patch: delete strategic merge patches in a single patch file kubernetes-sigs/kustomize#5859 - Upstream fix

Notes

• Each repository will need individual PRs due to independent versioning
• Updates should be coordinated to ensure compatibility
• Testing should verify the fix resolves the original panic issue

[cappyzawa]

Could you please assign me to this issue? I'll start working on the individual PRs for each repository.

[matheuscscp]

Thanks very much once again @cappyzawa!

Btw, just as important for Flux 2.7 is upgrading to Helm 3.18. We attempted this upgrade right before Flux 2.6 but it had a few breakages so we decided it was too risky. Now we have a long time until 2.7, so it's good if we upgrade early to see any potential effects. Context in this PR (I just left a TLDR now at the end):

fluxcd/source-controller#1805

[cappyzawa]

ref: fluxcd/cli-utils#15

[cappyzawa]

I initially targeted only those that were pinned to kustomize v5.6.0, as shown in https://github.com/search?q=org%3Afluxcd%20Pin%20kustomize%20to%20v5.6.0&type=code, but it seems I should have updated all repositories that depend on kustomize.

[matheuscscp]

@cappyzawa Sorry, it's my mistake, I missed that we actually have a more complex process to be followed for Kustomize upgrades:

• First we need to bump https://github.com/fluxcd/cli-utils
• Release the bumps in https://github.com/fluxcd/cli-utils
• Upgrade both Kustomize and cli-utils everywhere in https://github.com/fluxcd/pkg
• Release the bumps in https://github.com/fluxcd/pkg
• Bump controllers and flux2

Additionally, Kustomize is a kubectl dependency, so all these things must be bumped together with Kubernetes, we should've waited for Kubernetes 1.34.

Furthermore, Kustomize 5.7 has some major breaking changes in YAML handling, and @stefanprodan has been coordinating about this with Kubernetes for a while, which I also missed. He'll be finishing this upgrade, no need to worry about that 👍