-
Notifications
You must be signed in to change notification settings - Fork 686
Closed
Description
Overview
This document tracks the progress of updating kustomize dependency from v5.6.0 to v5.7.0 across all Flux repositories to resolve the issue described in fluxcd/kustomize-controller#1306.
Background
- Issue: Multiple
$patch: deletestrategic merge patches in a single patch file cause kustomize-controller to panic - Root cause: Upstream kustomize bug (patches cause an error with $patch:delete in files with multiple patches kubernetes-sigs/kustomize#5552)
- Solution: Upgrade to kustomize v5.7.0 which includes the fix (PR #5859)
Repositories requiring updates
Based on https://github.com/search?q=org%3Afluxcd%20Pin%20kustomize%20to%20v5.6.0&type=code:
- fluxcd/kustomize-controller: Update kustomize to v5.7.0 and add regression test for multiple patch delete kustomize-controller#1470
- fluxcd/helm-controller: Update kustomize to v5.7.0 helm-controller#1247
- fluxcd/pkg: kustomize: Update kustomize to v5.7.0 pkg#958
- fluxcd/image-automation-controller: Update kustomize to v5.7.0 image-automation-controller#936
- fluxcd/terraform-provider-flux: Update kustomize to v5.7.0 terraform-provider-flux#768
Goals
- All repositories updated to kustomize v5.7.0
- All tests pass in affected repositories
- Regression test in
Add test for multiple patch delete in strategic merge patches kustomize-controller#1466passes- The regression test was included in Update kustomize to v5.7.0 and add regression test for multiple patch delete kustomize-controller#1470.
- Issue Kustomization reconciliation fails on multiple $patch: delete uses in a single strategic merge patch kustomize-controller#1306 can be closed
Related issues
- Kustomization reconciliation fails on multiple $patch: delete uses in a single strategic merge patch kustomize-controller#1306 - Original issue report
- Add test for multiple patch delete in strategic merge patches kustomize-controller#1466 - PR with regression test
- patches cause an error with $patch:delete in files with multiple patches kubernetes-sigs/kustomize#5552 - Upstream kustomize issue
- fix: Don't panic on multiple $patch: delete strategic merge patches in a single patch file kubernetes-sigs/kustomize#5859 - Upstream fix
Notes
- Each repository will need individual PRs due to independent versioning
- Updates should be coordinated to ensure compatibility
- Testing should verify the fix resolves the original panic issue
Metadata
Metadata
Assignees
Labels
No labels