Commit 98f45a8
committed
Add missing defer summarize(req) in UninstallRemediation
UninstallRemediation is the only action reconciler that does not call
defer summarize(req). All other reconcilers (Install, Upgrade, Test,
Uninstall, Unlock, RollbackRemediation) include this deferred call to
propagate sub-conditions into the top-level Ready condition.
Without this call, the Ready condition is never updated after an
uninstall remediation, leaving a stale status until the next
reconciliation pass.
Add ReadyCondition assertions to both uninstall success test cases to
prevent regressions, matching the pattern in rollback_remediation_test.go.
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Assisted-by: Grok/grok-4
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>1 parent ca9234b commit 98f45a8
2 files changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
87 | 89 | | |
88 | 90 | | |
89 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
111 | 112 | | |
112 | 113 | | |
113 | 114 | | |
| 115 | + | |
| 116 | + | |
114 | 117 | | |
115 | 118 | | |
116 | 119 | | |
| |||
332 | 335 | | |
333 | 336 | | |
334 | 337 | | |
| 338 | + | |
| 339 | + | |
335 | 340 | | |
336 | 341 | | |
337 | 342 | | |
| |||
0 commit comments