Skip to content

UninstallRemediation missing defer summarize(req), Ready condition not updated #1488

Description

@SebTardif

Description

UninstallRemediation.Reconcile is the only action reconciler that does not call defer summarize(req). All other reconcilers include this deferred call:

  • Install (install.go:79)
  • Upgrade (upgrade.go:75)
  • Test (test.go:78)
  • Uninstall (uninstall.go:88)
  • Unlock (unlock.go:64)
  • RollbackRemediation (rollback_remediation.go:82)

The summarize function propagates sub-conditions (Released, Remediated, TestSuccess) into the top-level Ready condition and refreshes ObservedPostRenderersDigest / ObservedCommonMetadataDigest.

UninstallRemediation is a ReconcilerTypeRemediate, so after it runs, AtomicRelease.strategy.MustStop() returns true and the outer loop exits without its own summarize call. This means the Ready condition is never updated after an uninstall remediation, leaving stale status until the next reconciliation pass.

Steps to Reproduce

  1. Configure a HelmRelease with uninstall remediation strategy
  2. Trigger a failed upgrade that activates uninstall remediation
  3. Observe that the Ready condition is not updated after remediation completes

Expected Behavior

The Ready condition should be updated after uninstall remediation, consistent with all other reconcilers.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions