Skip to content

Rate limiting: Use conditional requests for GitHub commit status updates #977

Open
@fadi-bwa

Description

@fadi-bwa

We use notification-controller to update our GitHub repos' commit statuses. Since there are a couple of hundred of those repositories and we reconcile our Kustomizations quite often, we get rate limited by GitHub.

Since we'd like to keep our short reconciliation interval I'm proposing to implement conditional requests for requests made to GitHub by the notification-controller.

All that's required for that is to save the value of the etag header from the last request made to a repository and then add its value to a new header if-none-match on the next request.

Happy to share any additional info you need or help with the implementation if I can, please just ping me - thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions