Skip to content

Commit 4d1fe88

Browse files
committed
Remove redundant chown to public since the whole html folder is being chowned
1 parent ef3f43e commit 4d1fe88

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ Before diving into making local development changes, there're some to-do's to ge
9494

9595
1. Clone the repository
9696
2. Get the repo dependencies with `composer install`
97-
3. If you run into any issues, find the `Getting Pass Hurdles` section below for common solutions
97+
3. If you run into any issues, find the `Getting Past Hurdles` section below for common solutions
9898

9999
Then, yes. After set up, you can make your changes!
100100

@@ -135,6 +135,12 @@ Once you've successfully built your changes, you have to test how it turned out.
135135
```
136136
And that's it! You should now see a fresh Dockerfile available for your project.
137137

138+
### Testing the Dockerfile generated Locally
139+
1. Make sure that the necessary files that are needed locally is available to the image by reviewing the .dockerignore and .gitignore
140+
2. Build the image with `docker build -t <image-name> .`
141+
3. Run the image with `docker run -it -p 8080:8080 <image-name>`
142+
143+
138144
## Test Cases
139145
There are two general purpose test cases in `tests/Feature/GenerateCommandTest.php`:
140146

resources/views/dockerfile.blade.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@
128128
COPY --from=node_modules_go_brrr /app/public /var/www/html/public-npm
129129
RUN rsync -ar /var/www/html/public-npm/ /var/www/html/public/ \
130130
&& rm -rf /var/www/html/public-npm \
131-
&& chown -R www-data:www-data /var/www/html/public \
132131
&& chown -R www-data:www-data /var/www/html
133132
@endif
134133

0 commit comments

Comments
 (0)