We're getting a couple false positives on checking the return value from 'save' where we clearly are checking it.
- The case where the result is assigned to something, and then checked later:
saved =
begin
@thing.save
rescue SomeOtherError => e
...
end
if saved
...
end
- The case where the result is checked via an aggregate of some sort:
# any? { ... } may also trigger it but haven't tested, I'm just including it the way I found it in our code,
if @things.map { |thing| !thing.save }.any?
...
end