PL-135277: log auth token identifier in proxy#33
Open
elikoga wants to merge 2 commits into
Open
Conversation
elikoga
force-pushed
the
PL-135277-token-usage-logging
branch
2 times, most recently
from
45b83a4 to
55349e2
Compare
- Set request.state.token_id in auth verify_token/verify_admin_token (full Aramaki client ID for customer tokens, "admin" for static tokens) - Add token_id to access log output (second field after IP) - Add token_id label to gateway_requests_total Prometheus metric - Update tests to pass mock request to verify_token
elikoga
force-pushed
the
PL-135277-token-usage-logging
branch
2 times, most recently
from
603347c to
6a6afe3
Compare
- Set request.state.token_id in auth verify_token/verify_admin_token
("admin-token" for static tokens, Aramaki client ID for customer tokens)
- Add token_id to access log output (second field after IP)
- Update tests to use shared mock_request_factory fixture
elikoga
force-pushed
the
PL-135277-token-usage-logging
branch
from
6a6afe3 to
1e295f2
Compare
elikoga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log auth token identifier in the main proxy so we know what's going on.
request.state.token_idinverify_token/verify_admin_token("admin-token" for static tokens, Aramaki token ID for customer tokens)token_idto access log output (second field after IP)