Skip to content

Code improvements: improve loadSpecialSettings in emulator.cpp #2246

@sw4gadmin

Description

@sw4gadmin

I was curious about working code of sega dreamcast emulator and first thing that ironically i opened was emulator.cpp

The main thing i can see right now that logic of detecting games with some settings is kinda messy and may work slow

Why instead of checking every name and compare every string of game-code

Image

We can't just create list (std::vectorstd::string for example), put all codes with info about game that have this code

Image

And then search game code from list by using std::find

Image

Which will be MUCH faster than current logic?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions