Skip to content

Commit 875aeae

Browse files
committed
feat: carry enacted_by identity on Abort/Signal and add SignalInfo result
Add `aborted_by` to `AbortRequest` and `signalled_by` to `SignalRequest` (both `common.EnrichedIdentity`) so the Run Service can record the actor that initiated an abort/signal. Add a `SignalInfo` result branch on `ActionDetails` for surfacing the signaller identity on terminal condition actions. Assisted-by: Claude Signed-off-by: Sergey Vilgelm <sergey@union.ai>
1 parent ff71f0a commit 875aeae

6 files changed

Lines changed: 995 additions & 612 deletions

File tree

flyteidl2/actions/actions_service.proto

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ package flyteidl2.actions;
44

55
import "buf/validate/validate.proto";
66
import "flyteidl2/common/identifier.proto";
7+
import "flyteidl2/common/identity.proto";
78
import "flyteidl2/core/literals.proto";
89
import "flyteidl2/task/run.proto";
910
import "flyteidl2/workflow/run_definition.proto";
@@ -150,6 +151,11 @@ message AbortRequest {
150151

151152
// Reason for aborting the action, if applicable.
152153
optional string reason = 2;
154+
155+
// Identity of the caller that issued the abort. Populated by Run Service
156+
// with a stripped-down EnrichedIdentity (subject only) for storage and
157+
// replication; the full identity is re-enriched on read.
158+
optional flyteidl2.common.EnrichedIdentity aborted_by = 3;
153159
}
154160

155161
// AbortResponse is the response message for aborting a queued or running action.
@@ -171,6 +177,11 @@ message SignalRequest {
171177
// The value literal to signal the condition with. Must match the
172178
// ConditionAction.type declared at enqueue time.
173179
flyteidl2.core.Literal value = 3 [(buf.validate.field).required = true];
180+
181+
// Identity of the caller that issued the signal. Populated by Run Service
182+
// with a stripped-down EnrichedIdentity (subject only) for storage and
183+
// replication; the full identity is re-enriched on read.
184+
optional flyteidl2.common.EnrichedIdentity signalled_by = 4;
174185
}
175186

176187
// SignalResponse is the response message for resolving a condition action.

flyteidl2/workflow/run_definition.proto

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,12 @@ message AbortInfo {
273273
common.EnrichedIdentity aborted_by = 2;
274274
}
275275

276+
// SignalInfo captures details of a condition action resolved via Signal.
277+
message SignalInfo {
278+
// Identity that signalled the condition.
279+
common.EnrichedIdentity signalled_by = 1;
280+
}
281+
276282
// ActionDetails is the full details of an action.
277283
message ActionDetails {
278284
// Id for this action.
@@ -289,6 +295,8 @@ message ActionDetails {
289295
ErrorInfo error_info = 4;
290296
// Abort info for the action, if aborted.
291297
AbortInfo abort_info = 5;
298+
// Signal info for a condition action resolved via Signal.
299+
SignalInfo signal_info = 10;
292300
}
293301

294302
// Fully resolved spec of the action. Merges user submitted task spec with platform defaults.

0 commit comments

Comments
 (0)