Update Go to 1.25 (#7326)

* Update Go to 1.25

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

* Update golangci-lint

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

* update boilerplate

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

* fix new refs

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

* use bookworm

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

* make lint-fix

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

---------

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

Author: Sovietaced

.github/workflows/flyte-binary-v2.yml

@@ -33,9 +33,10 @@ jobs:
         with:
           go-version-file: go.mod
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v9
         with:
           working-directory: docker/devbox-bundled/bootstrap
+          version: v2.6.2
       - name: Check formatting
         working-directory: docker/devbox-bundled/bootstrap
         run: |

.github/workflows/go-tests.yml

@@ -40,7 +40,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.24"
+          go-version: "1.25"
           cache: true
 
       - name: Cache embedded postgres

CONTRIBUTING.md

@@ -17,7 +17,7 @@ Thank you for your interest in contributing to Flyte 2! This guide will help you
 
 Before contributing, ensure you have:
 - [Buf CLI](https://buf.build/docs/installation) installed
-- Go 1.24.6 or later
+- Go 1.25.7 or later
 - Node.js and npm (for TypeScript)
 - Python 3.10+ with `uv` package manager
 - Rust toolchain (if working with Rust bindings)

Dockerfile

@@ -1,6 +1,6 @@
 # Todo(alex): We should add UI into the image when UI is done
 
-FROM --platform=${BUILDPLATFORM} golang:1.24-bookworm AS flytebuilder
+FROM --platform=${BUILDPLATFORM} golang:1.25-bookworm AS flytebuilder
 
 ARG TARGETARCH
 ENV GOARCH="${TARGETARCH}"

boilerplate/flyte/golang_support_tools/go.mod

@@ -4,10 +4,10 @@
 package tools
 
 import (
-	_ "github.com/vektra/mockery/v3/cmd"
 	_ "github.com/alvaroloes/enumer"
-	_ "github.com/golangci/golangci-lint/cmd/golangci-lint"
+	_ "github.com/golangci/golangci-lint/v2/cmd/golangci-lint"
 	_ "github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc"
+	_ "github.com/vektra/mockery/tools/cmd"
 
 	_ "github.com/flyteorg/flyte/flytestdlib/cli/pflags"
 )

boilerplate/flyte/golang_support_tools/go.sum

@@ -15,7 +15,7 @@ generate: download_tooling #generate go code
 
 .PHONY: lint
 lint: download_tooling #lints the package for common code smells
-	GL_DEBUG=linters_output,env golangci-lint run $(LINT_FLAGS) --timeout=5m --exclude deprecated -v
+	GL_DEBUG=linters_output,env golangci-lint run $(LINT_FLAGS) --timeout=5m -v
 
 .PHONY: lint-fix
 lint-fix: LINT_FLAGS=--fix

boilerplate/flyte/golang_support_tools/tools.go

@@ -16,8 +16,8 @@ set -e
 # List of tools to go get
 # In the format of "<cli>:<package>" or ":<package>" if no cli
 tools=(
-	"github.com/vektra/mockery/v3@v3.7.0"
-	"github.com/golangci/golangci-lint/cmd/golangci-lint"
+	"github.com/vektra/mockery/tools@v0.0.0-20260415212850-680532c11aba"
+  "github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.6.2"
 	"github.com/daixiang0/gci"
 	"github.com/alvaroloes/enumer"
 	"github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc"

boilerplate/flyte/golang_test_targets/Makefile

@@ -3,38 +3,39 @@
 # 
 # TO OPT OUT OF UPDATES, SEE https://github.com/flyteorg/boilerplate/blob/master/Readme.rst
 
+version: "2"
 run:
-  skip-dirs:
-    - pkg/client
-
+  allow-parallel-runners: true
 linters:
-  disable-all: true
+  default: none
   enable:
-    - deadcode
+    - copyloopvar
+    - dupl
     - errcheck
-    - gas
-    - gci
+    - ginkgolinter
     - goconst
-    - goimports
-    - golint
-    - gosimple
+    - gocyclo
     - govet
     - ineffassign
+    - lll
     - misspell
     - nakedret
+    - prealloc
+    - revive
     - staticcheck
-    - structcheck
-    - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
-
-linters-settings:
-  gci:
-    custom-order: true
-    sections:
-      - standard
-      - default
-      - prefix(github.com/flyteorg)
-    skip-generated: true
+  settings:
+    revive:
+      rules:
+        - name: comment-spacings
+        - name: import-shadowing
+  exclusions:
+    generated: lax
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax