Skip to content

Commit a97506d

Browse files
SovietacedSovietaced
committed
Fix unit tests
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
1 parent 4848031 commit a97506d

45 files changed

Lines changed: 43 additions & 279 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎flytepropeller/pkg/apis/flyteworkflow/v1alpha1/testdata/workflowspec.yaml‎

Lines changed: 0 additions & 220 deletions
This file was deleted.

‎flytepropeller/pkg/apis/flyteworkflow/v1alpha1/workflow_test.go‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package v1alpha1_test
22

33
import (
4-
"encoding/json"
54
"io/ioutil"
65
"testing"
76

@@ -19,21 +18,6 @@ func ReadYamlFileAsJSON(path string) ([]byte, error) {
1918
return yaml.YAMLToJSON(r)
2019
}
2120

22-
func TestWorkflowSpec(t *testing.T) {
23-
j, err := ReadYamlFileAsJSON("testdata/workflowspec.yaml")
24-
assert.NoError(t, err)
25-
w := &v1alpha1.FlyteWorkflow{}
26-
err = json.Unmarshal(j, w)
27-
if !assert.NoError(t, err) {
28-
t.FailNow()
29-
}
30-
31-
assert.NotNil(t, w.WorkflowSpec)
32-
assert.Nil(t, w.GetOnFailureNode())
33-
assert.Equal(t, 7, len(w.GetConnections().Downstream))
34-
assert.Equal(t, 8, len(w.GetConnections().Upstream))
35-
}
36-
3721
func TestWorkflowIsInterruptible(t *testing.T) {
3822
w := &v1alpha1.FlyteWorkflow{}
3923

‎flytepropeller/pkg/compiler/test/testdata/snacks-core/k8s/002_core.containerization.multi_images.my_workflow_2_wf_crd.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"kind":"flyteworkflow","apiVersion":"flyte.lyft.com/v1alpha1","metadata":{"name":"name","namespace":"namespace","labels":{"domain":"domain","execution-id":"name","project":"hello","shard-key":"6","workflow-name":"core-containerization-multi-images-my-workflow"}},"spec":{"id":"::core.containerization.multi_images.my_workflow","nodes":{"end-node":{"id":"end-node","resources":{},"kind":"end","inputBindings":[{"var":"o0","binding":{"promise":{"nodeId":"n1","var":"o0"}}}]},"n0":{"id":"n0","name":"svm_trainer","resources":{},"kind":"task","task":"resource_type:TASK name:\"core.containerization.multi_images.svm_trainer\""},"n1":{"id":"n1","name":"svm_predictor","resources":{},"kind":"task","task":"resource_type:TASK name:\"core.containerization.multi_images.svm_predictor\"","inputBindings":[{"var":"X_test","binding":{"promise":{"nodeId":"n0","var":"test_features"}}},{"var":"X_train","binding":{"promise":{"nodeId":"n0","var":"train_features"}}},{"var":"y_test","binding":{"promise":{"nodeId":"n0","var":"test_labels"}}},{"var":"y_train","binding":{"promise":{"nodeId":"n0","var":"train_labels"}}}]},"start-node":{"id":"start-node","resources":{},"kind":"start"}},"connections":{"n0":["n1"],"n1":["end-node"],"start-node":["n0"]},"edges":{"downstream":{"n0":["n1"],"n1":["end-node"],"start-node":["n0"]},"upstream":{"end-node":["n1"],"n0":["start-node"],"n1":["n0"]}},"outputs":{"variables":{"o0":{"type":{"simple":"FLOAT"}}}},"outputBindings":[{"var":"o0","binding":{"promise":{"nodeId":"n1","var":"o0"}}}]},"inputs":{},"executionId":{},"tasks":{"resource_type:TASK name:\"core.containerization.multi_images.svm_predictor\"":{"id":{"resourceType":"TASK","name":"core.containerization.multi_images.svm_predictor"},"type":"python-task","metadata":{"runtime":{"type":"FLYTE_SDK","version":"0.32.6","flavor":"python"},"retries":{}},"interface":{"inputs":{"variables":{"X_test":{"type":{"structuredDatasetType":{"format":"parquet"}}},"X_train":{"type":{"structuredDatasetType":{"format":"parquet"}}},"y_test":{"type":{"structuredDatasetType":{"format":"parquet"}}},"y_train":{"type":{"structuredDatasetType":{"format":"parquet"}}}}},"outputs":{"variables":{"o0":{"type":{"simple":"FLOAT"}}}}},"container":{"image":"ghcr.io/flyteorg/flytecookbook:multi-image-predict-98b125fd57d20594026941c2ebe7ef662e5acb7d6423660a65f493ca2d9aa267","args":["pyflyte-execute","--inputs","{{.input}}","--output-prefix","{{.outputPrefix}}","--raw-output-data-prefix","{{.rawOutputDataPrefix}}","--checkpoint-path","{{.checkpointOutputPrefix}}","--prev-checkpoint","{{.prevCheckpointPrefix}}","--resolver","flytekit.core.python_auto_container.default_task_resolver","--","task-module","core.containerization.multi_images","task-name","svm_predictor"],"resources":{},"config":[{"key":"testKey1","value":"testValue1"},{"key":"testKey2","value":"testValue2"},{"key":"testKey3","value":"testValue3"}]}},"resource_type:TASK name:\"core.containerization.multi_images.svm_trainer\"":{"id":{"resourceType":"TASK","name":"core.containerization.multi_images.svm_trainer"},"type":"python-task","metadata":{"runtime":{"type":"FLYTE_SDK","version":"0.32.6","flavor":"python"},"retries":{}},"interface":{"inputs":{},"outputs":{"variables":{"test_features":{"type":{"structuredDatasetType":{"format":"parquet"}}},"test_labels":{"type":{"structuredDatasetType":{"format":"parquet"}}},"train_features":{"type":{"structuredDatasetType":{"format":"parquet"}}},"train_labels":{"type":{"structuredDatasetType":{"format":"parquet"}}}}}},"container":{"image":"ghcr.io/flyteorg/flytecookbook:core-with-sklearn-baa17ccf39aa667c5950bd713a4366ce7d5fccaf7f85e6be8c07fe4b522f92c3","args":["pyflyte-execute","--inputs","{{.input}}","--output-prefix","{{.outputPrefix}}","--raw-output-data-prefix","{{.rawOutputDataPrefix}}","--checkpoint-path","{{.checkpointOutputPrefix}}","--prev-checkpoint","{{.prevCheckpointPrefix}}","--resolver","flytekit.core.python_auto_container.default_task_resolver","--","task-module","core.containerization.multi_images","task-name","svm_trainer"],"resources":{},"config":[{"key":"testKey1","value":"testValue1"},{"key":"testKey2","value":"testValue2"},{"key":"testKey3","value":"testValue3"}]}}},"node-defaults":{},"securityContext":{},"status":{"phase":0},"rawOutputDataConfig":{},"executionConfig":{"TaskPluginImpls":null,"MaxParallelism":0,"RecoveryExecution":{},"TaskResources":{"Requests":{"CPU":"0","Memory":"0","EphemeralStorage":"0","Storage":"0","GPU":"0"},"Limits":{"CPU":"0","Memory":"0","EphemeralStorage":"0","Storage":"0","GPU":"0"}},"Interruptible":null,"OverwriteCache":false,"EnvironmentVariables":null}}
1+
{"kind":"flyteworkflow","apiVersion":"flyte.lyft.com/v1alpha1","metadata":{"name":"name","namespace":"namespace","labels":{"domain":"domain","execution-id":"name","project":"hello","shard-key":"6","workflow-name":"core-containerization-multi-images-my-workflow"}},"spec":{"id":"::core.containerization.multi_images.my_workflow","nodes":{"end-node":{"id":"end-node","resources":{},"kind":"end","inputBindings":[{"var":"o0","binding":{"promise":{"nodeId":"n1","var":"o0"}}}]},"n0":{"id":"n0","name":"svm_trainer","resources":{},"kind":"task","task":"resource_type:TASK name:\"core.containerization.multi_images.svm_trainer\""},"n1":{"id":"n1","name":"svm_predictor","resources":{},"kind":"task","task":"resource_type:TASK name:\"core.containerization.multi_images.svm_predictor\"","inputBindings":[{"var":"X_test","binding":{"promise":{"nodeId":"n0","var":"test_features"}}},{"var":"X_train","binding":{"promise":{"nodeId":"n0","var":"train_features"}}},{"var":"y_test","binding":{"promise":{"nodeId":"n0","var":"test_labels"}}},{"var":"y_train","binding":{"promise":{"nodeId":"n0","var":"train_labels"}}}]},"start-node":{"id":"start-node","resources":{},"kind":"start"}},"edges":{"downstream":{"n0":["n1"],"n1":["end-node"],"start-node":["n0"]},"upstream":{"end-node":["n1"],"n0":["start-node"],"n1":["n0"]}},"outputs":{"variables":{"o0":{"type":{"simple":"FLOAT"}}}},"outputBindings":[{"var":"o0","binding":{"promise":{"nodeId":"n1","var":"o0"}}}]},"inputs":{},"executionId":{},"tasks":{"resource_type:TASK name:\"core.containerization.multi_images.svm_predictor\"":{"id":{"resourceType":"TASK","name":"core.containerization.multi_images.svm_predictor"},"type":"python-task","metadata":{"runtime":{"type":"FLYTE_SDK","version":"0.32.6","flavor":"python"},"retries":{}},"interface":{"inputs":{"variables":{"X_test":{"type":{"structuredDatasetType":{"format":"parquet"}}},"X_train":{"type":{"structuredDatasetType":{"format":"parquet"}}},"y_test":{"type":{"structuredDatasetType":{"format":"parquet"}}},"y_train":{"type":{"structuredDatasetType":{"format":"parquet"}}}}},"outputs":{"variables":{"o0":{"type":{"simple":"FLOAT"}}}}},"container":{"image":"ghcr.io/flyteorg/flytecookbook:multi-image-predict-98b125fd57d20594026941c2ebe7ef662e5acb7d6423660a65f493ca2d9aa267","args":["pyflyte-execute","--inputs","{{.input}}","--output-prefix","{{.outputPrefix}}","--raw-output-data-prefix","{{.rawOutputDataPrefix}}","--checkpoint-path","{{.checkpointOutputPrefix}}","--prev-checkpoint","{{.prevCheckpointPrefix}}","--resolver","flytekit.core.python_auto_container.default_task_resolver","--","task-module","core.containerization.multi_images","task-name","svm_predictor"],"resources":{},"config":[{"key":"testKey1","value":"testValue1"},{"key":"testKey2","value":"testValue2"},{"key":"testKey3","value":"testValue3"}]}},"resource_type:TASK name:\"core.containerization.multi_images.svm_trainer\"":{"id":{"resourceType":"TASK","name":"core.containerization.multi_images.svm_trainer"},"type":"python-task","metadata":{"runtime":{"type":"FLYTE_SDK","version":"0.32.6","flavor":"python"},"retries":{}},"interface":{"inputs":{},"outputs":{"variables":{"test_features":{"type":{"structuredDatasetType":{"format":"parquet"}}},"test_labels":{"type":{"structuredDatasetType":{"format":"parquet"}}},"train_features":{"type":{"structuredDatasetType":{"format":"parquet"}}},"train_labels":{"type":{"structuredDatasetType":{"format":"parquet"}}}}}},"container":{"image":"ghcr.io/flyteorg/flytecookbook:core-with-sklearn-baa17ccf39aa667c5950bd713a4366ce7d5fccaf7f85e6be8c07fe4b522f92c3","args":["pyflyte-execute","--inputs","{{.input}}","--output-prefix","{{.outputPrefix}}","--raw-output-data-prefix","{{.rawOutputDataPrefix}}","--checkpoint-path","{{.checkpointOutputPrefix}}","--prev-checkpoint","{{.prevCheckpointPrefix}}","--resolver","flytekit.core.python_auto_container.default_task_resolver","--","task-module","core.containerization.multi_images","task-name","svm_trainer"],"resources":{},"config":[{"key":"testKey1","value":"testValue1"},{"key":"testKey2","value":"testValue2"},{"key":"testKey3","value":"testValue3"}]}}},"node-defaults":{},"securityContext":{},"status":{"phase":0},"rawOutputDataConfig":{},"executionConfig":{"TaskPluginImpls":null,"MaxParallelism":0,"RecoveryExecution":{},"TaskResources":{"Requests":{"CPU":"0","Memory":"0","EphemeralStorage":"0","Storage":"0","GPU":"0"},"Limits":{"CPU":"0","Memory":"0","EphemeralStorage":"0","Storage":"0","GPU":"0"}},"Interruptible":null,"OverwriteCache":false,"EnvironmentVariables":null}}

0 commit comments

Comments
 (0)