Skip to content

Commit ca3de32

Browse files
committed
docs(apps): drop the verbose service-account comment
Signed-off-by: Kevin Su <pingsutw@apache.org>
1 parent 97edf27 commit ca3de32

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

app/internal/k8s/app_client.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -573,10 +573,6 @@ func (c *AppK8sClient) buildKService(app *flyteapp.App) (*servingv1.Service, err
573573
if err != nil {
574574
return nil, err
575575
}
576-
// Run the app pod under the app's requested service account, falling back to the
577-
// configured default. Without this the Knative pod uses the namespace's `default`
578-
// SA, which (unlike the flyte SA) has no IRSA role — so the pod gets no cloud
579-
// credentials/region and fails to read its code bundle from object storage.
580576
if sa := spec.GetSecurityContext().GetRunAs().GetK8SServiceAccount(); sa != "" {
581577
podSpec.ServiceAccountName = sa
582578
} else if c.cfg.DefaultServiceAccount != "" {

0 commit comments

Comments
 (0)