Fixed CI and DOC errors

Signed-off-by: Chih Tsung Lu <[email protected]>

Author: ChihTsungLu

pydoclint-errors-baseline.txt

@@ -37,8 +37,6 @@ flytekit/core/base_sql_task.py
     DOC301: Class `SQLTask`: __init__() should not have a docstring; please combine it with the docstring of the class
 --------------------
 flytekit/core/base_task.py
-    DOC601: Class `TaskMetadata`: Class docstring contains fewer class attributes than actual class attributes.  (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)
-    DOC603: Class `TaskMetadata`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [cache: bool, cache_ignore_input_vars: Tuple[str, ...], cache_serialize: bool, cache_version: str, deprecated: str, interruptible: Optional[bool], is_eager: bool, pod_template_name: Optional[str], retries: int, timeout: Optional[Union[datetime.timedelta, int]]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)
     DOC301: Class `PythonTask`: __init__() should not have a docstring; please combine it with the docstring of the class
     DOC001: Function/method `post_execute`: Potential formatting errors in docstring. Error message: Expected a colon in 'rval is returned value from call to execute'. (Note: DOC001 could trigger other unrelated violations under this function/method too. Please fix the docstring formatting first.)
     DOC101: Method `PythonTask.post_execute`: Docstring contains fewer arguments than in function signature.
@@ -172,7 +170,7 @@ flytekit/extras/tensorflow/record.py
 --------------------
 flytekit/image_spec/image_spec.py
     DOC601: Class `ImageSpec`: Class docstring contains fewer class attributes than actual class attributes.  (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)
-    DOC603: Class `ImageSpec`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [apt_packages: Optional[List[str]], base_image: Optional[Union[str, 'ImageSpec']], builder: Optional[str], commands: Optional[List[str]], conda_channels: Optional[List[str]], conda_packages: Optional[List[str]], copy: Optional[List[str]], cuda: Optional[str], cudnn: Optional[str], entrypoint: Optional[List[str]], env: Optional[typing.Dict[str, str]], name: str, packages: Optional[List[str]], pip_extra_args: Optional[str], pip_extra_index_url: Optional[List[str]], pip_index: Optional[str], platform: str, python_exec: Optional[str], python_version: str, registry: Optional[str], registry_config: Optional[str], requirements: Optional[str], source_copy_mode: Optional[CopyFileDetection], source_root: Optional[str], tag_format: Optional[str]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)
+    DOC603: Class `ImageSpec`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [apt_packages: Optional[List[str]], base_image: Optional[Union[str, 'ImageSpec']], builder: Optional[str], commands: Optional[List[str]], conda_channels: Optional[List[str]], conda_packages: Optional[List[str]], copy: Optional[List[str]], cuda: Optional[str], cudnn: Optional[str], entrypoint: Optional[List[str]], env: Optional[typing.Dict[str, str]], name: str, packages: Optional[List[str]], pip_extra_args: Optional[str], pip_extra_index_url: Optional[List[str]], pip_index: Optional[str], pip_secret_mounts: Optional[List[Tuple[str, str]]], platform: str, python_exec: Optional[str], python_version: str, registry: Optional[str], registry_config: Optional[str], requirements: Optional[str], source_copy_mode: Optional[CopyFileDetection], source_root: Optional[str], tag_format: Optional[str]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.)
     DOC109: Method `ImageSpecBuilder.build_image`: The option `--arg-type-hints-in-docstring` is `True` but there are no type hints in the docstring arg list
     DOC110: Method `ImageSpecBuilder.build_image`: The option `--arg-type-hints-in-docstring` is `True` but not all args in the docstring arg list have type hints
     DOC105: Method `ImageSpecBuilder.build_image`: Argument names match, but type hints in these args do not match: image_spec

tests/flytekit/unit/cli/pyflyte/test_package.py

@@ -103,7 +103,7 @@ def test_package_with_fast_registration_and_envvars():
                 "euler=2.71828",
             ],
         )
-        
+
         assert result.exit_code == 0
         assert "Successfully serialized" in result.output
         assert "Successfully packaged" in result.output

tests/flytekit/unit/core/test_array_node_map_task.py

@@ -351,47 +351,6 @@ def my_wf1() -> typing.List[typing.Optional[int]]:
         assert my_wf1() == [1, None, 3, 4]
 
 
-@task
-def my_mappable_task(a: int) -> typing.Optional[str]:
-    return str(a)
-
-
-@task(
-    container_image="original-image",
-    timeout=timedelta(seconds=10),
-    interruptible=False,
-    retries=10,
-    cache=True,
-    cache_version="original-version",
-    requests=Resources(cpu=1)
-)
-def my_mappable_task_1(a: int) -> typing.Optional[str]:
-    return str(a)
-
-
-@pytest.mark.parametrize(
-    "task_func",
-    [my_mappable_task, my_mappable_task_1]
-)
-def test_map_task_override(serialization_settings, task_func):
-    array_node_map_task = map(task_func)
-
-<<<<<<< Updated upstream
-=======
-def test_map_task_override(serialization_settings):
-    @task
-    def my_mappable_task(a: int) -> typing.Optional[str]:
-        return str(a)
-
->>>>>>> Stashed changes
-    @workflow
-    def wf(x: typing.List[int]):
-        map(my_mappable_task)(a=x).with_overrides(container_image="random:image")
-
-    assert wf.nodes[0]._container_image == "random:image"
-
-
-
 def test_serialization_metadata(serialization_settings):
     @task(interruptible=True)
     def t1(a: int) -> int: