Skip to content

Commit 989eb67

Browse files
authored
ci: Update version extraction in CI workflow (#3261)
Signed-off-by: Kevin Su <[email protected]>
1 parent 764b36f commit 989eb67

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.github/workflows/pythonpublish.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
id: bump
2424
run: |
2525
# from 'refs/tags/v1.2.3' get 1.2.3
26-
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||')
26+
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||')
2727
echo "version=$VERSION" >> $GITHUB_OUTPUT
2828
shell: bash
2929
- name: Build and publish
@@ -36,7 +36,7 @@ jobs:
3636
- name: Autobump plugin version
3737
run: |
3838
# from 'refs/tags/v1.2.3' get 1.2.3
39-
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||')
39+
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||')
4040
VERSION=$VERSION make -C plugins update_all_versions
4141
shell: bash
4242
- name: Build all Plugins and publish
@@ -50,7 +50,7 @@ jobs:
5050
id: pypiwait
5151
run: |
5252
# from 'refs/tags/v1.2.3 get 1.2.3' and make sure it's not an empty string
53-
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/||')
53+
VERSION=$(echo $GITHUB_REF | sed 's|refs/tags/v||')
5454
if [ -z "$VERSION" ]
5555
then
5656
echo "No tagged version found, exiting"

tests/flytekit/unit/core/test_generice_idl_type_engine.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2704,7 +2704,7 @@ def test_union_in_dataclass():
27042704
lv = tf.to_literal(ctx, o, pt, lt)
27052705
ot = tf.to_python_value(ctx, lv=lv, expected_python_type=pt)
27062706

2707-
return o == ot
2707+
assert o == ot
27082708
assert o.result.schema.remote_path == ot.result.schema.remote_path
27092709
assert o.result.number == ot.result.number
27102710
assert o.schema.remote_path == ot.schema.remote_path

tests/flytekit/unit/core/test_type_engine.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2713,7 +2713,7 @@ def test_union_in_dataclass():
27132713
lv = tf.to_literal(ctx, o, pt, lt)
27142714
ot = tf.to_python_value(ctx, lv=lv, expected_python_type=pt)
27152715

2716-
return o == ot
2716+
assert o == ot
27172717
assert o.result.schema.remote_path == ot.result.schema.remote_path
27182718
assert o.result.number == ot.result.number
27192719
assert o.schema.remote_path == ot.schema.remote_path

0 commit comments

Comments
 (0)