This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Update and improve csv-import #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkethi002
reviewed
May 23, 2019
hkethi002
left a comment
hkethi002
left a comment
There was a problem hiding this comment.
It may be better to have an explicit message in the job log that the input is of an unsupported file type if they try a non csv file.
| # Read CSV bytes | ||
| filepath = context.get_input_path('subject_csv') | ||
| filename = os.path.basename(filepath) | ||
| with open(filepath, mode='rb') as subject_csv: |
There was a problem hiding this comment.
Do we want to have a check here to make sure the document extension is a csv?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend features to also cover TUM needs in a generic way, and update with current gear best practices.
Breaks
New features
re.seach(r'id|subject'))