Throw error when entry didn't register any services [Closes #10]

Author: fmasa

README.md

@@ -156,3 +156,7 @@ such as decorator.
 
 You can enforce registration in configuration phase
 by setting `registerOnConfiguration` option to true.
+
+When no service is registered for configuration entry, either because no class/interface
+matches the pattern or all matched services were already registered in container, exception
+is thrown. This check can be disabled by setting `errorOnNotMatchedDefinitions` option to false.

src/AutoDI/DI/AutoDIExtension.php

@@ -6,6 +6,7 @@
 
 use Fmasa\AutoDI\ClassList;
 use Fmasa\AutoDI\Exceptions\IncompleteServiceDefinition;
+use Fmasa\AutoDI\Exceptions\NoServiceRegistered;
 use Nette;
 use Nette\DI\CompilerExtension;
 use Nette\Loaders\RobotLoader;
@@ -17,6 +18,7 @@ public function getConfigSchema() : Nette\Schema\Schema
     {
         return Expect::structure([
             'services' => Expect::listOf(Expect::array()),
+            'errorOnNotMatchedDefinitions' => Expect::bool(true),
             'registerOnConfiguration' => Expect::bool(false),
             'directories' => Expect::listOf(Expect::string())->default([$this->getContainerBuilder()->parameters['appDir']]),
             'defaults' => Expect::array(),
@@ -82,6 +84,10 @@ private function registerServices(): void
                 return $service;
             }, $matchingClasses);
 
+            if ($config->errorOnNotMatchedDefinitions && count($services) === 0) {
+                throw NoServiceRegistered::byPattern($field);
+            }
+
             $this->compiler->loadDefinitionsFromConfig($services);
         }
     }

src/AutoDI/Exceptions/NoServiceRegistered.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Fmasa\AutoDI\Exceptions;
+
+use Exception;
+
+final class NoServiceRegistered extends Exception
+{
+    /**
+     * @internal This constructor is not part of public API and may change between versions
+     */
+    public static function byPattern(string $pattern) : self
+    {
+        return new self(
+            "No services were matched by registered using $pattern \n"
+            . 'services with name matching the pattern were either not found or already registered by another extension'
+        );
+    }
+}

tests/DI/AutoDIExtensionTest.php

@@ -5,6 +5,7 @@
 namespace Fmasa\AutoDI\DI;
 
 use Fmasa\AutoDI\Exceptions\IncompleteServiceDefinition;
+use Fmasa\AutoDI\Exceptions\NoServiceRegistered;
 use Nette\Configurator;
 use Nette\DI\Container;
 use Fmasa\AutoDI\Tests;
@@ -132,6 +133,13 @@ public function testServiceWithoutImplementAndClassKeyThrowsException() : void
         $this->getContainer(__DIR__ . '/missingKey.neon');
     }
 
+    public function testExceptionIsThrownIfThereAreNoServicesRegisteredForEntry() : void
+    {
+        $this->expectException(NoServiceRegistered::class);
+
+        $this->getContainer(__DIR__ . '/noRegisteredService.neon');
+    }
+
     private function getContainer(string $configFile, string $appDir = __DIR__ . '/../fixtures/app'): Container
     {
         $configurator = new Configurator();

tests/DI/alreadyRegistered.neon

@@ -3,6 +3,7 @@ services:
     - Fmasa\AutoDI\Tests\Dir01\SimpleService2
 
 autoDI:
+    errorOnNotMatchedDefinitions: false
 
     services:
         - implement: Fmasa\AutoDI\Tests\Dir01\ISimpleServiceFactory

tests/DI/noRegisteredService.neon

@@ -0,0 +1,6 @@
+services:
+    - Fmasa\AutoDI\Tests\Dir01\SimpleService2
+
+autoDI:
+    services:
+        - class: Fmasa\AutoDI\Tests\Dir01\SimpleService2

tests/DI/onConfiguration.neon

@@ -3,6 +3,7 @@ autoDI:
         - class: Fmasa\AutoDI\Tests\Dir01\SimpleService
           tags: [ onCompilation ]
         - class: Fmasa\AutoDI\Tests\Dir02\SimpleService
+    errorOnNotMatchedDefinitions: false
 
 extensions:
     autoDI: Fmasa\AutoDI\DI\AutoDIExtension