Fix inconsistencies related to nesting recyclerview into scrollview

Author: fmasa

app/src/main/java/cz/muni/fi/rpg/ui/character/InventoryFragment.kt

@@ -8,13 +8,13 @@ import androidx.fragment.app.Fragment
 import cz.muni.fi.rpg.R
 import kotlinx.android.synthetic.main.fragment_inventory.view.*
 import androidx.lifecycle.observe
-import androidx.recyclerview.widget.LinearLayoutManager
 import cz.muni.fi.rpg.model.domain.character.CharacterId
 import cz.muni.fi.rpg.model.domain.inventory.InventoryItem
 import cz.muni.fi.rpg.ui.character.adapter.InventoryAdapter
 import cz.muni.fi.rpg.ui.character.inventory.ChangeArmorDialog
 import cz.muni.fi.rpg.ui.character.inventory.InventoryItemDialog
 import cz.muni.fi.rpg.ui.character.inventory.TransactionDialog
+import cz.muni.fi.rpg.ui.common.NonScrollableLayoutManager
 import cz.muni.fi.rpg.ui.common.parcelableArgument
 import cz.muni.fi.rpg.viewModels.InventoryViewModel
 import kotlinx.android.synthetic.main.fragment_inventory.*
@@ -67,7 +67,7 @@ class InventoryFragment : Fragment(R.layout.fragment_inventory),
             onClickListener = this::showDialog,
             onRemoveListener = { launch { viewModel.removeInventoryItem(it) } }
         )
-        inventoryRecycler.layoutManager = LinearLayoutManager(context)
+        inventoryRecycler.layoutManager = NonScrollableLayoutManager(requireContext())
         inventoryRecycler.adapter = adapter
 
         viewModel.inventory.observe(viewLifecycleOwner) { items ->

app/src/main/java/cz/muni/fi/rpg/ui/character/skills/CharacterSkillsFragment.kt

@@ -6,14 +6,14 @@ import androidx.core.os.bundleOf
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.commit
 import androidx.lifecycle.observe
-import androidx.recyclerview.widget.LinearLayoutManager
 import cz.muni.fi.rpg.R
 import cz.muni.fi.rpg.model.domain.character.CharacterId
 import cz.muni.fi.rpg.model.domain.skills.Skill
 import cz.muni.fi.rpg.model.right
 import cz.muni.fi.rpg.ui.character.skills.adapter.SkillAdapter
 import cz.muni.fi.rpg.ui.character.skills.talents.TalentsFragment
 import cz.muni.fi.rpg.ui.common.CombinedLiveData
+import cz.muni.fi.rpg.ui.common.NonScrollableLayoutManager
 import cz.muni.fi.rpg.ui.common.parcelableArgument
 import cz.muni.fi.rpg.viewModels.CharacterViewModel
 import cz.muni.fi.rpg.viewModels.SkillsViewModel
@@ -42,7 +42,7 @@ class CharacterSkillsFragment : Fragment(R.layout.fragment_character_skills),
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        skillList.layoutManager = LinearLayoutManager(context)
+        skillList.layoutManager = NonScrollableLayoutManager(requireContext())
         val adapter = SkillAdapter(
             layoutInflater,
             { openSkillDialog(it) },

app/src/main/java/cz/muni/fi/rpg/ui/character/skills/talents/TalentsFragment.kt

@@ -5,10 +5,10 @@ import android.view.View
 import androidx.core.os.bundleOf
 import androidx.fragment.app.Fragment
 import androidx.lifecycle.observe
-import androidx.recyclerview.widget.LinearLayoutManager
 import cz.muni.fi.rpg.R
 import cz.muni.fi.rpg.model.domain.character.CharacterId
 import cz.muni.fi.rpg.model.domain.talents.Talent
+import cz.muni.fi.rpg.ui.common.NonScrollableLayoutManager
 import cz.muni.fi.rpg.ui.common.parcelableArgument
 import cz.muni.fi.rpg.viewModels.TalentsViewModel
 import kotlinx.android.synthetic.main.fragment_talents.*
@@ -36,7 +36,7 @@ class TalentsFragment : Fragment(R.layout.fragment_talents),
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        talentList.layoutManager = LinearLayoutManager(context)
+        talentList.layoutManager = NonScrollableLayoutManager(requireContext())
         val adapter = TalentAdapter(
             layoutInflater,
             { openTalentDialog(it) },

app/src/main/java/cz/muni/fi/rpg/ui/common/NonScrollableLayoutManager.kt

@@ -0,0 +1,8 @@
+package cz.muni.fi.rpg.ui.common
+
+import android.content.Context
+import androidx.recyclerview.widget.LinearLayoutManager
+
+class NonScrollableLayoutManager(context: Context) : LinearLayoutManager(context) {
+    override fun canScrollVertically(): Boolean = false
+}

app/src/main/res/layout/fragment_character_skills.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
+<androidx.core.widget.NestedScrollView xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
@@ -68,4 +68,4 @@
             android:layout_width="match_parent"
             android:layout_height="wrap_content"/>
     </LinearLayout>
-</ScrollView>
+</androidx.core.widget.NestedScrollView>

app/src/main/res/layout/fragment_inventory.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
+<androidx.core.widget.NestedScrollView xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
@@ -373,5 +373,5 @@
             </LinearLayout>
         </androidx.cardview.widget.CardView>
     </LinearLayout>
-</ScrollView>
+</androidx.core.widget.NestedScrollView>