Skip to content

Commit 3bf58b4

Browse files
committed
Add extra bottom padding to screens with FAB
1 parent 4833023 commit 3bf58b4

File tree

8 files changed

+20
-11
lines changed

8 files changed

+20
-11
lines changed

app/compendium/src/main/java/cz/frantisekmasa/wfrp_master/compendium/ui/CompendiumScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import cz.frantisekmasa.wfrp_master.core.ui.buttons.BackButton
2121
import cz.frantisekmasa.wfrp_master.core.ui.dialogs.DialogState
2222
import cz.frantisekmasa.wfrp_master.core.ui.primitives.ContextMenu
2323
import cz.frantisekmasa.wfrp_master.core.ui.primitives.FullScreenProgress
24+
import cz.frantisekmasa.wfrp_master.core.ui.primitives.Spacing
2425
import cz.frantisekmasa.wfrp_master.core.ui.primitives.WithContextMenu
2526
import cz.frantisekmasa.wfrp_master.core.ui.scaffolding.Subtitle
2627
import cz.frantisekmasa.wfrp_master.core.ui.scaffolding.TopBarAction
@@ -105,7 +106,7 @@ fun <T : CompendiumItem> CompendiumTab(
105106
items == null -> FullScreenProgress()
106107
items.isEmpty() -> emptyUI()
107108
else -> {
108-
LazyColumn {
109+
LazyColumn(contentPadding = PaddingValues(bottom = Spacing.bottomPaddingUnderFab)) {
109110
items(items) { item ->
110111
WithContextMenu(
111112
items = listOf(

app/core/src/main/java/cz/frantisekmasa/wfrp_master/core/ui/primitives/Spacing.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package cz.frantisekmasa.wfrp_master.core.ui.primitives
22

3+
import androidx.compose.foundation.layout.PaddingValues
34
import androidx.compose.ui.unit.dp
45

56
object Spacing {
@@ -9,4 +10,12 @@ object Spacing {
910
val small = 8.dp
1011
val tiny = 4.dp
1112
val bodyPadding = extraLarge
13+
14+
val bottomPaddingUnderFab = 80.dp
15+
val bodyPaddingWithFab = PaddingValues(
16+
start = bodyPadding,
17+
top = bodyPadding,
18+
end = bodyPadding,
19+
bottom = bottomPaddingUnderFab,
20+
)
1221
}

app/src/main/java/cz/muni/fi/rpg/ui/character/CharacterSpellsScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ private fun MainContainer(viewModel: SpellsViewModel) {
7373

7474
var editedSpellId: UUID? by rememberSaveable { mutableStateOf(null) }
7575

76-
LazyColumn {
76+
LazyColumn(contentPadding = PaddingValues(bottom = Spacing.bottomPaddingUnderFab)) {
7777
items(spells) { spell ->
7878
SpellItem(
7979
spell,

app/src/main/java/cz/muni/fi/rpg/ui/character/CharacterStatsScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ internal fun CharacterCharacteristicsScreen(
101101
Column(
102102
Modifier
103103
.verticalScroll(rememberScrollState())
104-
.padding(top = Spacing.small),
104+
.padding(top = Spacing.small, bottom = Spacing.bottomPaddingUnderFab),
105105
) {
106106
PointsSection(character.getPoints()) { points -> viewModel.updatePoints { points } }
107107
CharacteristicsSection(character.getCharacteristics())

app/src/main/java/cz/muni/fi/rpg/ui/gameMaster/PartySummaryScreen.kt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,16 @@ import cz.frantisekmasa.wfrp_master.compendium.ui.CompendiumViewModel
1919
import cz.muni.fi.rpg.R
2020
import cz.frantisekmasa.wfrp_master.core.domain.character.Character
2121
import cz.frantisekmasa.wfrp_master.core.domain.identifiers.CharacterId
22-
import cz.frantisekmasa.wfrp_master.core.ui.primitives.ContextMenu
23-
import cz.frantisekmasa.wfrp_master.core.ui.primitives.EmptyUI
2422
import cz.frantisekmasa.wfrp_master.core.viewModel.viewModel
2523
import cz.frantisekmasa.wfrp_master.core.domain.party.Invitation
2624
import cz.frantisekmasa.wfrp_master.core.domain.party.PartyId
2725
import cz.frantisekmasa.wfrp_master.core.ui.buttons.PrimaryButton
28-
import cz.frantisekmasa.wfrp_master.core.ui.primitives.CardContainer
29-
import cz.frantisekmasa.wfrp_master.core.ui.primitives.CardItem
26+
import cz.frantisekmasa.wfrp_master.core.ui.primitives.*
3027
import cz.muni.fi.rpg.ui.common.composables.*
3128
import cz.muni.fi.rpg.ui.gameMaster.adapter.Player
3229
import cz.frantisekmasa.wfrp_master.navigation.Route
3330
import cz.frantisekmasa.wfrp_master.navigation.Routing
31+
import cz.muni.fi.rpg.ui.common.composables.CardTitle
3432
import cz.muni.fi.rpg.ui.gameMaster.rolls.SkillTestDialog
3533
import cz.muni.fi.rpg.viewModels.GameMasterViewModel
3634
import kotlinx.coroutines.Dispatchers
@@ -69,7 +67,8 @@ internal fun PartySummaryScreen(
6967
Column(
7068
Modifier
7169
.background(MaterialTheme.colors.background)
72-
.verticalScroll(rememberScrollState()),
70+
.verticalScroll(rememberScrollState())
71+
.padding(bottom = Spacing.bottomPaddingUnderFab)
7372
) {
7473
val party = viewModel.party.observeAsState().value
7574
?: return@Column

app/src/main/java/cz/muni/fi/rpg/ui/gameMaster/encounters/EncounterDetailScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ private fun MainContainer(
172172
.fillMaxSize()
173173
.background(MaterialTheme.colors.background)
174174
.verticalScroll(rememberScrollState())
175-
.padding(top = 6.dp),
175+
.padding(top = 6.dp, bottom = Spacing.bottomPaddingUnderFab),
176176
) {
177177
DescriptionCard(viewModel)
178178
CombatantsCard(

app/src/main/java/cz/muni/fi/rpg/ui/gameMaster/encounters/EncountersScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ private fun EncounterList(
114114
.background(MaterialTheme.colors.background)
115115
.fillMaxSize()
116116
.verticalScroll(rememberScrollState())
117-
.padding(Spacing.bodyPadding),
117+
.padding(Spacing.bodyPaddingWithFab),
118118
horizontalAlignment = Alignment.CenterHorizontally,
119119
) {
120120
DraggableListFor(

app/src/main/java/cz/muni/fi/rpg/ui/partyList/PartyListScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ fun PartyList(
214214
) {
215215
LazyColumn(
216216
Modifier.fillMaxHeight(),
217-
contentPadding = PaddingValues(top = 12.dp)
217+
contentPadding = PaddingValues(top = 12.dp, bottom = Spacing.bottomPaddingUnderFab)
218218
) {
219219
items(parties) { party ->
220220
val isGameMaster =

0 commit comments

Comments
 (0)