Fix TransactionDialog crash on configuration change

Author: fmasa

app/src/main/java/cz/muni/fi/rpg/ui/character/InventoryFragment.kt

@@ -54,7 +54,7 @@ class InventoryFragment : Fragment(R.layout.fragment_inventory),
         viewModel.money.observe(viewLifecycleOwner, characterMoney::setValue)
 
         characterMoney.setOnClickListener {
-            TransactionDialog(viewModel).show(parentFragmentManager, "TransactionDialog")
+            TransactionDialog.newInstance(characterId).show(parentFragmentManager, null)
         }
 
         view.addNewInventoryItemButton.setOnClickListener { showDialog(null) }

app/src/main/java/cz/muni/fi/rpg/ui/character/inventory/TransactionDialog.kt

@@ -5,23 +5,35 @@ import android.os.Bundle
 import android.view.View
 import android.widget.ArrayAdapter
 import androidx.appcompat.app.AlertDialog
+import androidx.core.os.bundleOf
 import androidx.fragment.app.DialogFragment
 import cz.muni.fi.rpg.R
+import cz.muni.fi.rpg.model.domain.character.CharacterId
 import cz.muni.fi.rpg.model.domain.character.NotEnoughMoney
 import cz.muni.fi.rpg.model.domain.common.Money
 import cz.muni.fi.rpg.ui.common.adapters.SpinnerAdapterWithWidthMatchingSelectedItem
+import cz.muni.fi.rpg.ui.common.parcelableArgument
 import cz.muni.fi.rpg.ui.views.TextInput
 import cz.muni.fi.rpg.viewModels.InventoryViewModel
 import kotlinx.android.synthetic.main.dialog_transaction.view.*
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
+import org.koin.android.viewmodel.ext.android.viewModel
+import org.koin.core.parameter.parametersOf
 
-class TransactionDialog(
-    private val viewModel: InventoryViewModel
-) : DialogFragment(),
-    CoroutineScope by CoroutineScope(Dispatchers.Default) {
+class TransactionDialog : DialogFragment(), CoroutineScope by CoroutineScope(Dispatchers.Default) {
+    companion object {
+        const val ARGUMENT_CHARACTER_ID = "characterId"
+
+        fun newInstance(characterId: CharacterId) = TransactionDialog().apply {
+            arguments = bundleOf(ARGUMENT_CHARACTER_ID to characterId)
+        }
+    }
+
+    private val characterId: CharacterId by parcelableArgument(ARGUMENT_CHARACTER_ID)
+    private val viewModel: InventoryViewModel by viewModel { parametersOf(characterId) }
 
     override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
         val activity = requireActivity()