Skip to content

Commit aa8a116

Browse files
authored
Merge pull request #5 from fmichellonet/bugfix/routeguardian_dependency
Fix bad dependency injection
2 parents 03f5f24 + 40699be commit aa8a116

File tree

3 files changed

+33
-1
lines changed

3 files changed

+33
-1
lines changed

src/AzureFunctions.Extensions.OpenIDConnect.Tests/AzureFunctions.Extensions.OpenIDConnect.Tests.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
<ItemGroup>
88
<PackageReference Include="FluentAssertions" Version="5.10.3" />
9+
<PackageReference Include="Microsoft.Azure.WebJobs" Version="3.0.25" />
910
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
1011
<PackageReference Include="NUnit" Version="3.13.1" />
1112
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0" />
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
using System;
2+
using AzureFunctions.Extensions.OpenIDConnect.Configuration;
3+
using FluentAssertions;
4+
using Microsoft.Azure.WebJobs.Host;
5+
using Microsoft.Extensions.DependencyInjection;
6+
using NUnit.Framework;
7+
8+
namespace AzureFunctions.Extensions.OpenIDConnect.Tests
9+
{
10+
[TestFixture]
11+
public class DependencyInjectionShould
12+
{
13+
[Test]
14+
public void Be_Resolvable()
15+
{
16+
var collection = new ServiceCollection();
17+
collection.AddOpenIDConnect(builder =>
18+
{
19+
builder.SetIssuerBaseUrlConfiguration("https://issuer.com/");
20+
builder.SetTokenValidation("issuer", "audience");
21+
builder.SetTypeCrawler(() => new Type[] { });
22+
});
23+
24+
var provider = collection.BuildServiceProvider();
25+
26+
provider.GetService<IAuthenticationService>().Should().NotBe(null);
27+
provider.GetService<IRouteGuardian>().Should().NotBe(null);
28+
provider.GetService<IFunctionFilter>().Should().NotBe(null);
29+
}
30+
}
31+
}

src/AzureFunctions.Extensions.OpenIDConnect/Configuration/ServicesConfigurationExtensions.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public static void AddOpenIDConnect(this IServiceCollection services, Action<Con
4444
services.AddSingleton<IJwtSecurityTokenHandlerWrapper, JwtSecurityTokenHandlerWrapper>();
4545
services.AddSingleton<IOpenIdConnectConfigurationManager, OpenIdConnectConfigurationManager>();
4646
services.AddSingleton<IAuthenticationService, AuthenticationService>();
47-
services.AddSingleton<RouteGuardian>();
47+
services.AddSingleton<IRouteGuardian, RouteGuardian>();
4848
services.AddSingleton<IFunctionFilter, AuthorizeFilter>();
4949
}
5050
}

0 commit comments

Comments
 (0)