test: add tests

Author: SvitlanaKovalova1

src/test/java/org/folio/indexing/IndexingInstanceCallNumberConsortiumIT.java

@@ -2,6 +2,9 @@
 
 import static java.util.Collections.emptyList;
 import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat;
+import static org.awaitility.Awaitility.await;
+import static org.awaitility.Durations.ONE_MINUTE;
+import static org.folio.search.model.types.ResourceType.INSTANCE;
 import static org.folio.search.model.types.ResourceType.INSTANCE_CALL_NUMBER;
 import static org.folio.search.service.reindex.ReindexConstants.CALL_NUMBER_TABLE;
 import static org.folio.search.service.reindex.ReindexConstants.HOLDING_TABLE;
@@ -13,20 +16,28 @@
 import static org.folio.support.base.ApiEndpoints.instanceSearchPath;
 import static org.folio.support.utils.TestUtils.randomId;
 
+import java.time.Duration;
 import java.util.List;
 import java.util.Map;
+import java.util.UUID;
+import java.util.stream.Stream;
 import org.folio.search.domain.dto.Holding;
 import org.folio.search.domain.dto.Instance;
 import org.folio.search.domain.dto.Item;
 import org.folio.search.domain.dto.ItemEffectiveCallNumberComponents;
 import org.folio.search.domain.dto.TenantConfiguredFeature;
+import org.folio.search.model.event.InstanceSharingCompleteEvent;
+import org.folio.search.model.types.ResourceType;
 import org.folio.spring.testing.extension.DatabaseCleanup;
 import org.folio.spring.testing.type.IntegrationTest;
 import org.folio.support.base.BaseIntegrationTest;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 import org.springframework.test.context.TestPropertySource;
 
 @IntegrationTest
@@ -46,11 +57,6 @@ static void prepare() {
     setUpTenant(MEMBER_TENANT_ID);
 
     enableFeature(CENTRAL_TENANT_ID, TenantConfiguredFeature.BROWSE_CALL_NUMBERS);
-
-    setUpTestData();
-
-    // fetch call number documents for the instance and check that tenant field contains member tenant id
-    awaitAssertion(() -> assertInstanceCallNumberTenantId(MEMBER_TENANT_ID, false));
   }
 
   @AfterAll
@@ -62,10 +68,16 @@ static void cleanUp() {
   @AfterEach
   void tearDown() {
     deleteAllDocuments(INSTANCE_CALL_NUMBER, CENTRAL_TENANT_ID);
+    awaitAssertion(() -> assertDocumentsEmpty(INSTANCE_CALL_NUMBER));
+    deleteAllDocuments(INSTANCE, CENTRAL_TENANT_ID);
+    awaitAssertion(() -> assertDocumentsEmpty(INSTANCE));
   }
 
   @Test
   void shouldUpdateInstanceCallNumber_onInstanceSharing() {
+    // given
+    createInstanceInMemberTenant(INSTANCE_ID, INSTANCE_TITLE, LOCATION_ID, CALL_NUMBER);
+    awaitAssertion(() -> assertInstanceCallNumberTenantId(MEMBER_TENANT_ID, false));
     // when - create instance in central tenant with the same instance id/title
     var centralInstance = new Instance().id(INSTANCE_ID).title(INSTANCE_TITLE).source("FOLIO");
     inventoryApi.createInstance(CENTRAL_TENANT_ID, centralInstance);
@@ -77,12 +89,59 @@ void shouldUpdateInstanceCallNumber_onInstanceSharing() {
     // then - fetch call number documents for the instance and check if tenant field changed to member tenant id
     awaitAssertion(() -> assertInstanceCallNumberTenantId(MEMBER_TENANT_ID, false));
 
-    inventoryApi.shareInstance(CENTRAL_TENANT_ID, INSTANCE_ID);
+    inventoryApi.shareInstance(CENTRAL_TENANT_ID, INSTANCE_ID, InstanceSharingCompleteEvent.Status.COMPLETE, "",
+      MEMBER_TENANT_ID, CENTRAL_TENANT_ID);
 
     // then - fetch call number documents and check if tenant field changed to central and shared is true
     awaitAssertion(() -> assertInstanceCallNumberTenantId(CENTRAL_TENANT_ID, true));
   }
 
+  @ParameterizedTest(name = "{index} => status={0}, errorMessage={1}, targetTenant={2}")
+  @MethodSource("negativeSharingScenarios")
+  void shouldNotUpdateInstanceCallNumber_onInvalidSharingEvent(
+    InstanceSharingCompleteEvent.Status status,
+    String errorMessage,
+    String targetTenantId,
+    String instanceId, String title, String locationId, String callNumber
+  ) {
+    // given
+    createInstanceInMemberTenant(instanceId, title, locationId, callNumber);
+
+    awaitAssertion(() -> assertInstanceCallNumberTenantId(MEMBER_TENANT_ID, false));
+
+    var centralInstance = new Instance().id(instanceId).title(title).source("FOLIO");
+    inventoryApi.createInstance(CENTRAL_TENANT_ID, centralInstance);
+
+    var memberInstance = new Instance().id(instanceId).title(title).source("CONSORTIUM-FOLIO");
+    inventoryApi.updateInstance(MEMBER_TENANT_ID, memberInstance);
+
+    awaitAssertion(() -> assertInstanceCallNumberTenantId(MEMBER_TENANT_ID, false));
+
+    // when
+    inventoryApi.shareInstance(MEMBER_TENANT_ID, instanceId, status, errorMessage, MEMBER_TENANT_ID, targetTenantId);
+
+    // then check that call number document is not updated with central tenant id and shared is false
+    await()
+      .pollDelay(Duration.ofSeconds(30))
+      .atMost(ONE_MINUTE)
+      .untilAsserted(() ->
+        assertInstanceCallNumberTenantId(MEMBER_TENANT_ID, false)
+      );
+  }
+
+  private static Stream<Arguments> negativeSharingScenarios() {
+    return Stream.of(
+      // ERROR status
+      Arguments.of(InstanceSharingCompleteEvent.Status.ERROR, "", CENTRAL_TENANT_ID,
+        UUID.randomUUID().toString(), "title1", UUID.randomUUID().toString(), "call number1"),
+      // error message is present
+      Arguments.of(InstanceSharingCompleteEvent.Status.COMPLETE, "error message", CENTRAL_TENANT_ID,
+        UUID.randomUUID().toString(), "title2", UUID.randomUUID().toString(), "call number2"),
+      // target tenant is not central tenant
+      Arguments.of(InstanceSharingCompleteEvent.Status.COMPLETE, "", MEMBER_TENANT_ID,
+        UUID.randomUUID().toString(), "title3", UUID.randomUUID().toString(), "call number3"));
+  }
+
   private static void assertInstanceCallNumberTenantId(String expectedTenantId, boolean shared) {
     var hits = fetchAllDocuments(INSTANCE_CALL_NUMBER, CENTRAL_TENANT_ID);
     assertThat(hits).hasSize(1);
@@ -97,12 +156,18 @@ private static void assertInstanceCallNumberTenantId(String expectedTenantId, bo
         .containsEntry("shared", shared));
   }
 
-  private static void setUpTestData() {
+  private static void assertDocumentsEmpty(ResourceType resourceType) {
+    var hits = fetchAllDocuments(resourceType, CENTRAL_TENANT_ID);
+    assertThat(hits).hasSize(0);
+  }
+
+  private static void createInstanceInMemberTenant(String instanceId, String instanceTitle,
+                                                   String locationId, String callNumber) {
     var holdings = new Holding().id(randomId());
     var item = new Item().id(randomId()).holdingsRecordId(holdings.getId())
-      .effectiveLocationId(LOCATION_ID)
-      .effectiveCallNumberComponents(new ItemEffectiveCallNumberComponents().callNumber(CALL_NUMBER));
-    var instance = new Instance().id(INSTANCE_ID).title(INSTANCE_TITLE).source("FOLIO")
+      .effectiveLocationId(locationId)
+      .effectiveCallNumberComponents(new ItemEffectiveCallNumberComponents().callNumber(callNumber));
+    var instance = new Instance().id(instanceId).title(instanceTitle).source("FOLIO")
       .holdings(List.of(holdings))
       .items(List.of(item));
     saveRecords(MEMBER_TENANT_ID, instanceSearchPath(), List.of(instance), 1, emptyList(),

src/test/java/org/folio/support/api/InventoryApi.java

@@ -8,8 +8,6 @@
 import static org.folio.search.domain.dto.ResourceEventType.UPDATE;
 import static org.folio.search.utils.SearchUtils.INSTANCE_HOLDING_FIELD_NAME;
 import static org.folio.search.utils.SearchUtils.INSTANCE_ITEM_FIELD_NAME;
-import static org.folio.support.TestConstants.CENTRAL_TENANT_ID;
-import static org.folio.support.TestConstants.MEMBER_TENANT_ID;
 import static org.folio.support.TestConstants.consortiumInstanceSharingCompleteTopic;
 import static org.folio.support.TestConstants.inventoryBoundWithTopic;
 import static org.folio.support.TestConstants.inventoryHoldingTopic;
@@ -92,9 +90,9 @@ public void deleteInstance(String tenant, String id) {
       .whenComplete(onCompleteConsumer());
   }
 
-  public void shareInstance(String tenantId, String instanceId) {
-    var instanceEvent = instanceSharingCompleteEvent(instanceId, MEMBER_TENANT_ID, CENTRAL_TENANT_ID,
-      InstanceSharingCompleteEvent.Status.COMPLETE, "");
+  public void shareInstance(String tenantId, String instanceId, InstanceSharingCompleteEvent.Status status,
+                            String errorMessage, String sourceTenantId, String targetTenantId) {
+    var instanceEvent = instanceSharingCompleteEvent(instanceId, sourceTenantId, targetTenantId, status, errorMessage);
 
     kafkaTemplate.send(consortiumInstanceSharingCompleteTopic(tenantId), instanceId,
         objectMapper.writeValueAsString(instanceEvent))