Neovim with Lazy unusable after updating to 0.9.4

[pbizimis]

Hey,
I have a weird problem after updating my Neovim to 0.9.4. I always get this error (for multiple plugins but not all).

Error detected while processing /home/philip/.config/nvim/init.lua:
E5113: Error while calling lua chunk: /home/philip/.config/nvim/lua/plugins/telescope.lua:6: module 'telescope.bui
ltin' not found:
        no field package.preload['telescope.builtin']
cache_loader: module telescope.builtin not found
cache_loader_lib: module telescope.builtin not found
        no file './telescope/builtin.lua'
        no file '/usr/share/luajit-2.1/telescope/builtin.lua'
        no file '/usr/local/share/lua/5.1/telescope/builtin.lua'
        no file '/usr/local/share/lua/5.1/telescope/builtin/init.lua'
        no file '/usr/share/lua/5.1/telescope/builtin.lua'
        no file '/usr/share/lua/5.1/telescope/builtin/init.lua'
        no file './telescope/builtin.so'
        no file '/usr/local/lib/lua/5.1/telescope/builtin.so'
        no file '/usr/lib/lua/5.1/telescope/builtin.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file './telescope.so'
        no file '/usr/local/lib/lua/5.1/telescope.so'
        no file '/usr/lib/lua/5.1/telescope.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        /home/philip/.config/nvim/lua/plugins/telescope.lua:6: in function 'values'
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/plugin.lua:594: in function 'values'
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/plugin.lua:50: in function 'parse'
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/plugin.lua:520: in function 'load'
        ...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:36: in function 'setup'
        ...hilip/.local/share/nvim/lazy/lazy.nvim/lua/lazy/init.lua:100: in function 'setup'
        /home/philip/.config/nvim/init.lua:17: in main chunk
Press ENTER or type command to continue

I never had any problem before, so the config was sound. I tried to uninstall Lazy and Neovim, also cleaned all caches and deleted the lazy-lock file but the error seems to persist. I can open Neovim with nvim --clean and there are no issues. I am running latest Arch Linux and have updated the system.

Any ideas? Thank you so much!

[folke]

What's the contents of lua/plugins/telescope.lua?

[pbizimis]

Thanks for helping me :)

return {
    'nvim-telescope/telescope.nvim', tag = '0.1.4',
    dependencies = { 'nvim-lua/plenary.nvim' },
    lazy = true,
    keys = function()
        local builtin = require('telescope.builtin')
        return {
            {"<leader>pf", builtin.find_files},
            {"<leader>pg", builtin.git_files},
            {"<leader>ps", function()
                builtin.grep_string({ search = vim.fn.input("Grep > ") })
            end}

        }
    end,
}

[folke]

The problem is actually with your spec, but I fixed it anyway.

First lazy loads all the specs, and after that installs missing plugins.

Lazy used to resolve lazy handlers like keys before instaling missing plugins.

Normally that's ok, but you are actually loading the telescope plugin from within a lazy handler.

That lazy=true will never have any effect, since the lazy keys handler will autoload telescope due to that require of builtin at the top of the function.

Eitherway, I just pushed a change so that handlers are now resolved after installing missing plugins.

You won't get any errors now, but you should still change that keys function so that it doesnt load telescope

[pbizimis]

Thank you a lot!
How should I change the keys function so that I can still access the functions (find_files, git_files ...) without the require? I could not find anything in the docs.

I also remember that telescope was actually only loaded when I used the key combination and was not autoloaded on startup. Maybe I am misunderstanding?

[folke]

put the require in the keymap function

[pbizimis]

So, like this? Is there no better way? Thanks!

return {
    'nvim-telescope/telescope.nvim', tag = '0.1.4',
    dependencies = { 'nvim-lua/plenary.nvim' },
    lazy = true,
    keys =  {
            {"<leader>pf", require('telescope.builtin').find_files},
            {"<leader>pg", require('telescope.builtin').git_files},
            {"<leader>ps", function()
                require('telescope.builtin').grep_string({ search = vim.fn.input("Grep > ") })
            end},
        }
    end,
}

[folke]

You're still requiring the files in the module itself. Put them in a closure (function). Just like you did for grep_string.

That way, the require will only happen when you execute the actual keymap

[pbizimis]

Perfect, thank you so much!