Reloading plugins after changing colorscheme

[idr4n]

Hi there,

Basically I have a command that I want to use to automatically change colorscheme (being triggered by a shell script) on system's appearance change (in macOS).

This is the command that I have so far and I'm using the reload function as discussed in #445 made it actually possible to reload lualine's colors as well:

vim.api.nvim_create_user_command("ChangeBackground", function()
    local dark = vim.fn.system("defaults read -g AppleInterfaceStyle")
    local isDark = dark:match("^Dark") ~= nil

    local lualine = require("lazy.core.config").plugins["lualine.nvim"]
    local tokyo = require("lazy.core.config").plugins["tokyonight.nvim"]
    local github = require("lazy.core.config").plugins["github-nvim-theme"]
    local gitsigns = require("lazy.core.config").plugins["gitsigns.nvim"]
    local tree = require("lazy.core.config").plugins["nvim-treesitter"]

    if isDark then
        vim.cmd.colorscheme("tokyonight-moon")
        require("lazy.core.loader").reload(lualine)
        require("lazy.core.loader").reload(tokyo)
        require("lazy.core.loader").reload(gitsigns)
        require("lazy.core.loader").reload(tree)
    else
        vim.cmd.colorscheme("github_light")
        require("lazy.core.loader").reload(lualine)
        require("lazy.core.loader").reload(github)
        require("lazy.core.loader").reload(gitsigns)
        require("lazy.core.loader").reload(tree)
    end
end, {})

The issue is that there are some colors that don't change when changing the colorscheme, such as some syntax highlighting which I guess depends on treesitter, but then reloading treesitter is giving me an error: lazy.nvim Failed to deactivate plugin nvim-treesitter ...-32ef36c/share/nvim/runtime/lua/vim/treesitter/query.lua:492: Overriding nth?

Telescope's background color is also not updated and reloading it in the same way as above didn't work.

I would appreciate to be pointed in the right direction on how to accomplish that everything gets reloaded correctly (colors, I mean) when changing the colorscheme.

Thanks in advance!

[folke]

As I pointed out on the issue:
@idr4n you should not use reload for this purpose, that makes no sense.
For lualine, you can just change the theme I believe.

Other plugins typically have an autocmd that triggers on colorscheme changes. If not that should be fixed in those plugins.

Also, for proper reloading, complex plugins would eventually have to implement a deactivate function. Reloading treesitter sounds like a really bad idea for now.

And why do you even reload tokyonight?

Your code makes no sense at all.

reload is NOT the way to go here

[idr4n]

Thanks for replying to this. I was reloading plugins as I have some highlight groups defined in the tokyonight config, that's why, same for gitsigns. But you are right, I was just trying things to see whether it works or not. Unfortunately plugins such as lualine don't have an autocmd that triggers changes on colorsheme or an option to change the theme without restarting Neovim.

But thanks for letting me know that reload in not the way to go in this case. Appreciate it!