Some name checks

Author: simoncozens

fontspector-checkapi/src/font.rs

@@ -4,9 +4,7 @@ use crate::{
     CheckError, FileType, Testable,
 };
 use read_fonts::{
-    tables::cmap::Cmap,
-    tables::gdef::Gdef,
-    tables::{os2::SelectionFlags, post::DEFAULT_GLYPH_NAMES},
+    tables::{cmap::Cmap, gdef::Gdef, os2::SelectionFlags, post::DEFAULT_GLYPH_NAMES},
     types::Version16Dot16,
     TableProvider,
 };
@@ -127,8 +125,10 @@ impl TestFont<'_> {
         Ok(os2.fs_selection())
     }
 
-    pub fn get_name_entry_strings(&self, name_id: StringId) -> LocalizedStrings {
-        self.font().localized_strings(name_id)
+    pub fn get_name_entry_strings(&self, name_id: StringId) -> impl Iterator<Item = String> + '_ {
+        self.font()
+            .localized_strings(name_id)
+            .map(|s| s.to_string())
     }
 
     pub fn glyph_name_for_id(&self, gid: GlyphId, synthesize: bool) -> Option<String> {

profile-universal/src/checks/bold_italic_unique.rs

@@ -23,7 +23,6 @@ fn bold_italic_unique(c: &TestableCollection, _context: &Context) -> CheckFnResu
     let mut flags: HashSet<(bool, bool)> = HashSet::new();
     let ribbi = fonts.iter().filter(|f| f.is_ribbi());
     for font in ribbi {
-        let _names_list = font.get_name_entry_strings(StringId::FAMILY_NAME);
         let fsselection = font.get_os2_fsselection()?;
         let val = (
             fsselection.intersects(SelectionFlags::BOLD),

profile-universal/src/checks/name.rs

@@ -1,5 +1,7 @@
+use font_types::NameId;
 use fontspector_checkapi::{prelude::*, testfont, FileTypeConvert};
 use read_fonts::TableProvider;
+use skrifa::MetadataProvider;
 
 #[check(
     id = "opentype/name/empty_records",
@@ -31,3 +33,70 @@ fn name_empty_records(t: &Testable, _context: &Context) -> CheckFnResult {
     }
     return_result(problems)
 }
+
+#[check(
+    id = "opentype/name/no_copyright_on_description",
+    rationale = "
+        The name table in a font file contains strings about the font;
+        there are entries for a copyright field and a description. If the
+        copyright entry is being used correctly, then there should not
+        be any copyright information in the description entry.
+    ",
+    proposal = "https://github.com/fonttools/fontbakery/issues/4829",
+    title = "Description strings in the name table must not contain copyright info"
+)]
+fn check_name_no_copyright_on_description(t: &Testable, _context: &Context) -> CheckFnResult {
+    let f = testfont!(t);
+    let mut problems: Vec<Status> = vec![];
+    for record in f.get_name_entry_strings(NameId::DESCRIPTION) {
+        if record.contains("opyright") {
+            problems.push(Status::fail(
+                "copyright-on-description",
+                &format!(
+                    "Some namerecords with  ID={} (NameID.DESCRIPTION) containing copyright info
+should be removed (perhaps these were added by a longstanding FontLab Studio
+5.x bug that copied copyright notices to them.)",
+                    NameId::DESCRIPTION.to_u16()
+                ),
+            ))
+        }
+    }
+    return_result(problems)
+}
+
+#[check(
+    id = "opentype/name/match_familyname_fullfont",
+    rationale = r#"
+        The FULL_FONT_NAME entry in the ‘name’ table should start with the same string
+        as the Family Name (FONT_FAMILY_NAME, TYPOGRAPHIC_FAMILY_NAME or
+        WWS_FAMILY_NAME).
+
+        If the Family Name is not included as the first part of the Full Font Name, and
+        the user embeds the font in a document using a Microsoft Office app, the app
+        will fail to render the font when it opens the document again.
+
+        NOTE: Up until version 1.5, the OpenType spec included the following exception
+        in the definition of Full Font Name:
+
+            "An exception to the [above] definition of Full font name is for Microsoft
+            platform strings for CFF OpenType fonts: in this case, the Full font name
+            string must be identical to the PostScript FontName in the CFF Name INDEX."
+
+        https://docs.microsoft.com/en-us/typography/opentype/otspec150/name#name-ids
+    "#,
+    proposal = "https://github.com/fonttools/fontbakery/issues/4829",
+    title = "Does full font name begin with the font family name?"
+)]
+fn check_name_match_familyname_fullfont(t: &Testable, _context: &Context) -> CheckFnResult {
+    let font = testfont!(t);
+    // We actually care about localization here, so don't just want
+    // a vec of String.
+    let full_names = font.font().localized_strings(NameId::FULL_NAME);
+    let family_names = font.font().localized_strings(NameId::FAMILY_NAME);
+    let typographic_names = font
+        .font()
+        .localized_strings(NameId::TYPOGRAPHIC_FAMILY_NAME);
+    let wws_names = font.font().localized_strings(NameId::WWS_FAMILY_NAME);
+    if full_names.len() {}
+    return_result(vec![])
+}