family_directory_name

Author: simoncozens

fontspector-py/tests/test_checks_googlefonts.py

@@ -3406,20 +3406,17 @@ def test_check_meta_script_lang_tags(check):
     assert_results_contain(check(ttFont), WARN, "lacks-meta-table")
 
 
-@pytest.mark.skip("Check not ported yet.")
 @check_id("googlefonts/metadata/family_directory_name")
-def test_check_metadata_family_directory_name(check):
+def test_check_metadata_family_directory_name(check, tmp_path):
     """Check family directory name."""
 
-    font = TEST_FILE("overpassmono/OverpassMono-Regular.ttf")
-    assert_PASS(check(font))
-    old_md = Font(font).family_metadata
+    mdpb = TEST_FILE("overpassmono/METADATA.pb")
+    assert_PASS(check(mdpb))
 
-    # Note:
-    # Here I explicitly pass 'family_metadata' to avoid it being recomputed
-    # after I make the family_directory wrong:
+    # Copy it to a temp directory where it won't have the correct parent name
+    shutil.copy(mdpb, tmp_path / "METADATA.pb")
     assert_results_contain(
-        check(MockFont(file=font, family_metadata=old_md, family_directory="overpass")),
+        check(str(tmp_path / "METADATA.pb")),
         FAIL,
         "bad-directory-name",
     )

profile-googlefonts/src/checks/googlefonts/metadata/family_directory_name.rs

@@ -0,0 +1,40 @@
+use fontspector_checkapi::{prelude::*, skip};
+
+use crate::checks::googlefonts::metadata::family_proto;
+#[check(
+    id = "googlefonts/metadata/family_directory_name",
+    rationale = "
+        We want the directory name of a font family to be predictable and directly
+        derived from the family name, all lowercased and removing spaces.
+    ",
+    applies_to = "MDPB",
+    proposal = "https://github.com/fonttools/fontbakery/issues/3421",
+    title = "Check font family directory name."
+)]
+fn family_directory_name(c: &Testable, _context: &Context) -> CheckFnResult {
+    // Assume we actually have directories, we might not in a WASM context
+    let Some(directory) = c.filename.parent() else {
+        skip!("no-directory", "No directory information")
+    };
+    let msg = family_proto(c)?;
+    let last_component = directory
+        .file_name()
+        .ok_or(CheckError::Error("No directory name".to_string()))?
+        .to_string_lossy();
+    let expected = msg.name().replace(" ", "").to_lowercase();
+    if expected != last_component {
+        Ok(Status::just_one_fail(
+            "bad-directory-name",
+            &format!(
+                "Family name on METADATA.pb is \"{}\"\n\
+            Directory name is \"{}\"\n\
+            Expected \"{}\"",
+                msg.name(),
+                last_component,
+                expected
+            ),
+        ))
+    } else {
+        Ok(Status::just_one_pass())
+    }
+}

profile-googlefonts/src/checks/googlefonts/metadata/mod.rs

@@ -58,3 +58,5 @@ mod designer_profiles;
 pub use designer_profiles::designer_profiles;
 mod includes_production_subsets;
 pub use includes_production_subsets::includes_production_subsets;
+mod family_directory_name;
+pub use family_directory_name::family_directory_name;

profile-googlefonts/src/lib.rs

@@ -64,7 +64,7 @@ impl fontspector_checkapi::Plugin for GoogleFonts {
 
         let builder = builder
             .add_and_register_check(checks::googlefonts::metadata::escaped_strings)
-            //            .add_and_register_check(checks::googlefonts::metadata::family_directory_name)
+            .add_and_register_check(checks::googlefonts::metadata::family_directory_name)
             .add_and_register_check(checks::googlefonts::metadata::familyname)
             .add_and_register_check(checks::googlefonts::metadata::has_regular)
             //            checks::googlefonts::metadata::match_filename_postscript // Merged into metadata/validate