A bunch more checks

simoncozens · simoncozens · commit c47194b61328 · 2024-10-09T10:13:15.000+01:00
diff --git a/fontspector-checkapi/src/constants.rs b/fontspector-checkapi/src/constants.rs
@@ -20,6 +20,92 @@ pub const STATIC_STYLE_NAMES: [&str; 18] = [
     "Black Italic",
 ];
 
+pub const VALID_SCRIPT_TAGS: [&str; 170] = [
+    "DFLT", "adlm", "ahom", "hluw", "arab", "armn", "avst", "bali", "bamu", "bass", "batk", "beng",
+    "bng2", "bhks", "bopo", "brah", "brai", "bugi", "buhd", "byzm", "cans", "cari", "aghb", "cakm",
+    "cham", "cher", "chrs", "hani", "copt", "cprt", "cyrl", "DFLT", "dsrt", "deva", "dev2", "diak",
+    "dogr", "dupl", "egyp", "elba", "elym", "ethi", "geor", "glag", "goth", "gran", "grek", "gujr",
+    "gjr2", "gong", "guru", "gur2", "hang", "jamo", "rohg", "hano", "hatr", "hebr", "kana", "armi",
+    "phli", "prti", "java", "kthi", "knda", "knd2", "kana", "kali", "khar", "kits", "khmr", "khoj",
+    "sind", "lao ", "latn", "lepc", "limb", "lina", "linb", "lisu", "lyci", "lydi", "mahj", "maka",
+    "mlym", "mlm2", "mand", "mani", "marc", "gonm", "math", "medf", "mtei", "mend", "merc", "mero",
+    "plrd", "modi", "mong", "mroo", "mult", "musc", "mymr", "mym2", "nbat", "nand", "newa", "talu",
+    "nko ", "nshu", "hmnp", "orya", "ory2", "ogam", "olck", "ital", "hung", "narb", "perm", "xpeo",
+    "sogo", "sarb", "orkh", "osge", "osma", "hmng", "palm", "pauc", "phag", "phnx", "phlp", "rjng",
+    "runr", "samr", "saur", "shrd", "shaw", "sidd", "sgnw", "sinh", "sogd", "sora", "soyo", "xsux",
+    "sund", "sylo", "syrc", "tglg", "tagb", "tale", "lana", "tavt", "takr", "taml", "tml2", "tang",
+    "telu", "tel2", "thaa", "thai", "tibt", "tfng", "tirh", "ugar", "vai ", "wcho", "wara", "yezi",
+    "yi  ", "zanb",
+];
+
+pub const VALID_LANG_TAGS: [&str; 612] = [
+    "dflt", "ABA ", "ABK ", "ACH ", "ACR ", "ADY ", "AFK ", "AFR ", "AGW ", "AIO ", "AKA ", "AKB ",
+    "ALS ", "ALT ", "AMH ", "ANG ", "APPH", "ARA ", "ARG ", "ARI ", "ARK ", "ASM ", "AST ", "ATH ",
+    "AVR ", "AWA ", "AYM ", "AZB ", "AZE ", "BAD ", "BAD0", "BAG ", "BAL ", "BAN ", "BAR ", "BAU ",
+    "BBC ", "BBR ", "BCH ", "BCR ", "BDY ", "BEL ", "BEM ", "BEN ", "BGC ", "BGQ ", "BGR ", "BHI ",
+    "BHO ", "BIK ", "BIL ", "BIS ", "BJJ ", "BKF ", "BLI ", "BLK ", "BLN ", "BLT ", "BMB ", "BML ",
+    "BOS ", "BPY ", "BRE ", "BRH ", "BRI ", "BRM ", "BRX ", "BSH ", "BSK ", "BTD ", "BTI ", "BTK ",
+    "BTM ", "BTS ", "BTX ", "BTZ ", "BUG ", "BYV ", "CAK ", "CAT ", "CBK ", "CCHN", "CEB ", "CGG ",
+    "CHA ", "CHE ", "CHG ", "CHH ", "CHI ", "CHK ", "CHK0", "CHO ", "CHP ", "CHR ", "CHU ", "CHY ",
+    "CJA ", "CJM ", "CMR ", "COP ", "COR ", "COS ", "CPP ", "CRE ", "CRR ", "CRT ", "CSB ", "CSL ",
+    "CSY ", "CTG ", "CUK ", "DAG ", "DAN ", "DAR ", "DAX ", "DCR ", "DEU ", "DGO ", "DGR ", "DHG ",
+    "DHV ", "DIQ ", "DIV ", "DJR ", "DJR0", "DNG ", "DNJ ", "DNK ", "DRI ", "DUJ ", "DUN ", "DZN ",
+    "EBI ", "ECR ", "EDO ", "EFI ", "ELL ", "EMK ", "ENG ", "ERZ ", "ESP ", "ESU ", "ETI ", "EUQ ",
+    "EVK ", "EVN ", "EWE ", "FAN ", "FAN0", "FAR ", "FAT ", "FIN ", "FJI ", "FLE ", "FMP ", "FNE ",
+    "FON ", "FOS ", "FRA ", "FRC ", "FRI ", "FRL ", "FRP ", "FTA ", "FUL ", "FUV ", "GAD ", "GAE ",
+    "GAG ", "GAL ", "GAR ", "GAW ", "GEZ ", "GIH ", "GIL ", "GIL0", "GKP ", "GLK ", "GMZ ", "GNN ",
+    "GOG ", "GON ", "GRN ", "GRO ", "GUA ", "GUC ", "GUF ", "GUJ ", "GUZ ", "HAI ", "HAL ", "HAR ",
+    "HAU ", "HAW ", "HAY ", "HAZ ", "HBN ", "HER ", "HIL ", "HIN ", "HMA ", "HMN ", "HMO ", "HND ",
+    "HO  ", "HRI ", "HRV ", "HUN ", "HYE ", "HYE0", "IBA ", "IBB ", "IBO ", "IDO ", "IJO ", "ILE ",
+    "ILO ", "INA ", "IND ", "ING ", "INU ", "IPK ", "IPPH", "IRI ", "IRT ", "ISL ", "ISM ", "ITA ",
+    "IWR ", "JAM ", "JAN ", "JAV ", "JBO ", "JCT ", "JII ", "JUD ", "JUL ", "KAB ", "KAB0", "KAC ",
+    "KAL ", "KAN ", "KAR ", "KAT ", "KAZ ", "KDE ", "KEA ", "KEB ", "KEK ", "KGE ", "KHA ", "KHK ",
+    "KHM ", "KHS ", "KHT ", "KHV ", "KHW ", "KIK ", "KIR ", "KIS ", "KIU ", "KJD ", "KJP ", "KJZ ",
+    "KKN ", "KLM ", "KMB ", "KMN ", "KMO ", "KMS ", "KMZ ", "KNR ", "KOD ", "KOH ", "KOK ", "KOM ",
+    "KON ", "KON0", "KOP ", "KOR ", "KOS ", "KOZ ", "KPL ", "KRI ", "KRK ", "KRL ", "KRM ", "KRN ",
+    "KRT ", "KSH ", "KSH0", "KSI ", "KSM ", "KSW ", "KUA ", "KUI ", "KUL ", "KUM ", "KUR ", "KUU ",
+    "KUY ", "KYK ", "KYU ", "LAD ", "LAH ", "LAK ", "LAM ", "LAO ", "LAT ", "LAZ ", "LCR ", "LDK ",
+    "LEZ ", "LIJ ", "LIM ", "LIN ", "LIS ", "LJP ", "LKI ", "LMA ", "LMB ", "LMO ", "LMW ", "LOM ",
+    "LRC ", "LSB ", "LSM ", "LTH ", "LTZ ", "LUA ", "LUB ", "LUG ", "LUH ", "LUO ", "LVI ", "MAD ",
+    "MAG ", "MAH ", "MAJ ", "MAK ", "MAL ", "MAM ", "MAN ", "MAP ", "MAR ", "MAW ", "MBN ", "MBO ",
+    "MCH ", "MCR ", "MDE ", "MDR ", "MEN ", "MER ", "MFA ", "MFE ", "MIN ", "MIZ ", "MKD ", "MKR ",
+    "MKW ", "MLE ", "MLG ", "MLN ", "MLR ", "MLY ", "MND ", "MNG ", "MNI ", "MNK ", "MNX ", "MOH ",
+    "MOK ", "MOL ", "MON ", "MOR ", "MOS ", "MRI ", "MTH ", "MTS ", "MUN ", "MUS ", "MWL ", "MWW ",
+    "MYN ", "MZN ", "NAG ", "NAH ", "NAN ", "NAP ", "NAS ", "NAU ", "NAV ", "NCR ", "NDB ", "NDC ",
+    "NDG ", "NDS ", "NEP ", "NEW ", "NGA ", "NGR ", "NHC ", "NIS ", "NIU ", "NKL ", "NKO ", "NLD ",
+    "NOE ", "NOG ", "NOR ", "NOV ", "NSM ", "NSO ", "NTA ", "NTO ", "NYM ", "NYN ", "NZA ", "OCI ",
+    "OCR ", "OJB ", "ORI ", "ORO ", "OSS ", "PAA ", "PAG ", "PAL ", "PAM ", "PAN ", "PAP ", "PAP0",
+    "PAS ", "PAU ", "PCC ", "PCD ", "PDC ", "PGR ", "PHK ", "PIH ", "PIL ", "PLG ", "PLK ", "PMS ",
+    "PNB ", "POH ", "PON ", "PRO ", "PTG ", "PWO ", "QIN ", "QUC ", "QUH ", "QUZ ", "QVI ", "QWH ",
+    "RAJ ", "RAR ", "RBU ", "RCR ", "REJ ", "RIA ", "RIF ", "RIT ", "RKW ", "RMS ", "RMY ", "ROM ",
+    "ROY ", "RSY ", "RTM ", "RUA ", "RUN ", "RUP ", "RUS ", "SAD ", "SAN ", "SAS ", "SAT ", "SAY ",
+    "SCN ", "SCO ", "SCS ", "SEK ", "SEL ", "SGA ", "SGO ", "SGS ", "SHI ", "SHN ", "SIB ", "SID ",
+    "SIG ", "SKS ", "SKY ", "SLA ", "SLV ", "SML ", "SMO ", "SNA ", "SNA0", "SND ", "SNH ", "SNK ",
+    "SOG ", "SOP ", "SOT ", "SQI ", "SRB ", "SRD ", "SRK ", "SRR ", "SSL ", "SSM ", "STQ ", "SUK ",
+    "SUN ", "SUR ", "SVA ", "SVE ", "SWA ", "SWK ", "SWZ ", "SXT ", "SXU ", "SYL ", "SYR ", "SYRE",
+    "SYRJ", "SYRN", "SZL ", "TAB ", "TAJ ", "TAM ", "TAT ", "TCR ", "TDD ", "TEL ", "TET ", "TGL ",
+    "TGN ", "TGR ", "TGY ", "THA ", "THT ", "TIB ", "TIV ", "TKM ", "TMH ", "TMN ", "TNA ", "TNE ",
+    "TNG ", "TOD ", "TOD0", "TPI ", "TRK ", "TSG ", "TSJ ", "TUA ", "TUL ", "TUM ", "TUV ", "TVL ",
+    "TWI ", "TYZ ", "TZM ", "TZO ", "UDM ", "UKR ", "UMB ", "URD ", "USB ", "UYG ", "UZB ", "VEC ",
+    "VEN ", "VIT ", "VOL ", "VRO ", "WA  ", "WAG ", "WAR ", "WCR ", "WEL ", "WLF ", "WLN ", "WTM ",
+    "XBD ", "XHS ", "XJB ", "XKF ", "XOG ", "XPE ", "YAK ", "YAO ", "YAP ", "YBA ", "YCR ", "YIC ",
+    "YIM ", "ZEA ", "ZGH ", "ZHA ", "ZHH ", "ZHP ", "ZHS ", "ZHT ", "ZHTM", "ZND ", "ZUL ", "ZZA ",
+];
+
+pub const VALID_FEATURE_TAGS: [&str; 122] = [
+    "aalt", "abvf", "abvm", "abvs", "afrc", "akhn", "blwf", "blwm", "blws", "c2pc", "c2sc", "calt",
+    "case", "ccmp", "cfar", "chws", "cjct", "clig", "cpct", "cpsp", "cswh", "curs", "dist", "dlig",
+    "dnom", "dtls", "expt", "falt", "fin2", "fin3", "fina", "flac", "frac", "fwid", "half", "haln",
+    "halt", "hist", "hkna", "hlig", "hngl", "hojo", "hwid", "init", "isol", "ital", "jalt", "jp04",
+    "jp78", "jp83", "jp90", "kern", "lfbd", "liga", "ljmo", "lnum", "locl", "ltra", "ltrm", "mark",
+    "med2", "medi", "mgrk", "mkmk", "mset", "nalt", "nlck", "nukt", "numr", "onum", "opbd", "ordn",
+    "ornm", "palt", "pcap", "pkna", "pnum", "pref", "pres", "pstf", "psts", "pwid", "qwid", "rand",
+    "rclt", "rkrf", "rlig", "rphf", "rtbd", "rtla", "rtlm", "ruby", "rvrn", "salt", "sinf", "size",
+    "smcp", "smpl", "ssty", "stch", "subs", "sups", "swsh", "titl", "tjmo", "tnam", "tnum", "trad",
+    "twid", "unic", "valt", "vatu", "vchw", "vert", "vhal", "vjmo", "vkna", "vkrn", "vpal", "vrt2",
+    "vrtr", "zero",
+];
+
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum GlyphClass {
     Base,
diff --git a/profile-universal/src/checks/layout.rs b/profile-universal/src/checks/layout.rs
@@ -0,0 +1,155 @@
+use std::collections::HashSet;
+
+use fontspector_checkapi::constants::{VALID_FEATURE_TAGS, VALID_LANG_TAGS, VALID_SCRIPT_TAGS};
+use fontspector_checkapi::{prelude::*, testfont, FileTypeConvert};
+use read_fonts::TableProvider;
+
+#[check(
+    id = "opentype/layout_valid_language_tags",
+    rationale = "
+        Incorrect language tags can be indications of typos, leftover debugging code
+        or questionable approaches, or user error in the font editor. Such typos can
+        cause features and language support to fail to work as intended.
+    ",
+    proposal = "https://github.com/fonttools/fontbakery/issues/3355",
+    title = "Does the font have any invalid language tags?"
+)]
+fn layout_valid_language_tags(f: &Testable, _context: &Context) -> CheckFnResult {
+    let font = testfont!(f);
+    let mut bad_tag = HashSet::new();
+
+    if let Ok(gpos) = font.font().gpos() {
+        let scriptlist = gpos.script_list()?;
+        for script in scriptlist.script_records() {
+            for lang in script.script(scriptlist.offset_data())?.lang_sys_records() {
+                let tag = lang.lang_sys_tag().to_string();
+                if !VALID_LANG_TAGS.contains(&tag.as_str()) {
+                    bad_tag.insert(tag);
+                }
+            }
+        }
+    }
+
+    if let Ok(gsub) = font.font().gsub() {
+        let scriptlist = gsub.script_list()?;
+        for script in scriptlist.script_records() {
+            for lang in script.script(scriptlist.offset_data())?.lang_sys_records() {
+                let tag = lang.lang_sys_tag().to_string();
+                if !VALID_LANG_TAGS.contains(&tag.as_str()) {
+                    bad_tag.insert(tag);
+                }
+            }
+        }
+    }
+
+    Ok(if bad_tag.is_empty() {
+        Status::just_one_pass()
+    } else {
+        Status::just_one_fail(
+            "bad-language-tags",
+            &format!(
+                "The following invalid language tags were found in the font: {}",
+                bad_tag.into_iter().collect::<Vec<_>>().join(", ")
+            ),
+        )
+    })
+}
+
+#[check(
+    id = "opentype/layout_valid_script_tags",
+    rationale = "
+        Incorrect script tags can be indications of typos, leftover debugging code
+        or questionable approaches, or user error in the font editor. Such typos can
+        cause features and language support to fail to work as intended.
+    ",
+    proposal = "https://github.com/fonttools/fontbakery/issues/3355",
+    title = "Does the font have any invalid script tags?"
+)]
+fn layout_valid_script_tags(f: &Testable, _context: &Context) -> CheckFnResult {
+    let font = testfont!(f);
+    let mut bad_tag = HashSet::new();
+
+    if let Ok(gpos) = font.font().gpos() {
+        let scriptlist = gpos.script_list()?;
+        for script in scriptlist.script_records() {
+            let tag = script.script_tag().to_string();
+            if !VALID_SCRIPT_TAGS.contains(&tag.as_str()) {
+                bad_tag.insert(tag);
+            }
+        }
+    }
+
+    if let Ok(gsub) = font.font().gsub() {
+        let scriptlist = gsub.script_list()?;
+        for script in scriptlist.script_records() {
+            let tag = script.script_tag().to_string();
+            if !VALID_SCRIPT_TAGS.contains(&tag.as_str()) {
+                bad_tag.insert(tag);
+            }
+        }
+    }
+
+    Ok(if bad_tag.is_empty() {
+        Status::just_one_pass()
+    } else {
+        Status::just_one_fail(
+            "bad-language-tags",
+            &format!(
+                "The following invalid script tags were found in the font: {}",
+                bad_tag.into_iter().collect::<Vec<_>>().join(", ")
+            ),
+        )
+    })
+}
+
+#[check(
+    id = "opentype/layout_valid_feature_tags",
+    rationale = "
+        Incorrect tags can be indications of typos, leftover debugging code
+        or questionable approaches, or user error in the font editor. Such typos can
+        cause features and language support to fail to work as intended.
+
+        Font vendors may use private tags to identify private features. These tags
+        must be four uppercase letters (A-Z) with no punctuation, spaces, or numbers.
+    ",
+    proposal = "https://github.com/fonttools/fontbakery/issues/3355",
+    title = "Does the font have any invalid feature tags?"
+)]
+fn layout_valid_feature_tags(f: &Testable, _context: &Context) -> CheckFnResult {
+    let font = testfont!(f);
+    let mut bad_tag = HashSet::new();
+
+    if let Ok(gpos) = font.font().gpos() {
+        for feature_record in gpos.feature_list()?.feature_records() {
+            let tag = feature_record.feature_tag().to_string();
+            if !VALID_FEATURE_TAGS.contains(&tag.as_str())
+                && (tag.len() != 4 || !tag.chars().all(|c| c.is_ascii_uppercase()))
+            {
+                bad_tag.insert(tag);
+            }
+        }
+    }
+
+    if let Ok(gsub) = font.font().gsub() {
+        for feature_record in gsub.feature_list()?.feature_records() {
+            let tag = feature_record.feature_tag().to_string();
+            if !VALID_FEATURE_TAGS.contains(&tag.as_str())
+                && (tag.len() != 4 || !tag.chars().all(|c| c.is_ascii_uppercase()))
+            {
+                bad_tag.insert(tag);
+            }
+        }
+    }
+
+    Ok(if bad_tag.is_empty() {
+        Status::just_one_pass()
+    } else {
+        Status::just_one_fail(
+            "bad-language-tags",
+            &format!(
+                "The following invalid feature tags were found in the font: {}",
+                bad_tag.into_iter().collect::<Vec<_>>().join(", ")
+            ),
+        )
+    })
+}
diff --git a/profile-universal/src/checks/mod.rs b/profile-universal/src/checks/mod.rs
@@ -6,6 +6,7 @@ pub mod glyf;
 pub mod glyphnames;
 pub mod head;
 pub mod hhea;
+pub mod layout;
 pub mod name;
 pub mod name_trailing_spaces;
 pub mod os2;
diff --git a/profile-universal/src/checks/os2.rs b/profile-universal/src/checks/os2.rs
@@ -127,3 +127,36 @@ fn panose_familytype(c: &TestableCollection, _context: &Context) -> CheckFnResul
         "PANOSE family type is not the same across this family. In order to fix this, please make sure that the panose.bFamilyType value is the same in the OS/2 table of all of this family's font files.",
     )
 }
+
+#[check(
+    id = "opentype/vendor_id",
+    rationale = "
+        When a font project's Vendor ID is specified explicitly on FontBakery's
+        configuration file, all binaries must have a matching vendor identifier
+        value in the OS/2 table.
+    ",
+    proposal = "https://github.com/fonttools/fontbakery/pull/3941",
+    title = "Check OS/2 achVendID against configuration"
+)]
+fn check_vendor_id(f: &Testable, context: &Context) -> CheckFnResult {
+    let font = testfont!(f);
+    let vendor_id = context
+        .check_metadata
+        .get("vendor_id")
+        .ok_or(CheckError::skip(
+            "no-vendor-id",
+            "Add the `vendor_id` key to a `fontspector.yaml` file on your font project directory to enable this check.\nYou'll also need to use the `--configuration` flag when invoking fontspector",
+        ))?;
+    let os2_vendor_id = font.font().os2()?.ach_vend_id().to_string();
+    if os2_vendor_id.as_str() == vendor_id {
+        Ok(Status::just_one_pass())
+    } else {
+        Ok(Status::just_one_fail(
+            "bad-vendor-id",
+            &format!(
+                "OS/2 achVendID value '{}' does not match configuration value '{}'",
+                os2_vendor_id, vendor_id
+            ),
+        ))
+    }
+}
diff --git a/profile-universal/src/checks/stat.rs b/profile-universal/src/checks/stat.rs
@@ -137,3 +137,35 @@ fn stat_has_axis_value_tables(t: &Testable, _context: &Context) -> CheckFnResult
 
     return_result(messages)
 }
+
+#[check(
+    id = "opentype/weight_class_fvar",
+    rationale = "According to Microsoft's OT Spec the OS/2 usWeightClass should match the fvar default value.",
+    proposal = "https://github.com/googlefonts/gftools/issues/477",
+    title = "Checking if OS/2 usWeightClass matches fvar."
+)]
+fn weight_class_fvar(t: &Testable, _context: &Context) -> CheckFnResult {
+    let f = testfont!(t);
+    skip!(!f.is_variable_font(), "not-variable", "Not a variable font");
+    let fvar_value = f
+        .axis_ranges()
+        .find(|(tag, _, _, _)| tag == "wght")
+        .map(|(_, _, default, _)| default)
+        .ok_or(CheckError::skip("no-wght", "No 'wght' axis"))?;
+    let os2_value = f
+        .font()
+        .os2()
+        .map_err(|_| CheckError::skip("no-os2", "No OS/2 table"))?
+        .us_weight_class();
+    if os2_value != fvar_value as u16 {
+        return Ok(Status::just_one_fail(
+            "bad-weight-class",
+            &format!(
+                "OS/2 usWeightClass is {}, but fvar default is {}",
+                os2_value, fvar_value
+            ),
+        ));
+    }
+
+    Ok(Status::just_one_pass())
+}
diff --git a/profile-universal/src/lib.rs b/profile-universal/src/lib.rs
@@ -26,13 +26,18 @@ impl fontspector_checkapi::Plugin for Universal {
         cr.register_check(checks::head::unitsperem);
         cr.register_check(checks::hhea::caret_slope);
         cr.register_check(checks::hhea::maxadvancewidth);
+        cr.register_check(checks::layout::layout_valid_feature_tags);
+        cr.register_check(checks::layout::layout_valid_language_tags);
+        cr.register_check(checks::layout::layout_valid_script_tags);
         cr.register_check(checks::name::check_name_no_copyright_on_description);
         cr.register_check(checks::post::post_table_version);
         cr.register_check(checks::post::underline_thickness);
         cr.register_check(checks::stat::stat_axis_record);
         cr.register_check(checks::stat::stat_has_axis_value_tables);
+        cr.register_check(checks::stat::weight_class_fvar);
         cr.register_check(checks::os2::fsselection);
         cr.register_check(checks::os2::panose_familytype);
+        cr.register_check(checks::os2::check_vendor_id);
 
         let opentype_profile = Profile::from_toml(
             r#"
@@ -64,6 +69,11 @@ impl fontspector_checkapi::Plugin for Universal {
     "opentype/varfont/same_size_instance_records",
     "opentype/varfont/valid_nameids",
     "opentype/stat_has_axis_value_tables",
+    "opentype/layout_valid_feature_tags",
+    "opentype/layout_valid_language_tags",
+    "opentype/layout_valid_script_tags",
+    "opentype/weight_class_fvar",
+    "opentype/vendor_id",
 
     # Checks left to port
     "opentype/cff2_call_depth",
@@ -101,9 +111,6 @@ impl fontspector_checkapi::Plugin for Universal {
     "opentype/italic_axis_in_stat_is_boolean", # Merge into above
     "opentype/italic_axis_last", # Merge into above
     "opentype/kern_table",
-    "opentype/layout_valid_feature_tags",
-    "opentype/layout_valid_language_tags",
-    "opentype/layout_valid_script_tags",
     "opentype/loca/maxp_num_glyphs",
     "opentype/monospace",
     "opentype/name/italic_names",
@@ -113,8 +120,6 @@ impl fontspector_checkapi::Plugin for Universal {
     "opentype/postscript_name",
     "opentype/slant_direction",
     "opentype/varfont/valid_default_instance_nameids",
-    "opentype/vendor_id",
-    "opentype/weight_class_fvar",
     "opentype/xavgcharwidth",
 ]
 "#,
