Comment out unfinished check

Author: simoncozens

fontspector-checkapi/src/font.rs

@@ -8,11 +8,7 @@ use read_fonts::{
     types::Version16Dot16,
     TableProvider,
 };
-use skrifa::{
-    font::FontRef,
-    string::{LocalizedStrings, StringId},
-    GlyphId, MetadataProvider, Tag,
-};
+use skrifa::{font::FontRef, string::StringId, GlyphId, MetadataProvider, Tag};
 use std::{
     cell::RefCell,
     collections::{HashMap, HashSet},

profile-universal/src/checks/bold_italic_unique.rs

@@ -2,7 +2,6 @@ use std::collections::HashSet;
 
 use fontspector_checkapi::{prelude::*, FileTypeConvert};
 use read_fonts::tables::os2::SelectionFlags;
-use skrifa::string::StringId;
 
 #[check(
     id = "opentype/family/bold_italic_unique_for_nameid1",

profile-universal/src/checks/name.rs

@@ -1,7 +1,6 @@
 use font_types::NameId;
 use fontspector_checkapi::{prelude::*, testfont, FileTypeConvert};
 use read_fonts::TableProvider;
-use skrifa::MetadataProvider;
 
 #[check(
     id = "opentype/name/empty_records",
@@ -64,39 +63,39 @@ should be removed (perhaps these were added by a longstanding FontLab Studio
     return_result(problems)
 }
 
-#[check(
-    id = "opentype/name/match_familyname_fullfont",
-    rationale = r#"
-        The FULL_FONT_NAME entry in the ‘name’ table should start with the same string
-        as the Family Name (FONT_FAMILY_NAME, TYPOGRAPHIC_FAMILY_NAME or
-        WWS_FAMILY_NAME).
+// #[check(
+//     id = "opentype/name/match_familyname_fullfont",
+//     rationale = r#"
+//         The FULL_FONT_NAME entry in the ‘name’ table should start with the same string
+//         as the Family Name (FONT_FAMILY_NAME, TYPOGRAPHIC_FAMILY_NAME or
+//         WWS_FAMILY_NAME).
 
-        If the Family Name is not included as the first part of the Full Font Name, and
-        the user embeds the font in a document using a Microsoft Office app, the app
-        will fail to render the font when it opens the document again.
+//         If the Family Name is not included as the first part of the Full Font Name, and
+//         the user embeds the font in a document using a Microsoft Office app, the app
+//         will fail to render the font when it opens the document again.
 
-        NOTE: Up until version 1.5, the OpenType spec included the following exception
-        in the definition of Full Font Name:
+//         NOTE: Up until version 1.5, the OpenType spec included the following exception
+//         in the definition of Full Font Name:
 
-            "An exception to the [above] definition of Full font name is for Microsoft
-            platform strings for CFF OpenType fonts: in this case, the Full font name
-            string must be identical to the PostScript FontName in the CFF Name INDEX."
+//             "An exception to the [above] definition of Full font name is for Microsoft
+//             platform strings for CFF OpenType fonts: in this case, the Full font name
+//             string must be identical to the PostScript FontName in the CFF Name INDEX."
 
-        https://docs.microsoft.com/en-us/typography/opentype/otspec150/name#name-ids
-    "#,
-    proposal = "https://github.com/fonttools/fontbakery/issues/4829",
-    title = "Does full font name begin with the font family name?"
-)]
-fn check_name_match_familyname_fullfont(t: &Testable, _context: &Context) -> CheckFnResult {
-    let font = testfont!(t);
-    // We actually care about localization here, so don't just want
-    // a vec of String.
-    let full_names = font.font().localized_strings(NameId::FULL_NAME);
-    let family_names = font.font().localized_strings(NameId::FAMILY_NAME);
-    let typographic_names = font
-        .font()
-        .localized_strings(NameId::TYPOGRAPHIC_FAMILY_NAME);
-    let wws_names = font.font().localized_strings(NameId::WWS_FAMILY_NAME);
-    // if full_names.len() {}
-    return_result(vec![])
-}
+//         https://docs.microsoft.com/en-us/typography/opentype/otspec150/name#name-ids
+//     "#,
+//     proposal = "https://github.com/fonttools/fontbakery/issues/4829",
+//     title = "Does full font name begin with the font family name?"
+// )]
+// fn check_name_match_familyname_fullfont(t: &Testable, _context: &Context) -> CheckFnResult {
+//     let font = testfont!(t);
+//     // We actually care about localization here, so don't just want
+//     // a vec of String.
+//     let full_names = font.font().localized_strings(NameId::FULL_NAME);
+//     let family_names = font.font().localized_strings(NameId::FAMILY_NAME);
+//     let typographic_names = font
+//         .font()
+//         .localized_strings(NameId::TYPOGRAPHIC_FAMILY_NAME);
+//     let wws_names = font.font().localized_strings(NameId::WWS_FAMILY_NAME);
+//     // if full_names.len() {}
+//     return_result(vec![])
+// }