Skip to content

Refactor GroupOrderArticle updates #579

Open
@wvengen

Description

@wvengen

There are several places where GroupOrderArticles are created and/or updated. This happens in different ways. It would be healthy to consolidate that, if possible.

Let's investigate a bit and then see what makes sense.

  • Member ordering just calls the group order's save_group_order_articles. Here all order articles are iterated, and at the end the group order totals are saved.
  • Balancing: add & remove ordergroup for order article: this template using goa controller. Here only the result it set, as computation of who gets what is already done, and the order article's result doesn't change anymore.
  • API /api/v1/group_order_articles (in PR API-4: ordering #573) does something similar as member ordering, but then per group order article.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions