Improved code coverage

Author: pozil

src/test/default/classes/QuizEditorControllerTest.cls

@@ -0,0 +1,38 @@
+@isTest(isParallel=true)
+public class QuizEditorControllerTest {
+    @isTest
+    static void setSessionQuestions_fails_when_no_session_id() {
+        try {
+            QuizEditorController.setSessionQuestions(null, new List<Id>());
+            // expect to fail
+            System.assert(false);
+        } catch (AuraHandledException e) {
+            System.assert(true);
+        }
+    }
+
+    @isTest
+    static void setSessionQuestions_fails_when_no_questions() {
+        try {
+            QuizEditorController.setSessionQuestions(
+                'a043N000000pLrVQAU',
+                null
+            );
+            // expect to fail
+            System.assert(false);
+        } catch (AuraHandledException e) {
+            System.assert(true);
+        }
+    }
+
+    @isTest
+    static void getSessionQuestions_fails_when_no_session_id() {
+        try {
+            QuizEditorController.getSessionQuestions(null);
+            // expect to fail
+            System.assert(false);
+        } catch (AuraHandledException e) {
+            System.assert(true);
+        }
+    }
+}

src/test/default/classes/QuizEditorControllerTest.cls-meta.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
+    <apiVersion>48.0</apiVersion>
+    <status>Active</status>
+</ApexClass>

src/test/default/classes/QuizPlayerServiceTest.cls

@@ -1,7 +1,21 @@
 @isTest(isParallel=true)
 public class QuizPlayerServiceTest {
     @isTest
-    static void onlyPlayerRanksOne() {
+    static void getFromName_works() {
+        List<Quiz_Player__c> players = QuizSessionTestFactory.createQuizPlayers(
+            1
+        );
+
+        QuizPlayerService playerService = new QuizPlayerService();
+        Quiz_Player__c player = playerService.getFromName(
+            QuizSessionTestFactory.PLAYER_NAME_PREFIX + '0'
+        );
+
+        System.assertEquals(players[0].Id, player.Id);
+    }
+
+    @isTest
+    static void assignRanking_works_with_one_player() {
         QuizSessionTestFactory.createQuizPlayers(1);
 
         QuizPlayerService playerService = new QuizPlayerService();
@@ -16,7 +30,7 @@ public class QuizPlayerServiceTest {
     }
 
     @isTest
-    static void twoPlayersSameScoreBothRankOne() {
+    static void assignRanking_works_with_two_player_same_score() {
         Quiz_Player__c player1 = QuizSessionTestFactory.createQuizPlayerWithScore(
             'one',
             100
@@ -46,7 +60,7 @@ public class QuizPlayerServiceTest {
     }
 
     @isTest
-    static void twoPlayersDifferentScoreDifferentRanking() {
+    static void assignRanking_works_with_two_player_different_score() {
         Quiz_Player__c player1 = QuizSessionTestFactory.createQuizPlayerWithScore(
             'one',
             100
@@ -76,7 +90,7 @@ public class QuizPlayerServiceTest {
     }
 
     @isTest
-    static void threePlayersMixedRanking() {
+    static void assignRanking_works_with_three_players() {
         Quiz_Player__c player1 = QuizSessionTestFactory.createQuizPlayerWithScore(
             'one',
             100

src/test/default/classes/QuizPlayerStatsRestResourceTest.cls

@@ -26,7 +26,7 @@ public class QuizPlayerStatsRestResourceTest {
     }
 
     @isTest
-    static void getPlayerStats_failsWhenMissingPlayerId() {
+    static void getPlayerStats_fails_whenMissingPlayerId() {
         RestRequest request = new RestRequest();
         request.requestUri = '/services/apexrest/quiz/player/stats';
 
@@ -46,7 +46,7 @@ public class QuizPlayerStatsRestResourceTest {
     }
 
     @isTest
-    static void getPlayerStats_failsWhenUnknownPlayerId() {
+    static void getPlayerStats_fails_whenUnknownPlayerId() {
         RestRequest request = new RestRequest();
         request.requestUri = '/services/apexrest/quiz/player/stats';
         request.params.put(

src/test/default/classes/QuizQuestionServiceTest.cls

@@ -0,0 +1,13 @@
+@isTest(isParallel=true)
+public class QuizQuestionServiceTest {
+    @isTest
+    static void getQuestions_works() {
+        QuizQuestionService service = new QuizQuestionService();
+        Quiz_Question__c question = QuizSessionTestFactory.createQuizQuestion();
+
+        List<Quiz_Question__c> questions = service.getQuestions();
+
+        System.assertEquals(1, questions.size());
+        System.assertEquals(question.Id, questions[0].Id);
+    }
+}

src/test/default/classes/QuizQuestionServiceTest.cls-meta.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
+    <apiVersion>48.0</apiVersion>
+    <status>Active</status>
+</ApexClass>

src/test/default/classes/QuizSessionTestFactory.cls

@@ -1,5 +1,6 @@
 @isTest
 public class QuizSessionTestFactory {
+    public static final String PLAYER_NAME_PREFIX = 'player';
     private static final String PHASE_REGISTRATION = QuizSessionService.Phase.Registration.name();
 
     public static Quiz_Session__c createQuizSession() {
@@ -43,7 +44,7 @@ public class QuizSessionTestFactory {
     public static List<Quiz_Player__c> createQuizPlayers(Integer playerCount) {
         List<Quiz_Player__c> players = new List<Quiz_Player__c>();
         for (Integer i = 0; i < playerCount; i++) {
-            players.add(new Quiz_Player__c(Name = 'player' + i));
+            players.add(new Quiz_Player__c(Name = PLAYER_NAME_PREFIX + i));
         }
         insert players;
         return players;