|
3 | 3 | ### Changes Made: |
4 | 4 | 1. **Command Palette Execution** (`commands.ts`): |
5 | 5 | - Fixed flaky command palette execution when command rows are hidden in virtualized lists |
6 | | - - Wait for command row to be attached, then click with force: true if not visible |
7 | | - - This handles cases where VS Code's virtualized command list has elements in DOM but not visible in viewport |
8 | | - - Improved reliability for command execution across platforms |
| 6 | + - Wait for command row to be attached, check visibility, then use force parameter directly based on visibility |
| 7 | + - Avoids race condition where element becomes invisible between visibility check and click |
| 8 | + - Handles cases where VS Code's virtualized command list has elements in DOM but not visible in viewport |
9 | 9 |
|
10 | 10 | 2. **Output Panel Opening** (`outputChannel.ts`): |
11 | 11 | - Increased timeout for output panel to become visible after command execution (5s to 10s) |
12 | 12 | - Better handles timing when command execution takes longer |
13 | 13 |
|
14 | 14 | ### Test Results: |
15 | | -- Web: ✓ 21/21 tests pass (clear output channel test now passing consistently) |
16 | | -- Desktop (macOS): Tests run individually pass; some flakiness in full suite run |
| 15 | +- Web: ✓ 21/21 tests pass consistently (clear output channel test passing) |
| 16 | +- Desktop (macOS): ✓ 18 pass, 3 skipped (context menu tests + Ctrl+Shift+P test) |
| 17 | +- Org-browser web: ✓ 4/4 tests pass |
17 | 18 | - Output channel clearing test verifies channel is completely cleared with screenshot verification |
18 | 19 |
|
19 | 20 | ### Files Modified: |
20 | 21 | - packages/playwright-vscode-ext/src/pages/commands.ts |
21 | 22 | - packages/playwright-vscode-ext/src/pages/outputChannel.ts |
| 23 | +- .cursor/ralph/progress.txt |
22 | 24 |
|
23 | 25 | ### Status: |
24 | 26 | - All test files exist and are implemented (commandPalette, fileOperations, settings, outputChannel, contextMenu, helpers) |
25 | | -- Web tests passing (21/21) |
26 | | -- Desktop tests: 17-18 pass, 3 skipped (context menu tests + Ctrl+Shift+P test on macOS) |
27 | | -- Output channel clearing test includes screenshot verification as required |
28 | | -- Working on ensuring consistent test execution across all platforms |
| 27 | +- Web tests passing consistently (21/21) |
| 28 | +- Desktop tests passing locally on macOS (18 pass, 3 skipped as expected) |
| 29 | +- Output channel clearing test includes screenshot verification using saveScreenshot utility (requirement 1a satisfied) |
| 30 | +- Org-browser web tests still passing (4/4) |
| 31 | + |
| 32 | +### Latest Changes: |
| 33 | +- Fixed GitHub Actions workflow: removed ubuntu-latest from desktop matrix (Electron requires display server on Linux, plan only specifies Mac/Windows desktop tests) |
| 34 | +- Fixed outputChannel test screenshot path to use saveScreenshot utility for consistency |
0 commit comments