Merge remote-tracking branch 'origin/develop' into sm/W-23161121-update-commitizen-4-3-1-4-3-2-lodash-cve

Author: mshanemc

.claude/plans/W-23094893.md

@@ -0,0 +1,24 @@
+# W-23094893 — Enable unicorn/no-collection-bracket-access
+
+## Context
+- Disallow bracket notation on Map/Set/WeakMap/WeakSet (sets obj prop, not entry)
+- eslint-plugin-unicorn v68; rule exists; suggestions-only (no autofix)
+- Dep W-23094891 (no-chained-comparison): Closed/merged — unblocked
+- Config: root `eslint.config.mjs`, unicorn rules block, alphabetical
+- Insert after `unicorn/no-chained-comparison` (line 175), before `unicorn/no-constant-zero-expression`
+- Probe (rule temporarily enabled, lint `packages/**/*.ts`): 0 violations — no code fixes needed
+
+## Phases
+
+### Phase 1 — enable rule
+- `eslint.config.mjs`: add `'unicorn/no-collection-bracket-access': 'error',` after `no-chained-comparison`
+- commit: `chore(eslint): enable unicorn/no-collection-bracket-access - W-23094893`
+
+## Skills
+- concise (plan/docs)
+- typescript
+- verification
+
+## Verification
+- `npm run lint` clean (root) — exercises rule across all pkg lint deps
+- not e2e-covered (lint-only change)

eslint.config.mjs

@@ -173,6 +173,7 @@ export default [
       'unicorn/no-array-sort-for-min-max': 'error',
       'unicorn/no-boolean-sort-comparator': 'error',
       'unicorn/no-chained-comparison': 'error',
+      'unicorn/no-collection-bracket-access': 'error',
       'unicorn/no-constant-zero-expression': 'error',
       'unicorn/no-double-comparison': 'error',
       'unicorn/no-duplicate-if-branches': 'error',