feat: delete source W-20175982 (#6755)

Author: mshanemc

package-lock.json

@@ -32,18 +32,22 @@ export const createFileWithContents = async (page: Page, filePath: string, conte
   await quickInput.waitFor({ state: 'visible', timeout: 10_000 });
 
   // Check what prompt appears:
-  // - If "Text File" option is visible → file type picker (select it first)
+  // - If "Text File" option is visible → file type picker (type filename directly per placeholder text)
   // - Otherwise → filename input (type filename directly)
   const textFileOption = page.locator(QUICK_INPUT_LIST_ROW).filter({ hasText: 'Text File' });
   const hasFileTypePicker = await textFileOption.isVisible().catch(() => false);
 
   if (hasFileTypePicker) {
-    // File type picker flow: select "Text File", then filename prompt appears
-    await textFileOption.click();
-    await quickInput.waitFor({ state: 'visible', timeout: 5000 });
+    // File type picker flow: placeholder says "Select File Type or Enter File Name..."
+    // Type filename directly without selecting "Text File" option
+    const input = quickInput.getByRole('textbox').first();
+    await input.waitFor({ state: 'attached', timeout: 10_000 });
+    await input.focus();
+    // Wait for input to be visible after focus
+    await expect(input).toBeVisible({ timeout: 10_000 });
   }
 
-  // Now at filename prompt (both flows converge here)
+  // Type filename (works for both file type picker and direct input flows)
   await page.keyboard.type(fileName);
   await page.keyboard.press('Enter');
 

packages/playwright-vscode-ext/src/utils/fileHelpers.ts

@@ -29,6 +29,7 @@ export const createHeadlessServer = async (options: HeadlessServerOptions): Prom
     await open({
       browserType: 'chromium',
       headless: true,
+      quality: 'stable',
       port: 3001,
       printServerLog: true,
       verbose: true,

packages/playwright-vscode-ext/src/web/createHeadlessServer.ts

@@ -18,7 +18,7 @@
     "@salesforce/vscode-service-provider": "^1.5.0",
     "applicationinsights": "1.0.7",
     "cross-spawn": "7.0.6",
-    "effect": "^3.10.3",
+    "effect": "^3.19.14",
     "rxjs": "^5.4.1",
     "tree-kill": "^1.1.0",
     "vscode-uri": "^3.1.0",

packages/salesforcedx-utils-vscode/package.json

@@ -29,7 +29,7 @@
     "@salesforce/salesforcedx-utils": "*",
     "@salesforce/salesforcedx-utils-vscode": "*",
     "@salesforce/vscode-i18n": "*",
-    "effect": "^3.19.13",
+    "effect": "^3.19.14",
     "vscode-uri": "^3.1.0"
   },
   "devDependencies": {

packages/salesforcedx-vscode-apex-replay-debugger/package.json

@@ -104,10 +104,18 @@ const registerSharedCommands = (): vscode.Disposable => {
       projectDeployStart(isDeployOnSave, true)
     ),
     vscode.commands.registerCommand('sf.project.retrieve.start', projectRetrieveStart),
+    vscode.commands.registerCommand('sf.project.retrieve.start.ignore.conflicts', () => projectRetrieveStart(true)),
     vscode.commands.registerCommand('sf.view.all.changes', viewAllChanges),
     vscode.commands.registerCommand('sf.view.local.changes', viewLocalChanges),
     vscode.commands.registerCommand('sf.view.remote.changes', viewRemoteChanges),
-    vscode.commands.registerCommand('sf.apex.generate.class', apexGenerateClass)
+    vscode.commands.registerCommand('sf.apex.generate.class', apexGenerateClass),
+    vscode.commands.registerCommand('sf.delete.source', deleteSource),
+    vscode.commands.registerCommand('sf.delete.source.current.file', deleteSource),
+    vscode.commands.registerCommand('sf.deploy.source.path', deploySourcePaths),
+    vscode.commands.registerCommand('sf.deploy.in.manifest', deployManifest),
+    vscode.commands.registerCommand('sf.retrieve.source.path', retrieveSourcePaths),
+    vscode.commands.registerCommand('sf.retrieve.current.source.file', retrieveSourcePaths),
+    vscode.commands.registerCommand('sf.retrieve.in.manifest', retrieveManifest)
   );
 };
 
@@ -122,16 +130,8 @@ const registerCommands = (extensionContext: vscode.ExtensionContext): vscode.Dis
     vscode.commands.registerCommand('sf.diff', sourceDiff),
     vscode.commands.registerCommand('sf.open.documentation', openDocumentation),
     vscode.commands.registerCommand('sf.internal.refreshsobjects', refreshSObjects),
-    vscode.commands.registerCommand('sf.delete.source', deleteSource),
-    vscode.commands.registerCommand('sf.delete.source.current.file', deleteSource),
     vscode.commands.registerCommand('sf.deploy.current.source.file', deploySourcePaths),
-    vscode.commands.registerCommand('sf.deploy.in.manifest', deployManifest),
     vscode.commands.registerCommand('sf.deploy.multiple.source.paths', deploySourcePaths),
-    vscode.commands.registerCommand('sf.deploy.source.path', deploySourcePaths),
-    vscode.commands.registerCommand('sf.project.retrieve.start.ignore.conflicts', () => projectRetrieveStart(true)),
-    vscode.commands.registerCommand('sf.retrieve.source.path', retrieveSourcePaths),
-    vscode.commands.registerCommand('sf.retrieve.current.source.file', retrieveSourcePaths),
-    vscode.commands.registerCommand('sf.retrieve.in.manifest', retrieveManifest),
     vscode.commands.registerCommand('sf.task.stop', taskStop),
     vscode.commands.registerCommand('sf.apex.generate.unit.test.class', apexGenerateUnitTestClass),
     vscode.commands.registerCommand('sf.analytics.generate.template', analyticsGenerateTemplate),

packages/salesforcedx-vscode-core/src/index.ts

@@ -73,7 +73,7 @@
     "acorn-loose": "^6.0.0",
     "acorn-walk": "^6.0.0",
     "applicationinsights": "1.0.7",
-    "effect": "^3.10.3",
+    "effect": "^3.19.14",
     "vscode-html-languageservice": "^5.5.1",
     "vscode-languageclient": "^9.0.1"
   },

packages/salesforcedx-vscode-lightning/package.json

@@ -31,7 +31,7 @@
     "@salesforce/salesforcedx-utils-vscode": "*",
     "@salesforce/vscode-i18n": "*",
     "applicationinsights": "1.0.7",
-    "effect": "^3.18.4",
+    "effect": "^3.19.14",
     "jest-editor-support": "31.1.2",
     "jest-regex-util": "^24.9.0",
     "rxjs": "^5.4.1",

packages/salesforcedx-vscode-lwc/package.json

@@ -24,7 +24,7 @@
     "Other"
   ],
   "dependencies": {
-    "effect": "^3.19.13",
+    "effect": "^3.19.14",
     "@salesforce/vscode-i18n": "*",
     "vscode-uri": "^3.1.0"
   },
@@ -248,6 +248,14 @@
           "command": "sf.apex.generate.class",
           "when": "salesforcedx-vscode-metadata.showSharedCommands"
         },
+        {
+          "command": "sf.delete.source",
+          "when": "never"
+        },
+        {
+          "command": "sf.delete.source.current.file",
+          "when": "salesforcedx-vscode-metadata.showSharedCommands && sf:has_target_org && resourceLangId != 'forcesourcemanifest'"
+        },
         {
           "command": "sf.deploy.source.path",
           "when": "never"
@@ -278,6 +286,10 @@
         }
       ],
       "editor/context": [
+        {
+          "command": "sf.delete.source",
+          "when": "salesforcedx-vscode-metadata.showSharedCommands && sf:has_target_org && resourceLangId != 'forcesourcemanifest'"
+        },
         {
           "command": "sf.deploy.source.path",
           "when": "salesforcedx-vscode-metadata.showSharedCommands && sf:has_target_org && resourceLangId != 'forcesourcemanifest'"
@@ -296,6 +308,10 @@
         }
       ],
       "explorer/context": [
+        {
+          "command": "sf.delete.source",
+          "when": "salesforcedx-vscode-metadata.showSharedCommands && sf:has_target_org && resourceLangId != 'forcesourcemanifest'"
+        },
         {
           "command": "sf.deploy.source.path",
           "when": "salesforcedx-vscode-metadata.showSharedCommands && sf:has_target_org && resourceLangId != 'forcesourcemanifest'"
@@ -347,6 +363,14 @@
         "command": "sf.apex.generate.class",
         "title": "%apex_generate_class_text%"
       },
+      {
+        "command": "sf.delete.source",
+        "title": "%delete_source_text%"
+      },
+      {
+        "command": "sf.delete.source.current.file",
+        "title": "%delete_source_text%"
+      },
       {
         "command": "sf.deploy.source.path",
         "title": "%deploy_this_source_text%"

packages/salesforcedx-vscode-metadata/package.json

@@ -13,6 +13,7 @@
   "project_retrieve_start_ignore_conflicts_default_org_text": "SFDX: Pull Source from Default Org and Ignore Conflicts",
   "retrieve_this_source_text": "SFDX: Retrieve This Source from Org",
   "retrieve_in_manifest_text": "SFDX: Retrieve Source in Manifest from Org",
+  "delete_source_text": "SFDX: Delete from Project and Org",
   "source_tracking_status_bar_local_changes": "Local Changes",
   "source_tracking_status_bar_remote_changes": "Remote Changes",
   "source_tracking_status_bar_conflicts": "Conflicts",