test: e2e de-flaking when commands aren't ready

Author: mshanemc

packages/salesforcedx-vscode-core/test/playwright/specs/analyticsTemplates.headless.spec.ts

@@ -12,6 +12,7 @@ import {
   setupNetworkMonitoring,
   waitForVSCodeWorkbench,
   waitForWorkspaceReady,
+  verifyCommandExists,
   closeWelcomeTabs,
   executeCommandWithCommandPalette,
   validateNoCriticalErrors,
@@ -37,6 +38,7 @@ test.describe('Analytics Templates (Desktop Only)', () => {
   test('Create Sample Analytics Template', async ({ page }) => {
     const name = `Analytics${Date.now()}`;
     await test.step(`Create Analytics Template ${name}`, async () => {
+      await verifyCommandExists(page, packageNls.analytics_generate_template_text, 30_000);
       await executeCommandWithCommandPalette(page, packageNls.analytics_generate_template_text);
 
       const quickInput = page.locator(QUICK_INPUT_WIDGET);

packages/salesforcedx-vscode-core/test/playwright/specs/auraTemplates.headless.spec.ts

@@ -12,6 +12,7 @@ import {
   setupNetworkMonitoring,
   waitForVSCodeWorkbench,
   waitForWorkspaceReady,
+  verifyCommandExists,
   closeWelcomeTabs,
   executeCommandWithCommandPalette,
   validateNoCriticalErrors,
@@ -37,6 +38,7 @@ test.describe('Aura Templates (Desktop Only)', () => {
 
   const createAuraTemplate = async (page: any, command: string, name: string, expectedFiles: string[]) => {
     await test.step(`Create Aura ${name}`, async () => {
+      await verifyCommandExists(page, command, 30_000);
       await executeCommandWithCommandPalette(page, command);
 
       const quickInput = page.locator(QUICK_INPUT_WIDGET);

packages/salesforcedx-vscode-core/test/playwright/specs/manifestBuilder.headless.spec.ts

@@ -12,6 +12,7 @@ import {
   setupConsoleMonitoring,
   openFileByName,
   executeCommandWithCommandPalette,
+  verifyCommandExists,
   executeExplorerContextMenuCommand,
   clearOutputChannel,
   waitForOutputChannelText,
@@ -76,6 +77,7 @@ test('Manifest Builder: generate manifest, deploy and retrieve via manifest', as
     await openFileByName(page, 'package.xml');
     await clearOutputChannel(page);
 
+    await verifyCommandExists(page, packageNls.deploy_in_manifest_text, 120_000);
     await executeCommandWithCommandPalette(page, packageNls.deploy_in_manifest_text);
     await waitForOutputChannelText(page, {
       expectedText: 'Deployed Source',

packages/salesforcedx-vscode-core/test/playwright/specs/metadataDeployRetrieve.headless.spec.ts

@@ -12,6 +12,7 @@ import {
   editOpenFile,
   openFileByName,
   executeCommandWithCommandPalette,
+  verifyCommandExists,
   clearOutputChannel,
   waitForOutputChannelText,
   validateNoCriticalErrors,
@@ -50,6 +51,7 @@ test('Metadata Deploy Retrieve: deploy v1, deploy v2, retrieve matches v2', asyn
 
     await clearOutputChannel(page);
     await openFileByName(page, `${className}.cls`);
+    await verifyCommandExists(page, packageNls.deploy_this_source_text, 120_000);
     await executeCommandWithCommandPalette(page, packageNls.deploy_this_source_text);
     await waitForOutputChannelText(page, {
       expectedText: `Ended ${packageNls.deploy_this_source_text}`,

packages/salesforcedx-vscode-core/test/playwright/specs/pushAndPull.headless.spec.ts

@@ -10,6 +10,7 @@ import {
   setupConsoleMonitoring,
   editOpenFile,
   executeCommandWithCommandPalette,
+  verifyCommandExists,
   clearOutputChannel,
   waitForOutputChannelText,
   validateNoCriticalErrors,
@@ -33,6 +34,7 @@ test('Push and Pull: push, pull, and view changes', async ({ page }) => {
 
   await test.step('view all changes (empty)', async () => {
     await clearOutputChannel(page);
+    await verifyCommandExists(page, packageNls.view_all_changes_text, 120_000);
     await executeCommandWithCommandPalette(page, packageNls.view_all_changes_text);
     await waitForOutputChannelText(page, {
       expectedText: SOURCE_STATUS_HEADER,

packages/salesforcedx-vscode-core/test/playwright/specs/visualforceTemplates.headless.spec.ts

@@ -12,6 +12,7 @@ import {
   setupNetworkMonitoring,
   waitForVSCodeWorkbench,
   waitForWorkspaceReady,
+  verifyCommandExists,
   closeWelcomeTabs,
   executeCommandWithCommandPalette,
   validateNoCriticalErrors,
@@ -37,6 +38,7 @@ test.describe('Visualforce Templates (Desktop Only)', () => {
 
   const createVisualforceTemplate = async (page: any, command: string, name: string, expectedFiles: string[]) => {
     await test.step(`Create Visualforce ${name}`, async () => {
+      await verifyCommandExists(page, command, 30_000);
       await executeCommandWithCommandPalette(page, command);
 
       const quickInput = page.locator(QUICK_INPUT_WIDGET);