Skip to content

Commit e962129

Browse files
mshanemcclaude
andcommitted
refactor: medium/low review findings - W-23163017
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent f4bd045 commit e962129

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.claude/plans/W-23163017.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
- API surface used: `core.setOutput` (+ getInput/setFailed per WI) — unchanged in 2.0.3
1010
- 2.0.3 stays CJS (3.0.0 ESM-only); node20 runtime OK
1111
- 1 of 2 for this GHSA; sibling WI = `@actions/github`. undici@5.29.0 fully gone only after both land
12-
- transitive churn: `@actions/core@1.11.1` declares `@actions/exec ^1.1.1`; 2.0.3 declares `@actions/exec ^2.0.0` (which declares `@actions/io ^2.0.0`, io has no deps). Lockfile currently has top-level `exec@1.1.1` (package-lock.json:136) + `io@1.1.3` (line 170) — `core` is their SOLE dependent (only requirement sites: package-lock.json:132 core→exec, :142 exec→io). `@actions/github` does NOT depend on exec/io (its deps: undici/@octokit*/http-client). So `npm install` upgrades both in place to exec@2.x + io@2.x; no nested copy, no version conflict (nothing requires exec@1.x once core moves to ^2.0.0)
12+
- transitive churn: `@actions/exec` 1.1.1→2.x + `@actions/io` 1.1.3→2.x; both upgraded in place (sole dependent is core); no version conflict, no nested copy
1313

1414
## Phases
1515

@@ -33,4 +33,4 @@
3333
- `npm run compile:github-actions` exits 0 (no API break); git diff on lib minimal/none
3434
- `npm run check:actions` passes
3535
- NOT covered by branch e2e (CI tooling dep, not extension runtime)
36-
- note: undici@5.29.0 persists until sibling `@actions/github` WI lands — expected, not a failure here
36+
- undici@5.29.0 persists until sibling `@actions/github` WI lands — expected

0 commit comments

Comments
 (0)