docs(org): concise cleanup of W-23069592 plan - W-23069592

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: mshanemc

.claude/plans/W-23069592.md

@@ -3,12 +3,12 @@
 ## Context
 
 - Org ext `extensionProvider.ts` has inline `buildAllServicesLayer` (lines 20-54), duplicate of shared `@salesforce/effect-ext-utils` export.
-- Diff vs shared: inline hardcodes `'Salesforce Org Management'` fallback; shared takes `fallbackDisplayName` param. Otherwise identical.
+- Diff vs shared: inline hardcodes `'Salesforce Org Management'` fallback; shared takes `fallbackDisplayName` param.
 - Pattern to mirror: core (`packages/salesforcedx-vscode-core/src/services/extensionProvider.ts`) — local `extensionProvider.ts` keeps only `AllServicesLayer`/`setAllServicesLayer`; imports `buildAllServicesLayer` from `@salesforce/effect-ext-utils`; does NOT re-export it; `index.ts` imports it from shared too and calls `buildAllServicesLayer(ctx, nls.localize('channel_name'))` (core index.ts:49).
 - Shared signature (`node_modules/@salesforce/effect-ext-utils/src/allServicesLayer.ts:27`): `buildAllServicesLayer(context: ExtensionContext, fallbackDisplayName: string)`. Pass `nls.localize('channel_name')` as `fallbackDisplayName`.
 - Org keeps extra runtime helpers: `OrgRuntime` type, `getOrgRuntime`, `resetOrgRuntimeForTesting` — stay in local file.
 - `nls.localize('channel_name')` = `'Salesforce Org Management'` (matches package.json `displayName`).
-- Gates picker + command WIs.
+- Gates: picker + command WIs.
 
 Files:
 - `packages/salesforcedx-vscode-org/src/extensionProvider.ts`
@@ -22,9 +22,8 @@ Files:
 ### Phase 1 — swap inline for shared helper (mirror core; no re-export)
 
 `extensionProvider.ts`:
-- Delete inline `buildAllServicesLayer` (lines 20-54) + `ExtensionProviderServiceLive`.
-- Import `buildAllServicesLayer` from `@salesforce/effect-ext-utils` (used by the `ReturnType<>` type refs in `AllServicesLayer`/`setAllServicesLayer`/`OrgRuntime`).
-- Do NOT re-export it (matches core; avoids re-exporting a third-party symbol as our own surface).
+- Delete inline `buildAllServicesLayer` (lines 20-54), `ExtensionProviderServiceLive`.
+- Import `buildAllServicesLayer` from `@salesforce/effect-ext-utils` (used by the `ReturnType<>` type refs in `AllServicesLayer`/`setAllServicesLayer`/`OrgRuntime`); do NOT re-export it (matches core; avoids re-exporting a third-party symbol as our own surface).
 - Drop now-unused imports: `ExtensionPackageJsonSchema`, `ExtensionProviderService`, `ExtensionPackageJson`, `getServicesApi`, `Effect`, `Schema`, `ExtensionContext`. `Layer` stays (used by `OrgRuntime` type via `Layer.Layer.Success`/`Layer.Layer.Error`).
 - Keep `AllServicesLayer`, `setAllServicesLayer`, `OrgRuntime` type, `getOrgRuntime`, `resetOrgRuntimeForTesting`, `ManagedRuntime` import.
 
@@ -50,7 +49,7 @@ commit msg: `refactor(org): use shared buildAllServicesLayer in extensionProvide
 
 ## Verification
 
-- `npm run compile` (or package tsc) — type check; confirms removed imports resolve and the 3 repointed test casts resolve `ReturnType<typeof buildAllServicesLayer>` from `@salesforce/effect-ext-utils`.
+- `npm run compile` (or package tsc) — confirms removed imports + 3 repointed test casts resolve `ReturnType<typeof buildAllServicesLayer>` from `@salesforce/effect-ext-utils`.
 - Org jest: `orgUtil.test.ts`, `orgLogout.test.ts`, `orgLogoutSelected.test.ts` reference `buildAllServicesLayer`/`setAllServicesLayer`/`getOrgRuntime` — must pass.
 - lint (no unused imports left; `Layer` retained for `OrgRuntime` type).
 - Runtime channel name unchanged (`'Salesforce Org Management'`). E2E coverage: `packages/salesforcedx-vscode-org/test/playwright/specs/orgPicker.desktop.spec.ts` — `ORG_OUTPUT_CHANNEL = 'Salesforce Org Management'` (line 39), `selectOutputChannel(page, ORG_OUTPUT_CHANNEL)` + `waitForOutputChannelText` (lines 87-88) assert output renders under that exact channel name. If the fallback regressed, this spec fails to find the channel.