Respond correctly to --killSignal (was: no logging after graceful shutdown)

[mef]

Whenever I shutdown a script using --killSignal=SIGTERM (cf. #320), all the operations executed after running forever stop are not show in the logs anymore.

You can observe this problem on forever-monitor graceful exit example

1. run forever start --killSignal=SIGTERM graceful-exit.js
2. run forever stop graceful-exit.js
3. check the produced produced log. The sentence 'Exiting after some time.' should appear, but it does not.

Am I missing something?

This is not a really big deal, as at least these instructions are being executed (only the logging in forever log file is not performed).

This happens to me on node 0.8.17, and current master version of forever and forever-monitor.

[maxrabin]

+1. This has a very buggy feeling. I would watch the logs to see if it was printing my debug "initiating graceful shutdown" and it never happened! Eventually I realized that the graceful shutdown was happening, but that took a while (and an upgrade to the latest version of forever)

[mahnunchik]

+1 Not only SIGTERM, all signals=(

[tangxinfa]

+1 console.log not work in signal handler, so it is not very graceful:)

[hbstone]

+1

Issue still exists, node 0.10.25 and forever 0.10.11. Logs inside the kill signal handler do not get written to the log files.

[tmfset]

This issue is a bug in forever-monitor, the monitor process captures the stdout of the child process but once the kill signal is sent, forever-monitor doesn't wait for it to exit before stopping.
@airandfingers has created a basic fix for this if you need it.

[jessefulton]

Any updates on this? This makes it virtually impossible to determine whether graceful shutdowns are actually completing properly...

[jlukanta]

Some explanation: #528

[artworkad]

+1

[ronny332]

+1

+1

[dewvow]

+1