feat(build): include the build step as a pretest script instead of inline in the test script

Author: travi

src/package/scripts/test-script-updater.js

@@ -9,10 +9,7 @@ function projectShouldBeBuiltForVerification(scripts) {
 export default function (scripts) {
   return {
     ...scripts,
-    test: `npm-run-all --print-label${
-      projectShouldBeBuiltForVerification(scripts) ? ' build' : ''
-    } --parallel lint:*${
-      projectWillBeTested(scripts) ? ' --parallel test:*' : ''
-    }`
+    ...projectShouldBeBuiltForVerification(scripts) && {pretest: 'run-s build'},
+    test: `npm-run-all --print-label --parallel lint:*${projectWillBeTested(scripts) ? ' --parallel test:*' : ''}`
   };
 }

src/package/scripts/test-script-updater.test.js

@@ -14,7 +14,8 @@ describe('test script updater', () => {
     expect(updateTestScript({...scripts, 'pregenerate:md': 'run-s build'})).toEqual({
       ...scripts,
       'pregenerate:md': 'run-s build',
-      test: 'npm-run-all --print-label build --parallel lint:*'
+      pretest: 'run-s build',
+      test: 'npm-run-all --print-label --parallel lint:*'
     });
   });
 

test/integration/features/step_definitions/npm-steps.js

@@ -94,10 +94,13 @@ export async function assertThatPackageDetailsAreConfiguredCorrectlyFor({
   const packageDetails = JSON.parse(await fs.readFile(`${projectRoot}/package.json`, 'utf-8'));
 
   if (tested && projectTypes.PACKAGE === projectType && provideExample && dialects.COMMON_JS !== dialect) {
-    assert.equal(packageDetails.scripts.test, 'npm-run-all --print-label build --parallel lint:* --parallel test:*');
+    assert.equal(packageDetails.scripts.pretest, 'run-s build');
+    assert.equal(packageDetails.scripts.test, 'npm-run-all --print-label --parallel lint:* --parallel test:*');
   } else if (tested) {
+    assert.isUndefined(packageDetails.scripts.pretest);
     assert.equal(packageDetails.scripts.test, 'npm-run-all --print-label --parallel lint:* --parallel test:*');
   } else {
+    assert.isUndefined(packageDetails.scripts.pretest);
     assert.equal(packageDetails.scripts.test, 'npm-run-all --print-label --parallel lint:*');
   }
 

test/integration/features/step_definitions/scripts-steps.js

@@ -58,7 +58,8 @@ Then('the script is added for ensuring the node engines requirement is met', asy
 });
 
 Then('the updated test script includes build', async function () {
-  const {scripts: {test}} = JSON.parse(await fs.readFile(`${process.cwd()}/package.json`, 'utf8'));
+  const {scripts: {pretest, test}} = JSON.parse(await fs.readFile(`${process.cwd()}/package.json`, 'utf8'));
 
-  assert.include(test, 'build');
+  assert.equal(pretest, 'run-s build');
+  assert.notInclude(test, 'build');
 });