feat(npm-run-all): remove the old library in addition to installing the fork to complete the replace

Author: travi

src/package/scripts/lifter.js

@@ -3,6 +3,11 @@ import updateTestScript from './test-script-updater.js';
 export default function ({existingScripts, scripts}) {
   return {
     scripts: updateTestScript({...existingScripts, ...scripts}),
-    dependencies: {javascript: {development: ['npm-run-all2']}}
+    dependencies: {
+      javascript: {
+        development: ['npm-run-all2'],
+        remove: ['npm-run-all']
+      }
+    }
   };
 }

src/package/scripts/lifter.test.js

@@ -16,7 +16,12 @@ describe('package.json scripts lifter', () => {
 
     expect(liftScripts({existingScripts, scripts})).toEqual({
       scripts: updatedScripts,
-      dependencies: {javascript: {development: ['npm-run-all2']}}
+      dependencies: {
+        javascript: {
+          development: ['npm-run-all2'],
+          remove: ['npm-run-all']
+        }
+      }
     });
   });
 });

test/integration/features/step_definitions/dependencies-steps.js

@@ -25,7 +25,7 @@ export function assertDevDependencyIsInstalled(execa, dependencyName) {
 }
 
 export function assertDependenciesWereRemoved(execa, packageManager, dependencyNames) {
-  td.verify(execa(packageManager, ['remove', ...dependencyNames]));
+  td.verify(execa(packageManager, td.matchers.contains('remove', ...dependencyNames)));
 }
 
 Then('ls-engines is added as a dependency', async function () {