Skip to content

Commit 5603020

Browse files
committed
fix(lift): stop duplicating the original results when lifting the readme
1 parent f077768 commit 5603020

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/lift.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import deepmerge from 'deepmerge';
21
import {applyEnhancers} from '@form8ion/core';
32
import {lift as liftReadme} from '@form8ion/readme';
43
import * as gitPlugin from '@form8ion/git';
@@ -13,7 +12,7 @@ export default async function ({projectRoot, results, enhancers, vcs, dependenci
1312
dependencies
1413
});
1514

16-
await liftReadme({projectRoot, results: deepmerge.all([results, enhancerResults])});
15+
await liftReadme({projectRoot, results: enhancerResults});
1716

1817
return enhancerResults;
1918
}

src/lift.test.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import deepmerge from 'deepmerge';
21
import * as core from '@form8ion/core';
32
import * as readme from '@form8ion/readme';
43
import * as gitPlugin from '@form8ion/git';
@@ -26,7 +25,6 @@ describe('lift', () => {
2625
const vcs = any.simpleObject();
2726
const results = any.simpleObject();
2827
const enhancerResults = any.simpleObject();
29-
const mergedResults = any.simpleObject();
3028
when(core.applyEnhancers)
3129
.calledWith({
3230
results,
@@ -35,9 +33,8 @@ describe('lift', () => {
3533
dependencies
3634
})
3735
.mockResolvedValue(enhancerResults);
38-
when(deepmerge.all).calledWith([results, enhancerResults]).mockReturnValue(mergedResults);
3936

4037
expect(await lift({projectRoot, results, enhancers, vcs, dependencies})).toEqual(enhancerResults);
41-
expect(readme.lift).toHaveBeenCalledWith({projectRoot, results: mergedResults});
38+
expect(readme.lift).toHaveBeenCalledWith({projectRoot, results: enhancerResults});
4239
});
4340
});

0 commit comments

Comments
 (0)