Skip to content

Commit eedd3bf

Browse files
authored
Merge pull request #14 from forman/0.1.0-alpha.6
0.1.0 alpha.6
2 parents 17e94e7 + 3bb60e5 commit eedd3bf

File tree

20 files changed

+264
-51
lines changed

20 files changed

+264
-51
lines changed
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
## Description
2+
3+
_Describe the change and include links to relevant issue(s) here._
4+
5+
## Checklist
6+
7+
_Check all and include list in PR:_
8+
9+
- [ ] I have checked to ensure there aren't other open
10+
[Pull Requests](https://github.com/forman/extendit/pulls)
11+
for the same update/change
12+
- [ ] I respect this project's
13+
[Code of Conduct](https://github.com/forman/extendit/blob/main/CODE_OF_CONDUCT.md)
14+
- [ ] I formatted code according to this project's `prettier` configuration.
15+
- [ ] I verified `npm run lint` runs without errors.
16+
- [ ] I verified `npm run test` runs without errors.
17+
- [ ] I verified `npm run coverage` is at 100% for any change.
18+
19+
_Check and keep if applicable_
20+
21+
- [ ] I verified `npm run typedoc` runs without errors.
22+
- [ ] I have updated or added new documentation relevant for the change.
23+
24+
_More details regarding our coding convention can be found in the
25+
[contributing](https://github.com/forman/extendit/blob/main/CONTRIBUTING.md)
26+
guideline._
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
## Description
2+
3+
_Describe the change and include links to relevant issue(s) here._
4+
5+
## Checklist
6+
7+
_Check all and include list in PR:_
8+
9+
- [ ] I have checked to ensure there aren't other open
10+
[Pull Requests](https://github.com/forman/extendit/pulls)
11+
for the same update/change
12+
- [ ] I respect this project's
13+
[Code of Conduct](https://github.com/forman/extendit/blob/main/CODE_OF_CONDUCT.md)
14+
15+
_Check and keep if applicable_
16+
17+
- [ ] I verified `npm run typedoc` runs without errors.

CONTRIBUTING.md

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# How to contribute
2+
3+
The [ExtendIt.js](README.md) project welcomes contributions of any form
4+
as long as you respect our [code of conduct](CODE_OF_CONDUCT.md) and stay in line with
5+
the following instructions and guidelines.
6+
7+
If you have suggestions, ideas, feature requests, or if you have identified
8+
a malfunction or error, then please
9+
[post an issue](https://github.com/forman/extendit/issues).
10+
11+
If you'd like to submit code or documentation changes, we ask you to provide a
12+
[PR](https://github.com/forman/extendit/pulls).
13+
For code and configuration changes, your PR must be linked to a
14+
corresponding issue.
15+
16+
To ensure that your code contributions are consistent with our project’s
17+
coding guidelines, please make sure all applicable items of the following
18+
checklist are addressed in your PR.
19+
20+
**PR checklist**
21+
22+
* Use language [TypeScript](https://www.typescriptlang.org/) using the same
23+
[configuration](tsconfig.json) as we do.
24+
* Format code using [prettier](https://prettier.io/) using the same
25+
[configuration](.prettierrc.json) as we do.
26+
* Inspect code using [eslint](https://eslint.org/) using the same
27+
[configuration](.eslintrc.cjs) as we do.
28+
`npm run lint` must run without errors.
29+
* Your change shall not break existing unit tests.
30+
`npm run test` must run without errors.
31+
* Add unit tests for any new code not yet covered by tests
32+
using [vitest](https://vitest.dev/).
33+
If you add new modules make sure you add a test module
34+
`<name>.test.ts` for each next to it.
35+
* Make sure test coverage is at 100% for any change.
36+
Use `npm run coverage` to verify.
37+
* If you add or change new public API components, add or change API
38+
documentation accordingly using
39+
[TSDoc](https://tsdoc.org/).
40+
`npm run typedoc` must run without errors.
41+
* If your change affects the current project documentation,
42+
(currently only the [README](README.md) file)
43+
please adjust it and include the change in the PR.

TODO.md

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,20 @@
22

33
## For first stable version
44

5-
* Make `contrib` an own toplevel subpackage
5+
* Add TSDoc to all types, classes, members, methods,
6+
functions, and constants also in `util` and `contrib`.
7+
* Review and adjust logging, check for consistent use of logger names
8+
and log levels.
9+
* Add coverage badge in `README.md`.
10+
11+
## Potential design changes for later versions
12+
13+
* Make `contrib` an own toplevel subpackage
614
- Every contribution point should go into a separate submodule.
715
- Every submodule should be exported, so points can
816
be imported independently of each other and so tree-shaking
917
becomes possible during build.
10-
- Every submodule should have its own `index` and comprise implementation
18+
- Every submodule should have its own `index` and comprise implementation
1119
modules `types`, `point`, `get`, `hooks`, and optionally others.
1220
- Add unit tests for each module of a submodule.
1321
- Allow using the contrib module without React.
@@ -16,16 +24,6 @@
1624
Some exports of current `framework/util` are used by public `core` and
1725
`contrib` APIs. These elements may then be re-exported by `core` and
1826
`contrib` to hide an extra `utils` package.
19-
* Implement a GH action that builds documentation in `./docs` including
20-
API docs, so we don't have to include generated API docs pages in source code.
21-
* Add TSDoc to all types, classes, members, methods,
22-
functions, and constants also in `util` and `contrib`.
23-
* Review and adjust logging, check for consistent use of logger names
24-
and log levels.
25-
* Add coverage badge in `README.md`.
26-
27-
## Potential design changes for later versions
28-
2927
* Split exported modules into separate packages:
3028
- Use [npm workspaces](https://docs.npmjs.com/cli/v7/using-npm/workspaces).
3129
- Turn single-package repo into monorepo comprising multiple

docs/.gitignore

Whitespace-only changes.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@forman2/extendit",
3-
"version": "0.1.0-alpha.5",
3+
"version": "0.1.0-alpha.6",
44
"type": "module",
55
"displayName": "ExtendIt.js",
66
"description": "A framework supporting development of extensible and scalable JavaScript applications",
@@ -13,17 +13,13 @@
1313
"keywords": [
1414
"dependency inversion",
1515
"dependency injection",
16-
"contributions",
17-
"extensions",
18-
"management",
19-
"manager",
16+
"extension management",
2017
"state",
2118
"store",
2219
"react"
2320
],
2421
"files": [
2522
"dist",
26-
"src",
2723
"logo.png"
2824
],
2925
"exports": {

src/framework/contrib/commands.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ function processCommand(command: CommandManifestEntry): Command {
7676
* {@link commandsPoint}.
7777
*
7878
* @category UI Contributions API
79+
* @experimental
7980
*/
8081
export const commandsPoint: ContributionPoint<
8182
CommandManifestEntry[],

src/framework/contrib/configuration.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ const configurationSchema = {
7070
* {@link configurationPoint}.
7171
*
7272
* @category UI Contributions API
73+
* @experimental
7374
*/
7475
export const configurationPoint: ContributionPoint<Configuration> = {
7576
id: "configuration",

src/framework/contrib/data-views.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,12 @@ const schema: JSONSchemaType<DataViewManifestEntry[]> = {
6060
};
6161

6262
/**
63-
* The "views" contribution point.
63+
* The "dataViews" contribution point.
6464
* To register in your app, call {@link registerContributionPoint} with
6565
* {@link dataViewsPoint}.
6666
*
6767
* @category UI Contributions API
68+
* @experimental
6869
*/
6970
export const dataViewsPoint: ContributionPoint<DataViewManifestEntry[]> = {
7071
id: "dataViews",

0 commit comments

Comments
 (0)