fix: handle popover state manually#202
Draft
logaretm wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: f535caf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Our popover implementation does not explicitly close the popover until it gets closed by its default user agent behavior (e.g: clicking outside, etc...).
Now this doesn't work for components like comboboxes, because they have a couple of elements triggers the state of the popover:
Our current implementation fails the input field interaction, specifically those scenarios:
This PR fixes that by using
popover=manualbehavior, which would put us in full control for when the popover opens/closes.For now I have added the click outside handling, but there could be other scenarios where we want to prevent/open the popover ourselves, we will also require some minor testing to see if we broke the current behavior as well.