[Bug] Critical Networking & Persistence Failures: Duplicate Row Logic, Regex Crashes, and History Data Loss

[dhairyajangir]

Describe the bug/problem

Three high-severity regressions have been identified in the networking and persistence layers:

• Networking: getEnabledRows uses indexOf to check if a row is enabled. Since indexOf returns the first occurrence of a value, duplicate parameter names (e.g., two headers named Set-Cookie) result in the second parameter always mirroring the enabled/disabled state of the first.

• Utils: substituteVariables constructs a global RegExp using environment variable keys without escaping them. Keys containing metacharacters (e.g., user.id or base+url) cause a FormatException, crashing the request sequence.

• Persistence: addHistoryRequest and editHistoryRequest trigger Hive writes without the await keyword. This creates a race condition where the app can be closed before the history index is updated, leading to orphaned records and data loss.

Steps to Reproduce the bug/problem

1. For Row Logic: Create two query parameters: key=1 (Enabled) and key=2 (Disabled). Send the request; note that key=2 is incorrectly included.
2. For Regex Crash: Define an environment variable with a dot, such as api.key. Use {{api.key}} in any request field and attempt to send.
3. For Data Loss: Send a request and force-close the app immediately. Upon restart, the request will not appear in the history list.

Expected behavior

• Rows: Parameters should be filtered by their specific list index, not by value-based search.
• Regex: Variable keys should be escaped using RegExp.escape() to support common naming conventions like dots and dashes.
• Persistence: All database writes must be fully awaited to ensure atomic-like updates to history metadata and request bodies.

Technical Details & Fix Direction

• File: packages/better_networking/lib/utils/http_request_utils.dart
  • Fix: Replace .where with an index-based for loop or .asMap().entries.where.
• File: lib/utils/envvar_utils.dart
  • Fix: Map keys through an escape function before joining into the regex string.
• File: lib/providers/history_providers.dart
  • Fix: Add await to setHistoryIds() and setHistoryMeta() calls.

Device Info (The device where you encountered this issue)

• OS: Windows
• Version: Windows 11 22H2
• Environment: Production & Development environments

[Exodus2004]

Proposed Implementation Plan: Fix Networking Row Logic, Regex Crashes, and Hive Persistence Races

Hello Maintainers! I would love to resolve these three high-severity issues under GSSoC '26. Here is my proposed step-by-step implementation plan:

1. Fix Value-Based Indexing in getEnabledRows

• File: packages/better_networking/lib/utils/http_request_utils.dart
• Issue: Value-based indexing via indexOf returns the index of the first occurrence, which breaks duplicate parameters (e.g., duplicate header keys like Set-Cookie or Cache-Control).
• Fix: Access rows by their actual positional index. Instead of doing value-based search, filter the collection using entry keys via Dart's asMap().entries:

  // Replace value-based checks with index-based iteration:
  final enabledEntries = rows
      .asMap()
      .entries
      .where((entry) => entry.value.enabled)
      .map((entry) => entry.value)
      .toList();

2. Escape Metacharacters in Environment Variable Substitutions

• File: lib/utils/envvar_utils.dart
• Issue: Keys containing metacharacters (e.g., user.id or api.key) trigger a FormatException when passed directly into the RegExp constructor.
• Fix: Implement a RegExp escaping helper to neutralize special metacharacters prior to constructing the RegExp:

  String escapeRegExp(String str) {
    return str.replaceAll(RegExp(r'[\-\[\]{}()*+?.,\\\^$|#\s]'), r'\$&');
  }

  Map the environment variable keys through escapeRegExp before joining them into the search pattern.

3. Await Asynchronous Hive Writes in History Providers

• File: lib/providers/history_providers.dart
• Issue: Missing await keywords on database write operations trigger background races, potentially leading to lost history records if the app is closed.
• Fix: Update all async storage calls (e.g., in addHistoryRequest, editHistoryRequest) to use await on functions like setHistoryIds() and setHistoryMeta(). Mark the calling methods as async where necessary.

I am ready to implement these fixes right away. Could you please assign this issue to me?

[rajesh-puripanda]

Multiple networking + persistence bugs. I'll audit the collection state management — fix duplicate row logic, fix state corruption in persistence, add targeted unit tests.

[rajesh-puripanda]

@foss42 I've outlined my approach above — I'm ready to implement this. Please assign this issue to me. Will submit a clean PR once assigned.