wip: update default config path #8
Annotations
8 warnings
|
[clippy] src/lib.rs#L208:
src/lib.rs#L208
warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
--> src/lib.rs:208:13
|
208 | / for item in iter.by_ref() {
209 | | if let Ok(entry) = item {
210 | | // Check if this is an untracked file
211 | | if matches!(
... |
219 | | }
| |_____________^
|
help: try `.flatten()` and remove the `if let` statement in the for loop
--> src/lib.rs:209:17
|
209 | / if let Ok(entry) = item {
210 | | // Check if this is an untracked file
211 | | if matches!(
212 | | entry,
... |
218 | | }
| |_________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#manual_flatten
= note: `#[warn(clippy::manual_flatten)]` on by default
help: try
|
208 ~ for entry in iter.by_ref().flatten() {
209 + // Check if this is an untracked file
210 + if matches!(
211 + entry,
212 + gix::status::index_worktree::iter::Item::DirectoryContents { .. }
213 + ) {
214 + debug!("Repository has untracked files: {}", repo_path.display());
215 + return Ok(true);
216 + }
217 + }
|
|
|
[clippy] src/lib.rs#L654:
src/lib.rs#L654
warning: this boolean expression can be simplified
--> src/lib.rs:654:12
|
654 | if !std::fs::metadata(&source).is_ok() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&source).is_err()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#nonminimal_bool
= note: `#[warn(clippy::nonminimal_bool)]` on by default
|
|
[clippy] src/lib.rs#L680:
src/lib.rs#L680
warning: this boolean expression can be simplified
--> src/lib.rs:680:12
|
680 | if !std::fs::metadata(&source).is_ok() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&source).is_err()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#nonminimal_bool
|
|
[clippy] src/main.rs#L147:
src/main.rs#L147
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/main.rs:147:21
|
147 | / match workset::tui::run_tui(&workspace)? {
148 | | Some(repo) => {
149 | | let pattern: workset::RepoPattern = repo
150 | | .parse()
... |
154 | | None => (),
155 | | }
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
147 ~ if let Some(repo) = workset::tui::run_tui(&workspace)? {
148 + let pattern: workset::RepoPattern = repo
149 + .parse()
150 + .map_err(|e| anyhow::anyhow!("Failed to parse pattern: {}", e))?;
151 + workspace.open(workspace.library.as_ref(), &pattern)?;
152 + }
|
|
|
[clippy] src/lib.rs#L208:
src/lib.rs#L208
warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
--> src/lib.rs:208:13
|
208 | / for item in iter.by_ref() {
209 | | if let Ok(entry) = item {
210 | | // Check if this is an untracked file
211 | | if matches!(
... |
219 | | }
| |_____________^
|
help: try `.flatten()` and remove the `if let` statement in the for loop
--> src/lib.rs:209:17
|
209 | / if let Ok(entry) = item {
210 | | // Check if this is an untracked file
211 | | if matches!(
212 | | entry,
... |
218 | | }
| |_________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#manual_flatten
= note: `#[warn(clippy::manual_flatten)]` on by default
help: try
|
208 ~ for entry in iter.by_ref().flatten() {
209 + // Check if this is an untracked file
210 + if matches!(
211 + entry,
212 + gix::status::index_worktree::iter::Item::DirectoryContents { .. }
213 + ) {
214 + debug!("Repository has untracked files: {}", repo_path.display());
215 + return Ok(true);
216 + }
217 + }
|
|
|
[clippy] src/lib.rs#L654:
src/lib.rs#L654
warning: this boolean expression can be simplified
--> src/lib.rs:654:12
|
654 | if !std::fs::metadata(&source).is_ok() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&source).is_err()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#nonminimal_bool
= note: `#[warn(clippy::nonminimal_bool)]` on by default
|
|
[clippy] src/lib.rs#L680:
src/lib.rs#L680
warning: this boolean expression can be simplified
--> src/lib.rs:680:12
|
680 | if !std::fs::metadata(&source).is_ok() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&source).is_err()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#nonminimal_bool
|
|
[clippy] src/main.rs#L147:
src/main.rs#L147
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/main.rs:147:21
|
147 | / match workset::tui::run_tui(&workspace)? {
148 | | Some(repo) => {
149 | | let pattern: workset::RepoPattern = repo
150 | | .parse()
... |
154 | | None => (),
155 | | }
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
147 ~ if let Some(repo) = workset::tui::run_tui(&workspace)? {
148 + let pattern: workset::RepoPattern = repo
149 + .parse()
150 + .map_err(|e| anyhow::anyhow!("Failed to parse pattern: {}", e))?;
151 + workspace.open(workspace.library.as_ref(), &pattern)?;
152 + }
|
|