[Feature Request] Web Interface method to refresh Feed icons

[deathbybandaid]

It would be really nice to have a button in the web interface to delete and replace Feed icons/logos. As of now, it seems the best method to achieve this goal is to delete and recreate feeds to get updated logos.

[jtojnar]

Weird, IIRC, it should refresh icon with each update. Will double check later.

[jtojnar]

Yeah, looking at the code, sources do not even have icons – the settings page just uses the icon from the last fetched item:

selfoss/src/daos/mysql/Sources.php

Lines 209 to 223 in 4fcf02f

	$ret = $this->database->exec('SELECT
	sources.id, sources.title, sources.tags, sources.spout,
	sources.params, sources.filter, sources.error, sources.lastentry,
	sourceicons.icon AS icon
	FROM ' . $this->configuration->dbPrefix . 'sources AS sources
	LEFT OUTER JOIN
	(SELECT items.source, icon
	FROM ' . $this->configuration->dbPrefix . 'items AS items,
	(SELECT source, MAX(id) as maxid
	FROM ' . $this->configuration->dbPrefix . 'items AS items
	WHERE icon IS NOT NULL AND icon != \'\'
	GROUP BY items.source) AS icons
	WHERE items.id=icons.maxid AND items.source=icons.source
	) AS sourceicons
	ON sources.id=sourceicons.source

So assuming a new items appeared in the feed, the icon will be update for the source (and for all past items, whose icon share the same URL).

Do you mean the icons on the settings page or on individual items?

Could you add log_level=debug to your config.ini and see what is logged when you refresh the source you want to update?

[deathbybandaid]

The icons for the sources is what I meant.

I make custom youtube feeds with the channel logo set as the icon. I recently updated from 2.18 to 2.19, as newer selfoss will use this icon parameter, whereas 2.18 would fetch youtube.com/favicon.ico for all the feeds.

Sadly, I already recreated all my feeds in selfoss to get the icons to refresh. If I get some time, maybe I'll create a dummy feed to test with.

[jtojnar]

That looks like article icons, not source icons. Article icons for existing articles will not get updated unless a newly fetched article uses the same icon URL.

The way it currently works is that each article has a hash of the icon URL stored in the database. Icons are associated with articles/items because some spouts like reddit can have a different icon for each item.

Though it might make sense to store source icon for each source in the database, since I actually recently made spouts distinguish source and item icons. Then an icon would change retrospectively for items without icon even when a source icon URL changes.