The More button sometimes appears by mistake

[cr04ch]

selfoss	2.20-8307769
Firefox	115.0.2
Chromium	115.0.5790.102

Steps to reproduce the problem

1. Load feeds to include unread items for at least one (but not all) tags.
2. In the navigation pane, select the filter Unread and select a tag that does not contain unread items.
3. Wait for the second scheduled reload to happen.

127.0.0.1 - - [28/Jul/2023:09:51:42 +0200] "GET /selfoss/?type=unread&tag=Egy%C3%A9b&extraIds%5B%5D=&sourcesNav=false&search=&itemsPerPage=10 HTTP/1.1" 200 170
127.0.0.1 - - [28/Jul/2023:09:57:39 +0200] "GET /selfoss/items/sync?since=1970-01-01T00%3A00%3A00.000Z&tags=true HTTP/1.1" 200 157
127.0.0.1 - - [28/Jul/2023:09:57:39 +0200] "GET /selfoss/?type=unread&tag=Egy%C3%A9b&extraIds%5B%5D=&sourcesNav=false&search=&itemsPerPage=10 HTTP/1.1" 200 170
127.0.0.1 - - [28/Jul/2023:10:03:39 +0200] "GET /selfoss/items/sync?since=2023-07-27T16%3A43%3A07.000Z&tags=true&itemsStatuses=true HTTP/1.1" 200 42

Expected behavior

Since there is no item to display according to the current filter and tag, the More button should not appear.

Actual behavior

The More button will appear. Clicking on the button does nothing. This behavior is not affected by the value of the auto_stream_more option.

[jtojnar]

Thanks for reporting. I have seen this bug too. Unfortunately that part of the code is still a big mess (see #1370) so it is difficult to debug it.

I am currently porting the codebase to TypeScript (#1457), which will allow for better reasoning about the code and less error-prone refactoring. Hopefully, we will be able to fix this during the cleanups that will follow.