refactor(cmd): Don't initialise API unless needed

Author: elldritch

builders/nodejs.go

@@ -148,10 +148,12 @@ func (builder *NodeJSBuilder) Analyze(m module.Module, allowUnresolved bool) ([]
 func (builder *NodeJSBuilder) IsBuilt(m module.Module, allowUnresolved bool) (bool, error) {
 	log.Logger.Debugf("Checking Nodejs build: %#v %#v", m, allowUnresolved)
 
+	// bug: there are some package.json with no deps (no node_modules)
 	// TODO: Check if the installed modules are consistent with what's in the
 	// actual manifest.
 	isBuilt, err := hasFile(m.Dir, "node_modules")
 	if err != nil {
+		// TODO: make this optional -- IsBuilt failures should just be warnings
 		return false, fmt.Errorf("could not find Nodejs dependencies folder: %s", err.Error())
 	}
 

cmd/fossa/cliutil/init.go

@@ -8,9 +8,11 @@ import (
 	"github.com/fossas/fossa-cli/log"
 )
 
-func Init(ctx *cli.Context) config.CLIConfig {
+func Initialize(ctx *cli.Context, useAPI bool) config.CLIConfig {
 	c := config.MustNew(ctx)
 	log.Initialize(c.Interactive, c.Debug)
-	fossa.Initialize(c.Endpoint, c.APIKey)
+	if useAPI {
+		fossa.MustInitialize(c.Endpoint, c.APIKey)
+	}
 	return c
 }

cmd/fossa/cmd/upload/upload.go

@@ -90,7 +90,7 @@ func getInput(ctx *cli.Context, usingLocators bool) ([]fossa.SourceUnit, error)
 }
 
 func Run(ctx *cli.Context) {
-	c := cliutil.Init(ctx)
+	c := cliutil.Initialize(ctx, true)
 
 	data, err := getInput(ctx, c.UploadCmd.UseLocators)
 	if err != nil {