[ANE-2235] Fix hlint warnings in PnpmLockSpec.hs by replacing error/undefined with invalidDependency

Author: ryanlink

Diff for: test/Pnpm/PnpmLockSpec.hs

@@ -4,6 +4,7 @@ module Pnpm.PnpmLockSpec (
   spec,
 ) where
 
+import Data.Either (fromRight)
 import Data.Set qualified as Set
 import Data.String.Conversion (toString)
 import Data.Text (Text)
@@ -30,26 +31,40 @@ import Test.Hspec (
   it,
   runIO,
  )
+import Test.Hspec.Core.QuickCheck (shouldSatisfy)
+import Test.Hspec.Expectations (shouldMatchList)
+
+-- | A dependency value used as a default in case of parsing errors in tests
+invalidDependency :: Dependency
+invalidDependency =
+  Dependency
+    NodeJSType
+    "INVALID_PACKAGE_NAME"
+    Nothing
+    mempty
+    mempty
+    mempty
 
 mkProdDep :: Text -> Dependency
-mkProdDep nameAtVersion = mkDep nameAtVersion (Just EnvProduction)
+mkProdDep nameAtVersion = fromRight invalidDependency $ mkDep nameAtVersion (Just EnvProduction)
 
 mkDevDep :: Text -> Dependency
-mkDevDep nameAtVersion = mkDep nameAtVersion (Just EnvDevelopment)
+mkDevDep nameAtVersion = fromRight invalidDependency $ mkDep nameAtVersion (Just EnvDevelopment)
 
-mkDep :: Text -> Maybe DepEnvironment -> Dependency
+mkDep :: Text -> Maybe DepEnvironment -> Either String Dependency
 mkDep nameAtVersion env = do
   let nameAndVersionSplit = Text.splitOn "@" nameAtVersion
   case nameAndVersionSplit of
     [name, version] ->
-      Dependency
-        NodeJSType
-        name
-        (CEq <$> (Just version))
-        mempty
-        (maybe mempty Set.singleton env)
-        mempty
-    _ -> error $ "Invalid package name format: " ++ toString nameAtVersion
+      Right $
+        Dependency
+          NodeJSType
+          name
+          (CEq <$> (Just version))
+          mempty
+          (maybe mempty Set.singleton env)
+          mempty
+    _ -> Left $ "Invalid package name format: " ++ toString nameAtVersion
 
 colors :: Dependency
 colors =
@@ -113,6 +128,21 @@ spec = do
   describe "can work with v9.0 format" $ do
     checkGraph pnpmLockV9 pnpmLockV9GraphSpec
 
+  describe "parsePnpmLock" $ do
+    it "parses v6 lockfile" $ do
+      lockfile <- readFileBS "test/Pnpm/fixtures/pnpm-lock-v6.yaml"
+      let result = parsePnpmLock lockfile
+      result `shouldSatisfy` isRight
+      let Right deps = result
+      deps `shouldMatchList` [colors, mkDevDep "[email protected]", mkDevDep "[email protected]"]
+
+    it "parses v9 lockfile" $ do
+      lockfile <- readFileBS "test/Pnpm/fixtures/pnpm-lock-v9.yaml"
+      let result = parsePnpmLock lockfile
+      result `shouldSatisfy` isRight
+      let Right deps = result
+      deps `shouldMatchList` [colors, mkDevDep "[email protected]", mkDevDep "[email protected]"]
+
 pnpmLockGraphSpec :: Graphing Dependency -> Spec
 pnpmLockGraphSpec graph = do
   let hasEdge :: Dependency -> Dependency -> IO ()
@@ -403,3 +433,11 @@ pnpmLockV9GraphSpec graph = do
         , mkProdDep "@npmcli/[email protected]"
         ]
         graph
+
+    it "should include Babel plugin dependencies" $ do
+      -- Test a few representative Babel plugin dependencies
+      hasEdge (mkProdDep "@babel/[email protected]") (mkProdDep "@babel/core@^7.0.0")
+      hasEdge (mkProdDep "@babel/[email protected]") (mkProdDep "@babel/core@^7.0.0")
+      hasEdge (mkProdDep "@babel/[email protected]") (mkProdDep "@babel/core@^7.0.0")
+      hasEdge (mkProdDep "@babel/[email protected]") (mkProdDep "@babel/types@*")
+      hasEdge (mkProdDep "@babel/[email protected]") (mkProdDep "@babel/types@*")