Skip to content

Commit a796bd9

Browse files
authored
fix: renamed the "animation" transition (#1750)
1 parent b3f94d2 commit a796bd9

7 files changed

Lines changed: 11 additions & 10 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ The Badge Magic app is a comprehensive LED badge management system that lets you
1919
- **Animation Mode**: Advanced animations including Pacman, hearts, fireworks, and more
2020

2121
### 🎭 **Animation & Effects**
22-
- **22 Animation Types**: Left, Right, Up, Down, Fixed, Snowflake, Picture, Laser, Pacman, Chevron, Diamond, Broken Hearts, Cupid, Feet, Fish, Diagonal, Emergency, Beating Hearts, Fireworks, Digital Rain (Equalizer), and Cycle
22+
- **22 Animation Types**: Left, Right, Up, Down, Fixed, Splitting, Snowflake, Picture, Laser, Pacman, Chevron, Diamond, Broken Hearts, Cupid, Feet, Fish, Diagonal, Emergency, Beating Hearts, Fireworks, Digital Rain (Equalizer), and Cycle
2323
- **3 Visual Effects**: Flash, Invert, and Marquee
2424
- **Speed Control**: 8-speed radial dial for precise animation timing
2525
- **Transition Tab**: Quick access to basic animations
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'package:badgemagic/badge_animation/animation_abstract.dart';
22

3-
class AniAnimation extends BadgeAnimation {
3+
class SplittingAnimation extends BadgeAnimation {
44
@override
55
void processAnimation(int badgeHeight, int badgeWidth, int animationIndex,
66
List<List<bool>> processGrid, List<List<bool>> canvas) {

lib/constants.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const Color dividerColor = Color(0xFFE0E0E0);
2525
const Color drawerHeaderTitle = Color(0xFFFFFFFF);
2626

2727
//path to all the animation assets used
28-
const String animation = 'assets/animations/ic_anim_animation.gif';
28+
const String aniSplitting = 'assets/animations/ic_anim_animation.gif';
2929
const String aniLeft = 'assets/animations/ic_anim_left.gif';
3030
const String aniDown = 'assets/animations/ic_anim_down.gif';
3131
const String aniFixed = 'assets/animations/ic_anim_fixed.gif';

lib/l10n/app_en.arb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
"speed": "Speed",
6464
"speedTitle": "Speed",
6565
"animation": "Animation",
66+
"animationSplitting": "Splitting",
6667
"transition": "Transition",
6768
"transitionTitle": "Transition",
6869
"effects": "Effects",

lib/providers/animation_badge_provider.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'package:badgemagic/providers/imageprovider.dart';
44
import 'package:badgemagic/providers/speed_dial_provider.dart';
55
import 'package:badgemagic/bademagic_module/utils/byte_array_utils.dart';
66
import 'package:badgemagic/bademagic_module/utils/converters.dart';
7-
import 'package:badgemagic/badge_animation/ani_animation.dart';
7+
import 'package:badgemagic/badge_animation/ani_splitting.dart';
88
import 'package:badgemagic/badge_animation/ani_down.dart';
99
import 'package:badgemagic/badge_animation/ani_fixed.dart';
1010
import 'package:badgemagic/badge_animation/ani_laser.dart';
@@ -40,7 +40,7 @@ Map<int, BadgeAnimation?> animationMap = {
4040
2: UpAnimation(),
4141
3: DownAnimation(),
4242
4: FixedAnimation(),
43-
5: AniAnimation(),
43+
5: SplittingAnimation(),
4444
6: SnowFlakeAnimation(),
4545
7: PictureAnimation(),
4646
8: LaserAnimation(),

lib/view/save_badge_screen.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'package:badgemagic/bademagic_module/utils/byte_array_utils.dart';
44
import 'package:badgemagic/bademagic_module/utils/converters.dart';
55
import 'package:badgemagic/bademagic_module/utils/file_helper.dart';
66
import 'package:badgemagic/bademagic_module/utils/toast_utils.dart';
7-
import 'package:badgemagic/badge_animation/ani_animation.dart';
7+
import 'package:badgemagic/badge_animation/ani_splitting.dart';
88
import 'package:badgemagic/badge_animation/ani_fixed.dart';
99
import 'package:badgemagic/constants.dart';
1010
import 'package:badgemagic/services/localization_service.dart';
@@ -239,8 +239,8 @@ class _SaveBadgeScreenState extends State<SaveBadgeScreen> {
239239
(msg) => msg.text.isNotEmpty)
240240
.length >
241241
1) {
242-
animationBadgeProvider
243-
.setAnimationMode(AniAnimation());
242+
animationBadgeProvider.setAnimationMode(
243+
SplittingAnimation());
244244
} else {
245245
animationBadgeProvider
246246
.setAnimationMode(FixedAnimation());

lib/view/widgets/transitiontab.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ class _TransitionTabState extends State<TransitionTab> {
7070
),
7171
Expanded(
7272
child: AniContainer(
73-
animation: animation,
74-
animationName: l10n.animation,
73+
animation: aniSplitting,
74+
animationName: l10n.animationSplitting,
7575
index: 5,
7676
),
7777
),

0 commit comments

Comments
 (0)